Fix license db generation removing attributes

* Removes is_builtin attribute from details
* Removes the text attribute as there already was a license_text
  displayed so this wasn't necessary

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

Author: AyanSinhaMahapatra

src/licensedcode/license_db.py

@@ -132,7 +132,7 @@ def generate_details(output_path, environment, licenses, test=False):
         base_context_mapping = base_context
     license_details_template = environment.get_template("license_details.html")
     for lic in licenses.values():
-        license_data = lic.to_dict(include_text=True)
+        license_data = lic.to_dict(include_text=False, include_builtin=False)
         html = license_details_template.render(
             **base_context_mapping,
             license=lic,

tests/licensedcode/data/license_db/license_dump/bash-exception-gpl.html

@@ -106,13 +106,6 @@
 
         </dd>
 
-        <dt style="">is_builtin</dt>
-        <dd>
-          
-            True
-          
-        </dd>
-      
         <dt style="">is_exception</dt>
         <dd>
 
@@ -136,19 +129,6 @@
 
         </dd>
 
-        <dt style="">text</dt>
-        <dd>
-          
-            The Free Software Foundation has exempted Bash from the requirement of
-Paragraph 2c of the General Public License.  This is to say, there is
-no requirement for Bash to print a notice when it is started
-interactively in the usual way.  We made this exception because users
-and standards expect shells not to print such messages.  This
-exception applies to any program that serves as a shell and that is
-based primarily on Bash as opposed to other GNU software.
-          
-        </dd>
-      
     </dl>
     <div class="text-bold">license_text</div>
     <pre id="license-text" class="code mt-1" style="white-space: pre-wrap;"><code>The Free Software Foundation has exempted Bash from the requirement of

tests/licensedcode/data/license_db/license_dump/bash-exception-gpl.json

@@ -5,11 +5,9 @@
   "category": "Copyleft",
   "owner": "Free Software Foundation (FSF)",
   "notes": "this used with GPL 1.0 and 2.0. It was removed from the V3 text https://git.savannah.gnu.org/cgit/bash.git/commit/COPYING?id=3185942a5234e26ab13fa02f9c51d340cec514f8",
-  "is_builtin": true,
   "is_exception": true,
   "spdx_license_key": "LicenseRef-scancode-bash-exception-gpl-2.0",
   "text_urls": [
     "https://git.savannah.gnu.org/cgit/bash.git/plain/COPYING?h=bash-3.0-rc1&id=dd9e6dfa23d0dae4888f11fb8c6a27bc36d1b283"
-  ],
-  "text": "The Free Software Foundation has exempted Bash from the requirement of\nParagraph 2c of the General Public License.  This is to say, there is\nno requirement for Bash to print a notice when it is started\ninteractively in the usual way.  We made this exception because users\nand standards expect shells not to print such messages.  This\nexception applies to any program that serves as a shell and that is\nbased primarily on Bash as opposed to other GNU software."
+  ]
 }

tests/licensedcode/data/license_db/license_dump/bash-exception-gpl.yml

@@ -4,16 +4,7 @@ name: Bash exception to GPL
 category: Copyleft
 owner: Free Software Foundation (FSF)
 notes: this used with GPL 1.0 and 2.0. It was removed from the V3 text https://git.savannah.gnu.org/cgit/bash.git/commit/COPYING?id=3185942a5234e26ab13fa02f9c51d340cec514f8
-is_builtin: yes
 is_exception: yes
 spdx_license_key: LicenseRef-scancode-bash-exception-gpl-2.0
 text_urls:
   - https://git.savannah.gnu.org/cgit/bash.git/plain/COPYING?h=bash-3.0-rc1&id=dd9e6dfa23d0dae4888f11fb8c6a27bc36d1b283
-text: |
-  The Free Software Foundation has exempted Bash from the requirement of
-  Paragraph 2c of the General Public License.  This is to say, there is
-  no requirement for Bash to print a notice when it is started
-  interactively in the usual way.  We made this exception because users
-  and standards expect shells not to print such messages.  This
-  exception applies to any program that serves as a shell and that is
-  based primarily on Bash as opposed to other GNU software.

tests/licensedcode/data/license_db/license_dump/binary-linux-firmware.html

@@ -106,52 +106,13 @@
 
         </dd>
 
-        <dt style="">is_builtin</dt>
-        <dd>
-          
-            True
-          
-        </dd>
-      
         <dt style="">spdx_license_key</dt>
         <dd>
 
             LicenseRef-scancode-binary-linux-firmware
 
         </dd>
 
-        <dt style="">text</dt>
-        <dd>
-          
-            Redistribution. Redistribution and use in binary form, without
-modification, are permitted provided that the following conditions are
-met:
-
-* Redistributions must reproduce the above copyright notice and the
-following disclaimer in the documentation and/or other materials
-provided with the distribution.
-
-* Neither the name of the Copyright Holder nor the names of its
-suppliers may be used to endorse or promote products derived from this
-software without specific prior written permission.
-
-* No reverse engineering, decompilation, or disassembly of this software
-is permitted.
-
-DISCLAIMER. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
-CONTRIBUTORS &#34;AS IS&#34; AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
-BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
-FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
-COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
-INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
-NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
-USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE
-          
-        </dd>
-      
     </dl>
     <div class="text-bold">license_text</div>
     <pre id="license-text" class="code mt-1" style="white-space: pre-wrap;"><code>Redistribution. Redistribution and use in binary form, without

tests/licensedcode/data/license_db/license_dump/binary-linux-firmware.json

@@ -5,7 +5,5 @@
   "category": "Proprietary Free",
   "owner": "Unspecified",
   "homepage_url": "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/",
-  "is_builtin": true,
-  "spdx_license_key": "LicenseRef-scancode-binary-linux-firmware",
-  "text": "Redistribution. Redistribution and use in binary form, without\nmodification, are permitted provided that the following conditions are\nmet:\n\n* Redistributions must reproduce the above copyright notice and the\nfollowing disclaimer in the documentation and/or other materials\nprovided with the distribution.\n\n* Neither the name of the Copyright Holder nor the names of its\nsuppliers may be used to endorse or promote products derived from this\nsoftware without specific prior written permission.\n\n* No reverse engineering, decompilation, or disassembly of this software\nis permitted.\n\nDISCLAIMER. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND\nCONTRIBUTORS \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,\nBUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND\nFITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE\nCOPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,\nINCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT\nNOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF\nUSE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON\nANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF\nTHIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE"
+  "spdx_license_key": "LicenseRef-scancode-binary-linux-firmware"
 }

tests/licensedcode/data/license_db/license_dump/binary-linux-firmware.yml

@@ -4,32 +4,4 @@ name: Binary-Only Linux Firmware License
 category: Proprietary Free
 owner: Unspecified
 homepage_url: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/
-is_builtin: yes
 spdx_license_key: LicenseRef-scancode-binary-linux-firmware
-text: |
-  Redistribution. Redistribution and use in binary form, without
-  modification, are permitted provided that the following conditions are
-  met:
-
-  * Redistributions must reproduce the above copyright notice and the
-  following disclaimer in the documentation and/or other materials
-  provided with the distribution.
-
-  * Neither the name of the Copyright Holder nor the names of its
-  suppliers may be used to endorse or promote products derived from this
-  software without specific prior written permission.
-
-  * No reverse engineering, decompilation, or disassembly of this software
-  is permitted.
-
-  DISCLAIMER. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
-  CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
-  BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
-  FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
-  COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
-  INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
-  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
-  USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-  ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE

tests/licensedcode/data/license_db/license_dump/bison-exception-2.0.html

@@ -99,13 +99,6 @@
 
         </dd>
 
-        <dt style="">is_builtin</dt>
-        <dd>
-          
-            True
-          
-        </dd>
-      
         <dt style="">is_exception</dt>
         <dd>
 
@@ -149,13 +142,6 @@
 
         </dd>
 
-        <dt style="">text</dt>
-        <dd>
-          
-            As a special exception, when this file is copied by Bison into a Bison output file, you may use that output file without restriction. This special exception was added by the Free Software Foundation in version 1.24 of Bison.
-          
-        </dd>
-      
     </dl>
     <div class="text-bold">license_text</div>
     <pre id="license-text" class="code mt-1" style="white-space: pre-wrap;"><code>As a special exception, when this file is copied by Bison into a Bison output file, you may use that output file without restriction. This special exception was added by the Free Software Foundation in version 1.24 of Bison.</code></pre>

tests/licensedcode/data/license_db/license_dump/bison-exception-2.0.json

@@ -4,10 +4,8 @@
   "name": "Bison exception to GPL 2.0 or later",
   "category": "Copyleft Limited",
   "owner": "Free Software Foundation (FSF)",
-  "is_builtin": true,
   "is_exception": true,
   "spdx_license_key": "LicenseRef-scancode-bison-exception-2.0",
   "faq_url": "http://www.gnu.org/software/bison/manual/bison.html#Conditions",
-  "standard_notice": "This library is free software; you can redistribute it and/or modify it\nunder the terms of the GNU General Public License as published by the Free\nSoftware Foundation; either version 2, or (at your option) any later\nversion.\nThis library is distributed in the hope that it will be useful, but WITHOUT\nANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\nFITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for\nmore details.\nYou should have received a copy of the GNU General Public License along\nwith this library; see the file COPYING. If not, write to the Free Software\nFoundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.\nAs a special exception, when this file is copied by Bison into a Bison\noutput file, you may use that output file without restriction. This special\nexception was added by the Free Software Foundation in version 1.24 of\nBison.\n",
-  "text": "As a special exception, when this file is copied by Bison into a Bison output file, you may use that output file without restriction. This special exception was added by the Free Software Foundation in version 1.24 of Bison."
+  "standard_notice": "This library is free software; you can redistribute it and/or modify it\nunder the terms of the GNU General Public License as published by the Free\nSoftware Foundation; either version 2, or (at your option) any later\nversion.\nThis library is distributed in the hope that it will be useful, but WITHOUT\nANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\nFITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for\nmore details.\nYou should have received a copy of the GNU General Public License along\nwith this library; see the file COPYING. If not, write to the Free Software\nFoundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.\nAs a special exception, when this file is copied by Bison into a Bison\noutput file, you may use that output file without restriction. This special\nexception was added by the Free Software Foundation in version 1.24 of\nBison.\n"
 }

tests/licensedcode/data/license_db/license_dump/bison-exception-2.0.yml

@@ -3,7 +3,6 @@ short_name: Bison exception to GPL 2.0 or later
 name: Bison exception to GPL 2.0 or later
 category: Copyleft Limited
 owner: Free Software Foundation (FSF)
-is_builtin: yes
 is_exception: yes
 spdx_license_key: LicenseRef-scancode-bison-exception-2.0
 faq_url: http://www.gnu.org/software/bison/manual/bison.html#Conditions
@@ -23,6 +22,3 @@ standard_notice: |
   output file, you may use that output file without restriction. This special
   exception was added by the Free Software Foundation in version 1.24 of
   Bison.
-text: As a special exception, when this file is copied by Bison into a Bison output file, you
-  may use that output file without restriction. This special exception was added by the Free
-  Software Foundation in version 1.24 of Bison.