Skip to content

Commit 00437e1

Browse files
Reorder license match attributes
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
1 parent e10358e commit 00437e1

File tree

205 files changed

+14722
-14734
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

205 files changed

+14722
-14734
lines changed

src/licensedcode/detection.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -670,32 +670,29 @@ def to_dict(
670670

671671
result = {}
672672

673-
# Detection Level Information
674-
result['score'] = self.score()
673+
result['license_expression'] = self.rule.license_expression
674+
result['license_expression_spdx'] = self.rule.spdx_license_expression()
675675
result['from_file'] = self.from_file
676676
result['start_line'] = self.start_line
677677
result['end_line'] = self.end_line
678+
if rule_details:
679+
result.update(self.rule.get_flags_mapping())
680+
result['matcher'] = self.matcher
681+
result['score'] = self.score()
678682
result['matched_length'] = self.len()
683+
if rule_details:
684+
result["rule_length"] = self.rule.length
679685
result['match_coverage'] = self.coverage()
680-
result['matcher'] = self.matcher
681-
682-
# LicenseDB Level Information (Rule that was matched)
683-
result['license_expression'] = self.rule.license_expression
684-
result['license_expression_spdx'] = self.rule.spdx_license_expression()
685-
result['rule_identifier'] = self.rule.identifier
686686
result['rule_relevance'] = self.rule.relevance
687+
result['rule_identifier'] = self.rule.identifier
687688
result['rule_url'] = self.rule.rule_url
688-
689-
# Extra rule details added optionally
690689
if rule_details:
691-
result.update(self.rule.get_flags_mapping())
692-
result["rule_length"] = self.rule.length
693-
result["rule_text"] = self.rule.text
694690
result["rule_notes"] = self.rule.notes
695691
result["referenced_filenames"] = self.rule.referenced_filenames
696-
697692
if include_text:
698693
result['matched_text'] = matched_text
694+
if rule_details:
695+
result["rule_text"] = self.rule.text
699696

700697
return result
701698

src/licensedcode/match.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -791,20 +791,17 @@ def to_dict(
791791

792792
result = {}
793793

794-
# Detection Level Information
795-
result['score'] = self.score()
794+
result['license_expression'] = self.rule.license_expression
795+
result['spdx_license_expression'] = self.rule.spdx_license_expression()
796+
result['from_file'] = file_path
796797
result['start_line'] = self.start_line
797798
result['end_line'] = self.end_line
798-
result['from_file'] = file_path
799+
result['matcher'] = self.matcher
800+
result['score'] = self.score()
799801
result['matched_length'] = self.len()
800802
result['match_coverage'] = self.coverage()
801-
result['matcher'] = self.matcher
802-
803-
# LicenseDB Level Information (Rule that was matched)
804-
result['license_expression'] = self.rule.license_expression
805-
result['spdx_license_expression'] = self.rule.spdx_license_expression()
806-
result['rule_identifier'] = self.rule.identifier
807803
result['rule_relevance'] = self.rule.relevance
804+
result['rule_identifier'] = self.rule.identifier
808805
result['rule_url'] = self.rule.rule_url
809806

810807
if include_text:

src/licensedcode/models.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1957,17 +1957,13 @@ def get_flags_mapping(self):
19571957
"""
19581958

19591959
rule_boolean_attributes = [
1960-
'is_license_text',
19611960
'is_license_text',
19621961
'is_license_notice',
19631962
'is_license_reference',
19641963
'is_license_tag',
19651964
'is_license_intro',
19661965
'is_license_clue',
19671966
'is_continuous',
1968-
'is_builtin',
1969-
'is_from_license',
1970-
'is_synthetic',
19711967
]
19721968

19731969
mapping = {}

0 commit comments

Comments
 (0)