fixed xhr calls pass the http headers

Author: abner

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.4.0+4
+
+- Fixed issue on xhr requests - wasn't passing headers to the requests
+
 # 0.4.0+3
 
 - Fixed dynamic library load for tests

assets/js/fetch.js

@@ -1,5 +1,6 @@
 function fetch(url, options) {
 	options = options || {};
+	console.log('fetCH OPTIONS: '+ JSON.stringify(arguments));
 	return new Promise( (resolve, reject) => {
 		const request = new XMLHttpRequest();
 		const keys = [];
@@ -15,10 +16,10 @@ function fetch(url, options) {
 			json: () => { 
 				// TODO: review this handle because it may discard \n from json attributes
 				try {
-					console.log('RESPONSE TEXT IN FETCH: ' + request.responseText);
+					// console.log('RESPONSE TEXT IN FETCH: ' + request.responseText);
 					return Promise.resolve(JSON.parse(request.responseText));
 				} catch (e) {
-					console.log('ERROR on fetch parsing JSON: ' + e.message);
+					// console.log('ERROR on fetch parsing JSON: ' + e.message);
 					return Promise.resolve(request.responseText);
 				}
 			},
@@ -47,8 +48,16 @@ function fetch(url, options) {
 
 		request.withCredentials = options.credentials=='include';
 
-		for (const i in options.headers) {
-			request.setRequestHeader(i, options.headers[i]);
+		if (options.headers) {
+			if (options.headers.constructor.name == 'Object') {
+				for (const i in options.headers) {
+					request.setRequestHeader(i, options.headers[i]);
+				}
+			} else { // if it is some Headers pollyfill, the way to iterate is through for of
+				for (const header of options.headers) {
+					request.setRequestHeader(header[0], header[1]);
+				}
+			}
 		}
 
 		request.send(options.body || null);

example/pubspec.lock

@@ -75,7 +75,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.4.0+3"
+    version: "0.4.0+4"
   flutter_test:
     dependency: "direct dev"
     description: flutter

lib/extensions/xhr.dart

@@ -366,21 +366,21 @@ extension JavascriptRuntimeXhrExtension on JavascriptRuntime {
       try {
         String? method = arguments[0];
         String? url = arguments[1];
-        List<String> headersList =
-            (arguments[2] as List<dynamic>).cast<String>();
+        dynamic headersList = arguments[2];
         String? body = arguments[3];
         int? idRequest = arguments[4];
 
         Map<String, String> headers = {};
-        headersList.forEach((value) {
-          final headerMatch = regexpHeader.allMatches(value).first;
-          String? headerName = headerMatch.group(0);
-          String? headerValue = headerMatch.group(1);
-          if (headerName != null) {
-            headers[headerName] = headerValue ?? '';
-          }
+        headersList.forEach((header) {
+          // final headerMatch = regexpHeader.allMatches(value).first;
+          // String? headerName = headerMatch.group(0);
+          // String? headerValue = headerMatch.group(1);
+          // if (headerName != null) {
+          //   headers[headerName] = headerValue ?? '';
+          // }
+          String headerKey = header[0];
+          headers[headerKey] = header[1];
         });
-
         (dartContext[XHR_PENDING_CALLS_KEY] as List<dynamic>).add(
           XhrPendingCall(
             idRequest: idRequest,

pubspec.yaml

@@ -1,7 +1,7 @@
 name: flutter_js
 description: A Javascript engine to use with flutter. 
   It uses Quickjs on Android and JavascriptCore on IOS
-version: 0.4.0+3
+version: 0.4.0+4
 homepage: https://github.com/abner/flutter_js
 repository: https://github.com/abner/flutter_js