cli: improve on update command

Signed-off-by: Abiola Ibrahim <git@abiosoft.com>

Author: abiosoft

environment/container/docker/docker.go

@@ -7,6 +7,7 @@ import (
 	"github.com/abiosoft/colima/cli"
 	"github.com/abiosoft/colima/config"
 	"github.com/abiosoft/colima/environment"
+	"github.com/abiosoft/colima/util/debutil"
 )
 
 // Name is container runtime name.
@@ -135,9 +136,11 @@ func (d dockerRuntime) Version(ctx context.Context) string {
 }
 
 func (d *dockerRuntime) Update(ctx context.Context) error {
-	return d.guest.Run(
-		"sh",
-		"-c",
-		"sudo apt-get -qq update -y && sudo apt-get -qq install -y --allow-change-held-packages docker-ce docker-ce-cli containerd.io",
-	)
+	packages := []string{
+		"docker-ce",
+		"docker-ce-cli",
+		"containerd.io",
+	}
+
+	return debutil.UpdateRuntime(ctx, d.guest, d, Name, packages...)
 }

environment/container/incus/incus.go

@@ -14,6 +14,7 @@ import (
 	"github.com/abiosoft/colima/environment"
 	"github.com/abiosoft/colima/environment/vm/lima/limautil"
 	"github.com/abiosoft/colima/util"
+	"github.com/abiosoft/colima/util/debutil"
 )
 
 const incusBridgeInterface = "incusbr0"
@@ -280,9 +281,13 @@ type networkInfo struct {
 }
 
 func (c *incusRuntime) Update(ctx context.Context) error {
-	return c.guest.Run(
-		"sh",
-		"-c",
-		"sudo apt-get -qq update -y && sudo apt-get -qq install -y --allow-change-held-packages incus incus-base incus-client incus-extra incus-ui-canonical",
-	)
+	packages := []string{
+		"incus",
+		"incus-base",
+		"incus-client",
+		"incus-extra",
+		"incus-ui-canonical",
+	}
+
+	return debutil.UpdateRuntime(ctx, c.guest, c, Name, packages...)
 }

util/debutil/debutil.go

@@ -0,0 +1,84 @@
+package debutil
+
+import (
+	"context"
+	"fmt"
+	"strings"
+
+	"github.com/abiosoft/colima/cli"
+	"github.com/abiosoft/colima/environment"
+)
+
+// packages is list of deb package names.
+type packages []string
+
+// Upgradable returns the shell command to check if the packages are upgradable with apt.
+// The returned command should be passed to 'sh -c' or equivalent.
+func (p packages) Upgradable() string {
+	cmd := "sudo apt list --upgradable | grep"
+	for _, v := range p {
+		cmd += fmt.Sprintf(" -e '^%s/'", v)
+	}
+	return cmd
+}
+
+// Install returns the shell command to install the packages with apt.
+// The returned command should be passed to 'sh -c' or equivalent.
+func (p packages) Install() string {
+	return "sudo apt-get install -y --allow-change-held-packages " + strings.Join(p, " ")
+}
+
+func UpdateRuntime(
+	ctx context.Context,
+	guest environment.GuestActions,
+	chain cli.CommandChain,
+	runtime string,
+	packageNames ...string,
+) error {
+	a := chain.Init(ctx)
+	log := a.Logger()
+
+	packages := packages(packageNames)
+
+	updatesAvailable := false
+
+	a.Stage("refreshing package manager")
+	a.Add(func() error {
+		return guest.RunQuiet(
+			"sh",
+			"-c",
+			"sudo apt-get update -y",
+		)
+	})
+
+	a.Stage("checking for updates")
+	a.Add(func() error {
+		err := guest.RunQuiet(
+			"sh",
+			"-c",
+			packages.Upgradable(),
+		)
+		updatesAvailable = err == nil
+		return nil
+	})
+
+	a.Add(func() (err error) {
+		if !updatesAvailable {
+			log.Warnf("no updates available for %s runtime", runtime)
+			return
+		}
+
+		log.Println("updating packages ...")
+		err = guest.RunQuiet(
+			"sh",
+			"-c",
+			packages.Install(),
+		)
+		if err == nil {
+			log.Println("done")
+		}
+		return
+	})
+
+	return a.Exec()
+}