refactor: fix eslint

Author: abichinger

.eslintignore

@@ -1,4 +1,7 @@
 !.vuepress
+
 .cache
 .temp
-dist
+node_modules
+dist
+docs/src/api/default/*.js

.eslintrc.js

@@ -1,7 +1,8 @@
 module.exports = {
   env: {
     browser: true,
-    es2021: true
+    es2021: true,
+    'jest/globals': true
   },
   extends: [
     'plugin:vue/vue3-essential',
@@ -12,7 +13,8 @@ module.exports = {
     sourceType: 'module'
   },
   plugins: [
-    'vue'
+    'vue',
+    'jest'
   ],
   rules: {
   }

core/src/util.js

@@ -141,7 +141,7 @@ function traverse (obj, ...keys) {
   if (keys.length === 0) { return obj }
 
   for (const key of keys[0]) {
-    if (obj.hasOwnProperty(key)) {
+    if (key in obj) {
       const res = traverse(obj[key], ...keys.slice(1))
       if (res !== undefined) {
         return res

core/test/core.test.js

@@ -4,7 +4,6 @@ import VueCron from '../src/core.vue'
 
 test('test VueCron', async () => {
   // render the component
-  const onUpdateValue = jest.fn()
   let slotProps = null
 
   const wrapper = mount(VueCron, {

core/test/multiple.test.js

@@ -1,8 +1,8 @@
 import multiple from '../src/fields/multiple'
-import util from '../src/util'
 import types from '../src/types'
+import util from '../src/util'
 const { strToArray, arrayToStr } = multiple
-const { Range, genItems } = util
+const { genItems } = util
 const { Field } = types
 
 const r = (min, max) => {

light/src/CronEditor.vue

@@ -5,7 +5,7 @@
             <span>{{period.prefix}}</span>
             <custom-select v-bind="period.attrs" v-on="period.events" :items="period.items" item-value="id" :cols="cols('period')" :width="width('period')" />
             <span>{{period.suffix}}</span>
-        
+
             <template v-for="f in fields" :key="f.id">
                 <span>{{f.prefix}}</span>
                 <custom-select v-bind="f.attrs" v-on="f.events" :items="f.items" :cols="cols(f.id)" :width="width(f.id)" multiple>{{f.selectedStr}}</custom-select>
@@ -20,33 +20,31 @@ import CronCore from '@vue-js-cron/core'
 import CustomSelect from './components/CustomSelect.vue'
 
 export default {
-    name: "VueCronEditor",
-    components:{
-        'CronCore': CronCore.component,
-        CustomSelect
-    },
-    props:{
-        cols: {
-            type: Function,
-            default: (fieldId) => {
-
-                if(fieldId == 'minute') return 5
-                else if (fieldId == 'hour') return 4
-                else if (fieldId == 'day') return 4
-                else return 1
-                
-            }
-        },
-        width: {
-            type: Function,
-            default: (fieldId) => {
-                if(fieldId == 'minute') return '10em'
-                else if (fieldId == 'hour') return '8em'
-                else if (fieldId == 'day') return '8em'
-                else return 'unset'
-            }
-        }
+  name: 'VueCronEditor',
+  components: {
+    CronCore: CronCore.component,
+    CustomSelect
+  },
+  props: {
+    cols: {
+      type: Function,
+      default: (fieldId) => {
+        if (fieldId === 'minute') return 5
+        else if (fieldId === 'hour') return 4
+        else if (fieldId === 'day') return 4
+        else return 1
+      }
     },
-    emits:['update:model-value', 'error']
+    width: {
+      type: Function,
+      default: (fieldId) => {
+        if (fieldId === 'minute') return '10em'
+        else if (fieldId === 'hour') return '8em'
+        else if (fieldId === 'day') return '8em'
+        else return 'unset'
+      }
+    }
+  },
+  emits: ['update:model-value', 'error']
 }
-</script>
+</script>

light/src/index.js

@@ -1,6 +1,6 @@
 // Import vue component
-import component from './CronEditor.vue'
 import core from '@vue-js-cron/core'
+import component from './CronEditor.vue'
 
 // Declare install function executed by Vue.use()
 export function install (Vue) {
@@ -16,16 +16,5 @@ const plugin = {
   util: core.util
 }
 
-// Auto-install when vue is found (eg. in browser via <script> tag)
-/* let GlobalVue = null;
-if (typeof window !== 'undefined') {
-	GlobalVue = window.Vue;
-} else if (typeof global !== 'undefined') {
-	GlobalVue = global.Vue;
-}
-if (GlobalVue) {
-	GlobalVue.use(plugin);
-} */
-
 // To allow use as module (npm/webpack/etc.) export component
 export default plugin

package.json

@@ -23,8 +23,8 @@
     "test": "yarn test-core",
     "test-core": "cd core && yarn test",
     "dry-run": "multi-semantic-release --dry-run",
-    "lint": "eslint **/src/**/*.js **/dev/**/*.js **/src/**/*.vue **/dev/**/*.vue **/.vuepress/**/*.js **/.vuepress/**/*.vue",
-    "lint-fix": "eslint --fix **/src/**/*.js **/dev/**/*.js **/src/**/*.vue **/dev/**/*.vue **/.vuepress/**/*.js **/.vuepress/**/*.vue"
+    "lint": "eslint '**/*.js' '**/*.vue'",
+    "lint-fix": "eslint --fix '**/*.js' '**/*.vue'"
   },
   "devDependencies": {
     "@babel/core": "^7.12.13",
@@ -42,6 +42,7 @@
     "eslint": "^8.0.1",
     "eslint-config-standard": "^17.0.0",
     "eslint-plugin-import": "^2.25.2",
+    "eslint-plugin-jest": "^26.8.2",
     "eslint-plugin-n": "^15.0.0",
     "eslint-plugin-promise": "^6.0.0",
     "eslint-plugin-vue": "^9.3.0",

vuetify/src/CronEditor.vue

@@ -8,8 +8,7 @@
                 <custom-select v-bind="period.attrs" :items="period.items" v-on="period.events" item-value="id" :density="density" :variant="variant"></custom-select>
             </v-col>
             <v-col v-if="period.suffix" class="flex-grow-0">{{period.suffix}}</v-col>
-            
-            
+
             <template v-for="f in fields" :key="f.id">
                 <v-col v-if="f.prefix" class="flex-grow-0">{{f.prefix}}</v-col>
                 <v-col cols="auto">
@@ -28,36 +27,34 @@ import CronCore from '@vue-js-cron/core'
 import CustomSelect from './components/CustomSelect.vue'
 
 export default {
-    name: "VueCronEditor",
-    components:{
-        'CronCore': CronCore.component,
-        CustomSelect
+  name: 'VueCronEditor',
+  components: {
+    CronCore: CronCore.component,
+    CustomSelect
+  },
+  props: {
+    variant: {
+      type: String,
+      default: 'elevated'
     },
-    props: {
-        variant: {
-            type: String,
-            default: 'elevated'
-        },
-            density: {
-            type: String,
-            default: 'default'
-        },
-        cols: {
-            type: Function,
-            default: (fieldId) => {
-
-                if(fieldId == 'minute') return 5
-                else if (fieldId == 'hour') return 4
-                else if (fieldId == 'day') return 4
-                else return 1
-                
-            }
-        },
+    density: {
+      type: String,
+      default: 'default'
     },
-    emits: ['update:model-value', 'error']
+    cols: {
+      type: Function,
+      default: (fieldId) => {
+        if (fieldId === 'minute') return 5
+        else if (fieldId === 'hour') return 4
+        else if (fieldId === 'day') return 4
+        else return 1
+      }
+    }
+  },
+  emits: ['update:model-value', 'error']
 }
 </script>
 
 <style lang="css">
 
-</style>
+</style>

vuetify/src/index.js

@@ -1,6 +1,6 @@
 // Import vue component
-import component from './CronEditor.vue'
 import core from '@vue-js-cron/core'
+import component from './CronEditor.vue'
 
 // Declare install function executed by Vue.use()
 export function install (Vue) {
@@ -16,16 +16,5 @@ const plugin = {
   util: core.util
 }
 
-// Auto-install when vue is found (eg. in browser via <script> tag)
-/* let GlobalVue = null;
-if (typeof window !== 'undefined') {
-	GlobalVue = window.Vue;
-} else if (typeof global !== 'undefined') {
-	GlobalVue = global.Vue;
-}
-if (GlobalVue) {
-	GlobalVue.use(plugin);
-} */
-
 // To allow use as module (npm/webpack/etc.) export component
 export default plugin