Tweaks

Author: aantron

src/soup.ml

@@ -1,8 +1,6 @@
 (* This file is part of Lambda Soup, released under the MIT license. See
    LICENSE.md for details, or visit https://github.com/aantron/lambdasoup. *)
 
-exception Parse_error of string
-
 module String =
 struct
   include String
@@ -433,6 +431,8 @@ let trimmed_texts node =
   |> List.map String.trim
   |> List.filter (fun s -> String.length s > 0)
 
+exception Parse_error of string
+
 module Selector :
 sig
   type t
@@ -807,12 +807,9 @@ struct
           | "$=" -> Suffix (name, value)
           | "*=" -> Substring (name, value)
           | _ ->
-            Printf.sprintf
-              "invalid attribute operator '%s'" operator
-            |> parse_error)
-        | Some _ ->
-          parse_error
-            "expected end of attribute selector (']')")))
+            Printf.ksprintf parse_error
+              "invalid attribute operator '%s'" operator)
+        | Some _ -> parse_error "expected end of attribute selector (']')")))
 
   let parse_class_selector stream =
     Stream.junk stream;
@@ -908,10 +905,8 @@ struct
       let selector = parse_parenthesized_value parse_simple_selector stream in
       Not selector
     | _ ->
-      Printf.sprintf
-        "unknown pseudo-class or pseudo-element ':%s'"
-        function_
-      |> parse_error)
+      Printf.ksprintf parse_error
+        "unknown pseudo-class or pseudo-element ':%s'" function_)
 
   and parse_simple_selector stream =
     match Stream.peek stream with

src/soup.mli

@@ -67,10 +67,7 @@ let _ = ul |> previous_siblings |> elements in
     for other versions can be downloaded from the
     {{:https://github.com/aantron/lambdasoup/releases} releases page}. *)
 
-(** {2 Exceptions} *)
 
-(** Raised when a CSS selector given to {!select} and similar functions is syntactically invalid. *)
-exception Parse_error of string
 
 (** {2 Types} *)
 
@@ -110,6 +107,14 @@ val parse : string -> soup node
     Lambda Soup something other than bytes, see {{:#2_Parsingsignals} Parsing
     signals}. *)
 
+exception Parse_error of string
+(** Raised when a CSS selector given to {!select} and similar functions is
+    syntactically invalid.
+
+    Note that {!parse} does not raise this exception, because the parsing of
+    HTML is done by {{:https://github.com/aantron/markup.ml} Markup.ml}. Lambda
+    Soup proper only parses CSS selectors. *)
+
 val select : string -> (_ node) -> element nodes
 (** [select selector node] is all the descendants of [node] matching CSS
     selector [selector]. All

test/test.ml

@@ -216,8 +216,9 @@ let suites = [
             assert_failure (Printf.sprintf "%s: got \"%s\"" selector s)
           | Soup.Parse_error message ->
             if (message <> expected_message) then assert_failure
-              (Printf.sprintf "Incorrect parse error for selector '%s': expected '%s' but got '%s'"
-                 selector expected_message message)
+              (Printf.sprintf
+                "Incorrect parse error for '%s': expected '%s' but got '%s'"
+                selector expected_message message)
             else true
         in
         if not result then