added bn254 to test curves

Author: quangvdao

test-curves/Cargo.toml

@@ -47,6 +47,10 @@ bn384_small_two_adicity_scalar_field = []
 bn384_small_two_adicity_base_field = []
 bn384_small_two_adicity_curve = [ "bn384_small_two_adicity_scalar_field", "bn384_small_two_adicity_base_field" ]
 
+bn254_scalar_field = []
+bn254_base_field = []
+bn254 = [ "bn254_scalar_field", "bn254_base_field" ]
+
 secp256k1 = []
 
 [[bench]]
@@ -79,3 +83,9 @@ name = "field_mul_u64"
 path = "benches/field_mul_u64.rs"
 harness = false
 required-features = ["secp256k1"]
+
+[[bench]]
+name = "bn254"
+path = "benches/bn254.rs"
+harness = false
+required-features = ["bn254"]

test-curves/benches/bn254.rs

@@ -0,0 +1,6 @@
+use ark_algebra_bench_templates::{bench, criterion_main, field_common, paste, prime_field, sqrt};
+// Import BN254 types
+use ark_test_curves::bn254::{Fq, Fr, G1Projective as G1};
+
+// Instantiate benchmarks for BN254
+bench!(Name = "BN254", Group = G1, ScalarField = Fr, BaseField = Fq,);

test-curves/src/bn254/fq.rs

@@ -0,0 +1,13 @@
+use ark_ff::fields::{Fp256, MontBackend, MontConfig};
+
+/// Defines the parameters for the base field `Fq` of the BN254 curve.
+#[derive(MontConfig)]
+#[modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583"]
+#[generator = "3"]
+pub struct FqConfig;
+
+/// The base field `Fq` of the BN254 curve.
+pub type Fq = Fp256<MontBackend<FqConfig, 4>>;
+
+pub const FQ_ONE: Fq = ark_ff::MontFp!("1");
+pub const FQ_ZERO: Fq = ark_ff::MontFp!("0");

test-curves/src/bn254/fr.rs

@@ -0,0 +1,17 @@
+use ark_ff::fields::{Fp256, MontBackend, MontConfig};
+// use ark_ff_macros::{MontConfig, MontFp}; // Keep MontFp for constants
+
+/// Defines the parameters for the scalar field `Fr` of the BN254 curve.
+#[derive(MontConfig)]
+#[modulus = "21888242871839275222246405745257275088548364400416034343698204186575808495617"]
+#[generator = "5"]
+// Define Small subgroup base/power if needed, otherwise macro defaults are fine
+// #[small_subgroup_base = "3"]
+// #[small_subgroup_power = "2"]
+pub struct FrConfig;
+
+/// The scalar field `Fr` of the BN254 curve.
+pub type Fr = Fp256<MontBackend<FrConfig, 4>>;
+
+pub const FR_ONE: Fr = ark_ff::MontFp!("1");
+pub const FR_ZERO: Fr = ark_ff::MontFp!("0");

test-curves/src/bn254/g1.rs

@@ -0,0 +1,53 @@
+use ark_ec::models::short_weierstrass::{
+    Affine, Projective, SWCurveConfig,
+};
+use ark_ec::CurveConfig;
+use ark_ff::{Field, MontFp, Zero, AdditiveGroup};
+
+use crate::bn254::{Fq, Fr}; // Assuming Fq is defined in fq.rs
+
+#[derive(Clone, Default, PartialEq, Eq)]
+pub struct G1Config;
+
+impl CurveConfig for G1Config {
+    type BaseField = Fq;
+    type ScalarField = Fr;
+
+    /// COFACTOR = 1
+    const COFACTOR: &'static [u64] = &[1];
+
+    /// COFACTOR_INV = COFACTOR^{-1} mod r = 1
+    const COFACTOR_INV: Self::ScalarField = Fr::ONE;
+}
+
+impl SWCurveConfig for G1Config {
+    /// COEFF_A = 0
+    const COEFF_A: Self::BaseField = Fq::ZERO;
+
+    /// COEFF_B = 3
+    const COEFF_B: Self::BaseField = MontFp!("3");
+
+    /// AFFINE_GENERATOR_COEFFS = (G1_GENERATOR_X, G1_GENERATOR_Y)
+    const GENERATOR: Affine<Self> = Affine::new_unchecked(G1_GENERATOR_X, G1_GENERATOR_Y);
+
+    #[inline(always)]
+    fn mul_by_a(_base: Self::BaseField) -> Self::BaseField {
+        // A is zero, avoids a multiply
+        Self::BaseField::zero()
+    }
+
+    #[inline(always)]
+    fn is_in_correct_subgroup_assuming_on_curve(_p: &Affine<Self>) -> bool {
+        // The cofactor is 1, so any point on the curve is in the correct subgroup.
+        true
+    }
+}
+
+/// G1_GENERATOR_X = 1
+pub const G1_GENERATOR_X: Fq = MontFp!("1");
+
+/// G1_GENERATOR_Y = 2
+pub const G1_GENERATOR_Y: Fq = MontFp!("2");
+
+pub type G1Affine = Affine<G1Config>;
+pub type G1Projective = Projective<G1Config>;

test-curves/src/bn254/mod.rs

@@ -0,0 +1,19 @@
+#[cfg(feature = "bn254_base_field")]
+pub mod fq;
+#[cfg(feature = "bn254_base_field")]
+pub use fq::*;
+
+#[cfg(feature = "bn254_scalar_field")]
+pub mod fr;
+#[cfg(feature = "bn254_scalar_field")]
+pub use fr::*;
+
+#[cfg(feature = "bn254")] // Use the main bn254 feature
+pub mod g1;
+#[cfg(feature = "bn254")] // Use the main bn254 feature
+pub use g1::*;
+
+// TODO: Define G2, GT, Pairing for BN254 similarly if needed
+
+#[cfg(test)]
+mod test; // Renamed from tests to test.rs

test-curves/src/bn254/test.rs

@@ -0,0 +1,23 @@
+#![allow(unused_imports)]
+use ark_ec::{
+    models::short_weierstrass::SWCurveConfig, // Keep this as G1 is SW
+    pairing::Pairing,
+    AffineRepr, CurveGroup, PrimeGroup,
+};
+use ark_ff::{Field, One, UniformRand, Zero};
+use ark_std::{rand::Rng, test_rng};
+
+// Add imports for the newly defined types
+use crate::bn254::{Fq, FqConfig, Fr, FrConfig, G1Affine, G1Projective};
+
+use ark_algebra_test_templates::*;
+use ark_std::ops::{AddAssign, MulAssign, SubAssign};
+
+test_field!(fr; Fr; mont_prime_field);
+// Uncomment Fq test
+test_field!(fq; Fq; mont_prime_field);
+
+// Uncomment G1 test for Short Weierstrass
+test_group!(g1; G1Projective; sw);
+
+// Add other tests for G2, Pairing etc. as needed

test-curves/src/lib.rs

@@ -30,4 +30,7 @@ pub mod bn384_small_two_adicity;
 #[cfg(feature = "secp256k1")]
 pub mod secp256k1;
 
+#[cfg(feature = "bn254")]
+pub mod bn254;
+
 pub mod fp128;