Implement Task 5.2: Consistent error handling across all commands

Created centralized ErrorHandler utility with:
- Consistent error format: "Error: [context] - message"
- Proper stderr output for all errors
- Error aggregation with bullet points
- Automatic solution suggestions for common issues
- Rich formatting with bracket escaping

Updated all commands to use ErrorHandler:
- init: File existence and creation errors
- schema: Schema loading, validation, and CRUD errors
- values: Value setting, validation, and management errors
- validate: Schema and validation errors with proper context
- generate: Generation and validation errors

Error improvements:
- All errors now go to stderr (not stdout)
- Consistent "Error: [context] - message" format
- Better error aggregation for validation failures
- Actionable solution suggestions
- Proper Rich formatting and bracket escaping

Test updates:
- Fixed all validation tests to check stderr instead of stdout
- All 117 tests passing with 81% coverage
- Better error message validation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: ritwik-g

guide/idea phase2.md

@@ -0,0 +1,4 @@
+- Support loading `.env` file for ENV based secrets
+- Support to add schemas without interaction.
+- value from multiple options
+-

helm_values_manager/commands/generate.py

@@ -5,12 +5,12 @@
 import typer
 from rich.console import Console
 
-from helm_values_manager.generator import GeneratorError, generate_values
+from helm_values_manager.errors import ErrorHandler, GeneratorError
+from helm_values_manager.generator import generate_values
 from helm_values_manager.utils import get_values_file_path, load_schema, load_values
 from helm_values_manager.validator import validate_single_environment
 
 console = Console()
-err_console = Console(stderr=True)
 app = typer.Typer()
 
 
@@ -24,8 +24,7 @@ def generate_command(
     # Load schema
     schema_obj = load_schema(schema)
     if not schema_obj:
-        err_console.print("[red]Error:[/red] Schema file not found")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("generate", "Schema file not found")
 
     # Determine values file path
     values_path = values or get_values_file_path(env)
@@ -37,19 +36,14 @@ def generate_command(
     errors = validate_single_environment(schema_obj, values_data, env)
 
     if errors:
-        err_console.print("[red]Error:[/red] Validation failed. Please fix the following issues:")
-        for error in errors:
-            err_console.print(f"  - {error}")
-        raise typer.Exit(1)
+        ErrorHandler.print_errors(errors, f"generate --env {env}")
 
     # Generate values.yaml
     try:
         yaml_content = generate_values(schema_obj, values_data, env)
         # Output to stdout
         print(yaml_content, end='')
     except GeneratorError as e:
-        err_console.print(f"[red]Error:[/red] {e}")
-        raise typer.Exit(1)
+        ErrorHandler.handle_exception(e, "generate")
     except Exception as e:
-        err_console.print(f"[red]Error:[/red] Failed to generate values: {e}")
-        raise typer.Exit(1)
+        ErrorHandler.handle_exception(e, "generate")

helm_values_manager/commands/init.py

@@ -4,6 +4,8 @@
 import typer
 from rich.console import Console
 
+from helm_values_manager.errors import ErrorHandler
+
 console = Console()
 
 SCHEMA_FILE = "schema.json"
@@ -16,8 +18,10 @@ def init_command(
     schema_path = Path(SCHEMA_FILE)
 
     if schema_path.exists() and not force:
-        console.print(f"[red]Error:[/red] {SCHEMA_FILE} already exists. Use --force to overwrite.")
-        raise typer.Exit(1)
+        ErrorHandler.print_error(
+            "init",
+            f"{SCHEMA_FILE} already exists. Use --force to overwrite."
+        )
 
     initial_schema = {
         "values": []
@@ -29,5 +33,4 @@ def init_command(
 
         console.print(f"[green]✓[/green] Created {SCHEMA_FILE}")
     except Exception as e:
-        console.print(f"[red]Error:[/red] Failed to create schema file: {e}")
-        raise typer.Exit(1)
+        ErrorHandler.handle_exception(e, "init")

helm_values_manager/commands/schema.py

@@ -5,6 +5,7 @@
 from rich.console import Console
 from rich.prompt import Confirm, Prompt
 
+from helm_values_manager.errors import ErrorHandler, SchemaError, error_console
 from helm_values_manager.models import SchemaValue, ValueType
 from helm_values_manager.utils import load_schema, save_schema, validate_key_unique, validate_path_format
 
@@ -22,15 +23,15 @@ def parse_value_by_type(value_str: str, value_type: ValueType) -> Any:
                 return float(value_str)
             return int(value_str)
         except ValueError:
-            raise typer.BadParameter(f"Invalid number: {value_str}")
+            raise SchemaError(f"Invalid number: {value_str}")
     elif value_type == "boolean":
         lower = value_str.lower()
         if lower in ("true", "yes", "y", "1"):
             return True
         elif lower in ("false", "no", "n", "0"):
             return False
         else:
-            raise typer.BadParameter(f"Invalid boolean: {value_str}")
+            raise SchemaError(f"Invalid boolean: {value_str}")
     elif value_type == "array":
         try:
             return json.loads(value_str)
@@ -41,7 +42,7 @@ def parse_value_by_type(value_str: str, value_type: ValueType) -> Any:
         try:
             return json.loads(value_str)
         except json.JSONDecodeError:
-            raise typer.BadParameter(f"Invalid JSON object: {value_str}")
+            raise SchemaError(f"Invalid JSON object: {value_str}")
 
 
 @app.command("add")
@@ -52,20 +53,19 @@ def add_command(
     # Load existing schema
     schema = load_schema(schema_path)
     if not schema:
-        console.print("[red]Error:[/red] No schema.json found. Run 'init' first.")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", "No schema.json found. Run 'init' first.")
 
     console.print("[bold]Add new value to schema[/bold]\n")
 
     # Prompt for key
     while True:
         key = Prompt.ask("Key (unique identifier)")
         if not key:
-            console.print("[red]Key cannot be empty[/red]")
+            error_console.print("[red]Key cannot be empty[/red]")
             continue
 
         if not validate_key_unique(schema, key):
-            console.print(f"[red]Key '{key}' already exists in schema[/red]")
+            error_console.print(f"[red]Key '{key}' already exists in schema[/red]")
             continue
 
         break
@@ -74,7 +74,7 @@ def add_command(
     while True:
         path = Prompt.ask("Path (dot-separated YAML path)")
         if not validate_path_format(path):
-            console.print("[red]Invalid path format. Use alphanumeric characters and dots only.[/red]")
+            error_console.print("[red]Invalid path format. Use alphanumeric characters and dots only.[/red]")
             continue
         break
 
@@ -88,7 +88,7 @@ def add_command(
         value_type = Prompt.ask("Type", default="string").lower()
         if value_type in type_choices:
             break
-        console.print(f"[red]Invalid type. Choose from: {', '.join(type_choices)}[/red]")
+        error_console.print(f"[red]Invalid type. Choose from: {', '.join(type_choices)}[/red]")
 
     # Prompt for required
     required = Confirm.ask("Required?", default=True)
@@ -101,8 +101,8 @@ def add_command(
             try:
                 default = parse_value_by_type(default_str, value_type)
                 break
-            except typer.BadParameter as e:
-                console.print(f"[red]{e}[/red]")
+            except SchemaError as e:
+                error_console.print(f"[red]{e}[/red]")
 
     # Prompt for sensitive
     sensitive = Confirm.ask("Sensitive value?", default=False)
@@ -139,8 +139,7 @@ def list_command(
     """List all values in the schema."""
     schema = load_schema(schema_path)
     if not schema:
-        console.print("[red]Error:[/red] No schema.json found. Run 'init' first.")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", "No schema.json found. Run 'init' first.")
 
     if not schema.values:
         console.print("No values defined in schema.")
@@ -168,14 +167,12 @@ def get_command(
     """Show details of a specific schema value."""
     schema = load_schema(schema_path)
     if not schema:
-        console.print("[red]Error:[/red] No schema.json found. Run 'init' first.")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", "No schema.json found. Run 'init' first.")
 
     # Find the value
     value = next((v for v in schema.values if v.key == key), None)
     if not value:
-        console.print(f"[red]Error:[/red] Value with key '{key}' not found")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", f"Value with key '{key}' not found")
 
     # Display details
     console.print(f"\n[bold]{value.key}[/bold]")
@@ -196,14 +193,12 @@ def update_command(
     """Update an existing schema value."""
     schema = load_schema(schema_path)
     if not schema:
-        console.print("[red]Error:[/red] No schema.json found. Run 'init' first.")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", "No schema.json found. Run 'init' first.")
 
     # Find the value
     value_index = next((i for i, v in enumerate(schema.values) if v.key == key), None)
     if value_index is None:
-        console.print(f"[red]Error:[/red] Value with key '{key}' not found")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", f"Value with key '{key}' not found")
 
     value = schema.values[value_index]
     console.print(f"[bold]Updating '{key}'[/bold]\n")
@@ -213,7 +208,7 @@ def update_command(
     new_path = Prompt.ask(f"Path [{value.path}]", default=value.path)
     if new_path != value.path:
         while not validate_path_format(new_path):
-            console.print("[red]Invalid path format. Use alphanumeric characters and dots only.[/red]")
+            error_console.print("[red]Invalid path format. Use alphanumeric characters and dots only.[/red]")
             new_path = Prompt.ask(f"Path [{value.path}]", default=value.path)
         value.path = new_path
 
@@ -227,7 +222,7 @@ def update_command(
     new_type = Prompt.ask(f"Type [{value.type}]", default=value.type).lower()
     if new_type != value.type:
         while new_type not in type_choices:
-            console.print(f"[red]Invalid type. Choose from: {', '.join(type_choices)}[/red]")
+            error_console.print(f"[red]Invalid type. Choose from: {', '.join(type_choices)}[/red]")
             new_type = Prompt.ask(f"Type [{value.type}]", default=value.type).lower()
         value.type = new_type
         # Clear default if type changed
@@ -246,8 +241,8 @@ def update_command(
                 try:
                     value.default = parse_value_by_type(default_str, value.type)
                     break
-                except typer.BadParameter as e:
-                    console.print(f"[red]{e}[/red]")
+                except SchemaError as e:
+                    error_console.print(f"[red]{e}[/red]")
     else:
         default_display = json.dumps(value.default) if value.type in ['array', 'object'] else str(value.default)
         console.print(f"\nCurrent default value: {default_display}")
@@ -271,13 +266,13 @@ def update_command(
                     try:
                         value.default = parse_value_by_type(default_str, value.type)
                         break
-                    except typer.BadParameter as e:
-                        console.print(f"[red]{e}[/red]")
+                    except SchemaError as e:
+                        error_console.print(f"[red]{e}[/red]")
                 break
             elif choice == "3":
                 # Remove default value
                 if value.required:
-                    console.print("[yellow]Warning:[/yellow] This field is required but will have no default value")
+                    ErrorHandler.print_warning("This field is required but will have no default value")
                     if not Confirm.ask("Continue removing default?", default=False):
                         continue
 
@@ -303,14 +298,12 @@ def remove_command(
     """Remove a value from the schema."""
     schema = load_schema(schema_path)
     if not schema:
-        console.print("[red]Error:[/red] No schema.json found. Run 'init' first.")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", "No schema.json found. Run 'init' first.")
 
     # Find the value
     value_index = next((i for i, v in enumerate(schema.values) if v.key == key), None)
     if value_index is None:
-        console.print(f"[red]Error:[/red] Value with key '{key}' not found")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("schema", f"Value with key '{key}' not found")
 
     value = schema.values[value_index]
 

helm_values_manager/commands/validate.py

@@ -6,6 +6,7 @@
 import typer
 from rich.console import Console
 
+from helm_values_manager.errors import ErrorHandler
 from helm_values_manager.models import Schema
 from helm_values_manager.utils import load_schema, load_values, get_values_file_path
 from helm_values_manager.validator import validate_single_environment
@@ -31,20 +32,17 @@ def validate_command(
     # Check if schema file exists first
     schema_path = Path(schema)
     if not schema_path.exists():
-        console.print("[red]Error:[/red] Schema file not found")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("validate", "Schema file not found")
 
     # Load schema
     try:
         with open(schema_path) as f:
             data = json.load(f)
         schema_obj = Schema(**data)
     except json.JSONDecodeError:
-        console.print("[red]Error:[/red] Invalid JSON in schema file")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("validate", "Invalid JSON in schema file")
     except Exception as e:
-        console.print(f"[red]Error:[/red] Invalid schema: {e}")
-        raise typer.Exit(1)
+        ErrorHandler.print_error("validate", f"Invalid schema: {e}")
 
     # Load values
     values_data = load_values(env, values)
@@ -53,11 +51,6 @@ def validate_command(
     errors = validate_single_environment(schema_obj, values_data, env)
 
     if errors:
-        console.print("[red]Error:[/red] Validation failed:")
-        for error in errors:
-            # Escape square brackets for Rich
-            escaped_error = error.replace("[", "\\[").replace("]", "]")
-            console.print(f"  - {escaped_error}")
-        raise typer.Exit(1)
+        ErrorHandler.print_errors(errors, f"validate --env {env}")
     else:
         console.print(f"[green]✅[/green] Validation passed for environment: {env}")