fix: improve logger debug output handling

- Update HelmLogger to properly handle HELM_DEBUG=0 and HELM_DEBUG=false
- Add pytest-style unit tests for HELM_DEBUG=0 and HELM_DEBUG=false cases
- Add test-plugin.sh script with --debug flag for testing

Author: ritwik-g

helm_values_manager/utils/logger.py

@@ -15,7 +15,7 @@ class HelmLogger:
     Logger class that follows Helm plugin conventions.
 
     This logger:
-    1. Writes debug messages only when HELM_DEBUG is set
+    1. Writes debug messages only when HELM_DEBUG is set and not "0" or "false"
     2. Writes all messages to stderr (Helm convention)
     3. Uses string formatting for better performance
     4. Provides consistent error and debug message formatting
@@ -24,13 +24,14 @@ class HelmLogger:
     @staticmethod
     def debug(msg: str, *args: Any) -> None:
         """
-        Print debug message if HELM_DEBUG is set.
+        Print debug message if HELM_DEBUG is set and not "0" or "false".
 
         Args:
             msg: Message with optional string format placeholders
             args: Values to substitute in the message
         """
-        if os.environ.get("HELM_DEBUG"):
+        debug_val = os.environ.get("HELM_DEBUG", "").lower()
+        if debug_val and debug_val not in ("0", "false"):
             if args:
                 msg = msg % args
             print("[debug] %s" % msg, file=sys.stderr)

tests/unit/utils/test_logger.py

@@ -34,6 +34,28 @@ def test_debug_with_helm_debug_disabled(logger):
         assert stderr.getvalue() == ""
 
 
+def test_debug_with_helm_debug_zero(logger):
+    """Test debug output when HELM_DEBUG=0."""
+    stderr = StringIO()
+    with (
+        mock.patch.dict(os.environ, {"HELM_DEBUG": "0"}),
+        mock.patch("helm_values_manager.utils.logger.sys.stderr", stderr),
+    ):
+        logger.debug("Test message")
+        assert stderr.getvalue() == ""
+
+
+def test_debug_with_helm_debug_false(logger):
+    """Test debug output when HELM_DEBUG=false."""
+    stderr = StringIO()
+    with (
+        mock.patch.dict(os.environ, {"HELM_DEBUG": "false"}),
+        mock.patch("helm_values_manager.utils.logger.sys.stderr", stderr),
+    ):
+        logger.debug("Test message")
+        assert stderr.getvalue() == ""
+
+
 def test_debug_with_formatting(logger):
     """Test debug output with string formatting."""
     stderr = StringIO()

tools/test-plugin.sh

@@ -0,0 +1,100 @@
+#!/bin/bash
+set -e  # Exit on any error
+
+# Colors for output
+GREEN='\033[0;32m'
+RED='\033[0;31m'
+NC='\033[0m' # No Color
+
+# Default values
+INSTALL_SOURCE="local"
+GITHUB_URL="https://github.com/Zipstack/helm-values-manager"  # Correct capitalization
+DEBUG_FLAG=""
+
+# Parse command line arguments
+while [[ $# -gt 0 ]]; do
+    case $1 in
+        --source)
+            if [[ "$2" != "local" && "$2" != "github" ]]; then
+                echo "Error: --source must be either 'local' or 'github'"
+                exit 1
+            fi
+            INSTALL_SOURCE="$2"
+            shift 2
+            ;;
+        --github-url)
+            # Remove .git suffix if present
+            GITHUB_URL="${2%.git}"
+            shift 2
+            ;;
+        --debug)
+            DEBUG_FLAG="--debug"
+            shift
+            ;;
+        *)
+            echo "Unknown option: $1"
+            echo "Usage: $0 [--source local|github] [--github-url URL] [--debug]"
+            echo "Example:"
+            echo "  $0                                          # Install from local directory"
+            echo "  $0 --source github                         # Install from default GitHub repo"
+            echo "  $0 --source github --github-url URL        # Install from custom GitHub repo"
+            echo "  $0 --debug                                # Run with debug output"
+            exit 1
+            ;;
+    esac
+done
+
+# Get the absolute path to the plugin directory if installing locally
+if [ "$INSTALL_SOURCE" = "local" ]; then
+    PLUGIN_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+fi
+
+echo "Installing helm-values-manager plugin..."
+# Remove existing plugin if it exists
+helm plugin remove values-manager 2>/dev/null || true
+
+# Install plugin based on source
+if [ "$INSTALL_SOURCE" = "local" ]; then
+    echo "Installing from local directory: $PLUGIN_DIR"
+    helm plugin install "$PLUGIN_DIR"
+else
+    echo "Installing from GitHub: $GITHUB_URL"
+    helm plugin install "$GITHUB_URL"
+fi
+
+echo -e "\n${GREEN}Running test sequence...${NC}"
+
+# Clean up any existing test files
+rm -f helm-values.json .helm-values.lock
+
+# Initialize with a valid release name
+echo -e "\n${GREEN}1. Initializing helm values configuration...${NC}"
+helm values-manager init -r "test-release" $DEBUG_FLAG
+
+# Add deployments
+echo -e "\n${GREEN}2. Adding deployments...${NC}"
+helm values-manager add-deployment test-deployment $DEBUG_FLAG
+helm values-manager add-deployment dev $DEBUG_FLAG
+helm values-manager add-deployment prod $DEBUG_FLAG
+
+# Add value configurations
+echo -e "\n${GREEN}3. Adding value configurations...${NC}"
+helm values-manager add-value-config -p "app.config.name" -d "Application name" -r $DEBUG_FLAG
+helm values-manager add-value-config -p "app.config.replicas" -d "Number of replicas" $DEBUG_FLAG
+
+# Set values for different environments
+echo -e "\n${GREEN}4. Setting values...${NC}"
+helm values-manager set-value -p "app.config.name" -v "my-test-app" -d dev $DEBUG_FLAG
+helm values-manager set-value -p "app.config.replicas" -v "1" -d dev $DEBUG_FLAG
+helm values-manager set-value -p "app.config.name" -v "my-prod-app" -d prod $DEBUG_FLAG
+helm values-manager set-value -p "app.config.replicas" -v "3" -d prod $DEBUG_FLAG
+
+# Verify configurations
+echo -e "\n${GREEN}5. Verifying configurations...${NC}"
+echo -e "\nhelm-values.json contents:"
+cat helm-values.json
+
+echo -e "\n.helm-values.lock contents:"
+cat .helm-values.lock
+
+echo -e "\n${GREEN}Test sequence completed successfully!${NC}"