Skip to content

Commit be1d1e1

Browse files
committed
fix: restore PathData.get_value to return Value object
- Return Value object instead of resolved string value - Remove resolve parameter as it's now handled by Value.get() - Update tests to verify Value object return - Maintain proper logging This provides better control over value resolution and access to Value object features, especially for sensitive values.
1 parent 2c505cf commit be1d1e1

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

helm_values_manager/models/path_data.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,24 +72,21 @@ def set_value(self, environment: str, value: Value) -> None:
7272

7373
self._values[environment] = value
7474

75-
def get_value(self, environment: str, resolve: bool = False) -> Optional[str]:
75+
def get_value(self, environment: str) -> Optional[Value]:
7676
"""
77-
Get the value for a specific environment.
77+
Get the Value object for a specific environment.
7878
7979
Args:
80-
environment: The environment to get the value for
81-
resolve: Whether to resolve the value (for sensitive values)
80+
environment (str): The environment to get the value for
8281
8382
Returns:
84-
Optional[str]: The value if found, None otherwise
83+
Optional[Value]: The Value object if it exists, None otherwise
8584
"""
8685
logger.debug("Getting value for path %s in environment %s", self.path, environment)
8786
value = self._values.get(environment)
8887
if value is None:
8988
logger.debug("No value found for path %s in environment %s", self.path, environment)
90-
return None
91-
92-
return value.get(resolve=resolve)
89+
return value
9390

9491
def get_environments(self) -> Iterator:
9592
"""

tests/unit/models/test_path_data.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ def test_get_value_nonexistent_environment(path_data):
5050

5151
def test_get_value(path_data, mock_value):
5252
"""Test getting a value."""
53-
mock_value.get.return_value = "test_value"
5453
path_data.set_value("test", mock_value)
55-
assert path_data.get_value("test") == "test_value"
54+
assert path_data.get_value("test") == mock_value
5655

5756

5857
def test_get_environments(path_data, mock_value):

0 commit comments

Comments
 (0)