fix: improve code quality

- Fix mutable default argument in PathData
- Add proper Optional type annotation
- Improve debug value handling in logger
- Add explicit default for HELM_DEBUG
- Simplify debug logic for better readability

Author: ritwik-g

helm_values_manager/models/path_data.py

@@ -15,7 +15,7 @@
 class PathData:
     """Manages metadata and values for a configuration path."""
 
-    def __init__(self, path: str, metadata: Dict[str, Any] = {}):
+    def __init__(self, path: str, metadata: Optional[Dict[str, Any]] = None):
         """
         Initialize PathData with a path and metadata.
 
@@ -24,6 +24,8 @@ def __init__(self, path: str, metadata: Dict[str, Any] = {}):
             metadata: Dictionary containing metadata for the path
         """
         self.path = path
+        if metadata is None:
+            metadata = {}
         self._metadata = ConfigMetadata(
             description=metadata.get("description", ConfigMetadata.DEFAULT_DESCRIPTION),
             required=metadata.get("required", ConfigMetadata.DEFAULT_REQUIRED),

helm_values_manager/utils/logger.py

@@ -30,11 +30,12 @@ def debug(msg: str, *args: Any) -> None:
             msg: Message with optional string format placeholders
             args: Values to substitute in the message
         """
-        debug_val = os.environ.get("HELM_DEBUG", "").lower()
-        if debug_val and debug_val not in ("0", "false"):
-            if args:
-                msg = msg % args
-            print("[debug] %s" % msg, file=sys.stderr)
+        debug_val = os.environ.get("HELM_DEBUG", "false").lower()
+        if debug_val in ("0", "false"):
+            return
+        if args:
+            msg = msg % args
+        print("[debug] %s" % msg, file=sys.stderr)
 
     @staticmethod
     def error(msg: str, *args: Any) -> None: