Skip to content

WIP: Adding overdrive payback times to the overdrive eco panel #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Adding overdrive payback times to the overdrive eco panel #4608

wants to merge 1 commit into from

Conversation

@danfireman
Copy link
Contributor

TODO features:

  • Ensure initial sizing of the panel matches number of labels in it
  • Decide what layout to go for (e.g. to have E building type and time on same line?)
  • Make font size actually respond to attempts to change it with the slider.

TODO code quality:

  • Deduplicate code (e.g. SecondsToMinutesSeconds or the various bits of logic)
  • Refactor to avoid too much overdrive specific stuff (the file is too big as it is)
  • Arrange methods sensibly in file
  • Remove debugging
  • Put OrangeString somewhere
  • Confirm whether to support customization of formatting
  • Method naming
  • Condense code (there's got be be better way of doing the label counting)
  • Stop exposing a field on an object called externalFunctions
  • Decide whether overdrive is just an "extra panel" or whether it merits separate treatment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danfireman