Redirect to home index after linking discord, try message box

Author: DeinFreund

Zero-K.info/Controllers/HomeController.cs

@@ -24,6 +24,7 @@
 using Newtonsoft.Json.Linq;
 using System.Threading;
 using System.Threading.Tasks;
+using Licho.Utils.Web;
 
 namespace ZeroKWeb.Controllers
 {
@@ -240,8 +241,15 @@ public ActionResult NotLoggedIn()
 
         public async Task<ActionResult> DiscordAuth(string code, string state)
         {
-            await Global.Server.DiscordWebApi.LinkAccount(state, code);
-            return Content("Linking discord account");
+            if (await Global.Server.DiscordWebApi.LinkAccount(state, code))
+            {
+                MessageBox.Show("Discord account linked!");
+            }
+            else
+            {
+                MessageBox.Show("An error occured while linking the Discord account.");
+            }
+            return View("HomeIndex");
         }
 
         [AcceptVerbs(HttpVerbs.Post | HttpVerbs.Get)]

ZkLobbyServer/DiscordWebApi.cs

@@ -44,12 +44,11 @@ public string GetAnonymousId(int accountId)
             return state;
         }
 
-        public async Task LinkAccount(string state, string code)
+        public async Task<bool> LinkAccount(string state, string code)
         {
             try
             {
                 int accountId;
-                Trace.TraceInformation("Linking discord id...");
                 if (!userIds.TryGetValue(state, out accountId))
                 {
                     Trace.TraceWarning("Invalid state " + state);
@@ -69,15 +68,12 @@ public async Task LinkAccount(string state, string code)
                 var response = await new HttpClient().SendAsync(request);
                 response.EnsureSuccessStatusCode();
 
-                Trace.TraceInformation("Sent discord identify request...");
                 var payload = JObject.Parse(await response.Content.ReadAsStringAsync());
                 var token = payload.Value<string>("access_token");
 
                 var discord = new DiscordRestClient();
-                Trace.TraceInformation("Logging in discord client...");
                 await discord.LoginAsync(TokenType.Bearer, token);
                 var discordId = discord.CurrentUser.Id;
-                Trace.TraceInformation("Got discord id " + discordId);
                 using (var db = new ZkDataContext())
                 {
                     var existing = db.Accounts.FirstOrDefault(x => x.DiscordID == discordId);
@@ -87,15 +83,17 @@ public async Task LinkAccount(string state, string code)
                         existing.DiscordID = (decimal?)null;
                         db.SaveChanges();
                     }
-                    Trace.TraceInformation("Linking discord id " + discordId + " to Account " + existing.Name);
+                    Trace.TraceInformation("Linking discord id " + discordId + " to Account " + accountId);
                     db.Accounts.FirstOrDefault(x => x.AccountID == accountId).DiscordID = discordId;
                     db.SaveChanges();
                 }
             }
             catch (Exception ex)
             {
                 Trace.TraceError("Error linking discord ID " + ex);
+                return false;
             }
+            return true;
         }
     }