Skip to content

Commit 5021a58

Browse files
author
Luca Forstner
authored
feat: Pass parentSampleRate to tracesSampler (getsentry#15024)
1 parent bde8318 commit 5021a58

File tree

42 files changed

+469
-102
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+469
-102
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ sentryTest('should capture an INP click event span after pageload', async ({ bro
6767
'sentry.exclusive_time': inpValue,
6868
'sentry.op': 'ui.interaction.click',
6969
'sentry.origin': 'auto.http.browser.inp',
70-
'sentry.sample_rate': 1,
7170
'sentry.source': 'custom',
7271
transaction: 'test-url',
7372
'user_agent.original': expect.stringContaining('Chrome'),

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ sentryTest(
7070
'sentry.exclusive_time': inpValue,
7171
'sentry.op': 'ui.interaction.click',
7272
'sentry.origin': 'auto.http.browser.inp',
73-
'sentry.sample_rate': 1,
7473
'sentry.source': 'custom',
7574
transaction: 'test-route',
7675
'user_agent.original': expect.stringContaining('Chrome'),

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ sentryTest(
250250
const navigationTraceId = navigationTraceContext?.trace_id;
251251
expect(headers['sentry-trace']).toMatch(new RegExp(`^${navigationTraceId}-[0-9a-f]{16}-1$`));
252252
expect(headers['baggage']).toEqual(
253-
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${navigationTraceId},sentry-sample_rate=1,sentry-sampled=true,sentry-sample_rand=${navigationTraceHeader?.sample_rand}`,
253+
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${navigationTraceId},sentry-sampled=true,sentry-sample_rand=${navigationTraceHeader?.sample_rand},sentry-sample_rate=1`,
254254
);
255255
},
256256
);
@@ -313,7 +313,7 @@ sentryTest(
313313
const navigationTraceId = navigationTraceContext?.trace_id;
314314
expect(headers['sentry-trace']).toMatch(new RegExp(`^${navigationTraceId}-[0-9a-f]{16}-1$`));
315315
expect(headers['baggage']).toEqual(
316-
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${navigationTraceId},sentry-sample_rate=1,sentry-sampled=true,sentry-sample_rand=${navigationTraceHeader?.sample_rand}`,
316+
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${navigationTraceId},sentry-sampled=true,sentry-sample_rand=${navigationTraceHeader?.sample_rand},sentry-sample_rate=1`,
317317
);
318318
},
319319
);

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ sentryTest(
240240
// sampling decision is propagated from active span sampling decision
241241
expect(headers['sentry-trace']).toMatch(new RegExp(`^${pageloadTraceId}-[0-9a-f]{16}-1$`));
242242
expect(headers['baggage']).toBe(
243-
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${pageloadTraceId},sentry-sample_rate=1,sentry-sampled=true,sentry-sample_rand=${pageloadTraceHeader?.sample_rand}`,
243+
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${pageloadTraceId},sentry-sampled=true,sentry-sample_rand=${pageloadTraceHeader?.sample_rand},sentry-sample_rate=1`,
244244
);
245245
},
246246
);
@@ -297,7 +297,7 @@ sentryTest(
297297
// sampling decision is propagated from active span sampling decision
298298
expect(headers['sentry-trace']).toMatch(new RegExp(`^${pageloadTraceId}-[0-9a-f]{16}-1$`));
299299
expect(headers['baggage']).toBe(
300-
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${pageloadTraceId},sentry-sample_rate=1,sentry-sampled=true,sentry-sample_rand=${pageloadTraceHeader?.sample_rand}`,
300+
`sentry-environment=production,sentry-public_key=public,sentry-trace_id=${pageloadTraceId},sentry-sampled=true,sentry-sample_rand=${pageloadTraceHeader?.sample_rand},sentry-sample_rate=1`,
301301
);
302302
},
303303
);

dev-packages/e2e-tests/test-applications/astro-4/tests/tracing.dynamic.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
3131
data: expect.objectContaining({
3232
'sentry.op': 'pageload',
3333
'sentry.origin': 'auto.pageload.browser',
34-
'sentry.sample_rate': 1,
3534
'sentry.source': 'url',
3635
}),
3736
op: 'pageload',

dev-packages/e2e-tests/test-applications/astro-4/tests/tracing.static.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ test.describe('tracing in static/pre-rendered routes', () => {
3636
data: expect.objectContaining({
3737
'sentry.op': 'pageload',
3838
'sentry.origin': 'auto.pageload.browser',
39-
'sentry.sample_rate': 1,
4039
'sentry.source': 'url',
4140
}),
4241
op: 'pageload',

dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.dynamic.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
3131
data: expect.objectContaining({
3232
'sentry.op': 'pageload',
3333
'sentry.origin': 'auto.pageload.browser',
34-
'sentry.sample_rate': 1,
3534
'sentry.source': 'url',
3635
}),
3736
op: 'pageload',

dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.serverIslands.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ test.describe('tracing in static routes with server islands', () => {
3333
data: expect.objectContaining({
3434
'sentry.op': 'pageload',
3535
'sentry.origin': 'auto.pageload.browser',
36-
'sentry.sample_rate': 1,
3736
'sentry.source': 'url',
3837
}),
3938
op: 'pageload',
@@ -75,7 +74,6 @@ test.describe('tracing in static routes with server islands', () => {
7574
data: expect.objectContaining({
7675
'sentry.op': 'http.server',
7776
'sentry.origin': 'auto.http.astro',
78-
'sentry.sample_rate': 1,
7977
'sentry.source': 'route',
8078
}),
8179
op: 'http.server',

dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.static.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ test.describe('tracing in static/pre-rendered routes', () => {
3636
data: expect.objectContaining({
3737
'sentry.op': 'pageload',
3838
'sentry.origin': 'auto.pageload.browser',
39-
'sentry.sample_rate': 1,
4039
'sentry.source': 'url',
4140
}),
4241
op: 'pageload',

dev-packages/e2e-tests/test-applications/nestjs-distributed-tracing/tests/events.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ test('Event emitter', async () => {
3232
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
3333
data: {
3434
'sentry.source': 'custom',
35-
'sentry.sample_rate': 1,
3635
'sentry.op': 'event.nestjs',
3736
'sentry.origin': 'auto.event.nestjs',
3837
},

0 commit comments

Comments
 (0)