Merge pull request rmosolgo#4866 from rmosolgo/treat-max-page-size-as-implicit-first

Revert hasNextPage change when first isn't present

Author: rmosolgo

gemfiles/rails_7.1.gemfile

@@ -13,5 +13,6 @@ gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
 gem "sequel"
 gem "evt"
 gem "async"
+gem "libev_scheduler"
 
 gemspec path: "../"

lib/graphql/pagination/array_connection.rb

@@ -56,12 +56,12 @@ def load_nodes
             false
           end
 
-          @has_next_page = if first_value && first
-            # There are more items after these items
-            sliced_nodes.count > first
-          elsif before
+          @has_next_page = if before
             # The original array is longer than the `before` index
             index_from_cursor(before) < items.length + 1
+          elsif first
+            # There are more items after these items
+            sliced_nodes.count > first
           else
             false
           end

lib/graphql/pagination/relation_connection.rb

@@ -29,14 +29,14 @@ def has_previous_page
 
       def has_next_page
         if @has_next_page.nil?
-          @has_next_page = if first && first_value
+          @has_next_page = if before_offset && before_offset > 0
+            true
+          elsif first
             if @nodes && @nodes.count < first
               false
             else
               relation_larger_than(sliced_nodes, @sliced_nodes_offset, first)
             end
-          elsif before_offset && before_offset > 0
-            true
           else
             false
           end

spec/integration/mongoid/graphql/relay/mongo_relation_connection_spec.rb

@@ -238,7 +238,7 @@ def get_last_cursor(result)
         # Max page size is applied _without_ `first`, also
         result = star_trek_query(query_string)
         assert_equal(2, result["data"]["federation"]["bases"]["edges"].size)
-        assert_equal(false, result["data"]["federation"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
+        assert_equal(true, result["data"]["federation"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
       end
 
       it "applies to queries by `last`" do
@@ -297,7 +297,7 @@ def get_last_cursor(result)
         # Max page size is applied _without_ `first`, also
         result = star_trek_query(query_string)
         assert_equal(3, result["data"]["federation"]["bases"]["edges"].size)
-        assert_equal(false, result["data"]["federation"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
+        assert_equal(true, result["data"]["federation"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
       end
 
       it "applies to queries by `last`" do

spec/integration/rails/graphql/relay/array_connection_spec.rb

@@ -174,7 +174,7 @@ def get_names(result)
         # Max page size is applied _without_ `first`, also
         result = star_wars_query(query_string)
         assert_equal(["Yavin", "Echo Base"], get_names(result))
-        assert_equal(false, get_page_info(result)["hasNextPage"], "hasNextPage is false when first is not specified")
+        assert_equal(true, get_page_info(result)["hasNextPage"], "hasNextPage is false when first is not specified")
       end
 
       it "applies to queries by `last`" do
@@ -234,7 +234,7 @@ def get_page_info(result)
         # Max page size is applied _without_ `first`, also
         result = star_wars_query(query_string)
         assert_equal(["Yavin", "Echo Base", "Secret Hideout"], get_names(result))
-        assert_equal(false, get_page_info(result)["hasNextPage"], "hasNextPage is false when first is not specified")
+        assert_equal(true, get_page_info(result)["hasNextPage"], "hasNextPage is false when first is not specified")
       end
 
       it "applies to queries by `last`" do

spec/integration/rails/graphql/relay/relation_connection_spec.rb

@@ -287,7 +287,7 @@ def get_last_cursor(result)
         # Max page size is applied _without_ `first`, also
         result = star_wars_query(query_string)
         assert_equal(2, result["data"]["empire"]["bases"]["edges"].size)
-        assert_equal(false, result["data"]["empire"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
+        assert_equal(true, result["data"]["empire"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
       end
 
       it "applies to queries by `last`" do
@@ -346,7 +346,7 @@ def get_last_cursor(result)
         # Max page size is applied _without_ `first`, also
         result = star_wars_query(query_string)
         assert_equal(3, result["data"]["empire"]["bases"]["edges"].size)
-        assert_equal(false, result["data"]["empire"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
+        assert_equal(true, result["data"]["empire"]["bases"]["pageInfo"]["hasNextPage"], "hasNextPage is false when first is not specified")
       end
 
       it "applies to queries by `last`" do

spec/support/connection_assertions.rb

@@ -255,7 +255,7 @@ def assert_names(expected_names, result)
           assert_names [], res
 
           res = exec_query(query_str, after: after_cursor, before: before_cursor, first: 3)
-          assert_equal false, get_page_info(res, "hasNextPage")
+          assert_equal true, get_page_info(res, "hasNextPage")
           assert_equal true, get_page_info(res, "hasPreviousPage")
           assert_names [], res
         end
@@ -317,7 +317,7 @@ def assert_names(expected_names, result)
           res = exec_query(query_str, {})
           # Neither first nor last was provided, so default_page_size was applied.
           assert_names(["Avocado", "Beet", "Cucumber", "Dill"], res)
-          assert_equal false, get_page_info(res, "hasNextPage")
+          assert_equal true, get_page_info(res, "hasNextPage")
           assert_equal false, get_page_info(res, "hasPreviousPage")
         end