Some code clean ups/reductions in allocations.

Add test to call client multiple times in quick succesion to try to reproduce issue.
Add logic to detect zero offset returned or zero bytes transferred (with success status) and report as error via error handler.
Ignore nuget.exe and config.

Author: Troy Willmot

.gitignore

@@ -212,3 +212,4 @@ GeneratedArtifacts/
 _Pvt_Extensions/
 ModelManifest.xml
 /src/Yort.Ntp.Android/Yort.Ntp.Android.csproj.bak
+/.nuget

src/Yort.Ntp.Net40.Tests/NtpClientTests.cs

@@ -23,7 +23,33 @@ public void NtpClient_DefaultServer_GetsNonNullResponse()
 				client.ErrorOccurred += Client_ErrorOccurred;
 				client.BeginRequestTime();
 				_GotResultSignal.WaitOne(1000);
-				Assert.AreNotEqual(null, _Result);
+				Assert.IsNotNull(_Result);
+			}
+			finally
+			{
+				client.TimeReceived -= this.Client_TimeReceived;
+				client.ErrorOccurred -= this.Client_ErrorOccurred;
+			}
+		}
+
+		[TestMethod]
+		[TestCategory("NetworkRequiredTests")]
+		public void NtpClient_DefaultServer_GetsValidResponsesOverMultipleRequests()
+		{
+			var ntpEpoch = new DateTime(1900, 01, 01, 0, 0, 0, DateTimeKind.Utc);
+			_GotResultSignal = new System.Threading.AutoResetEvent(false);
+			var client = new Yort.Ntp.NtpClient();
+			try
+			{
+				client.TimeReceived += Client_TimeReceived;
+				client.ErrorOccurred += Client_ErrorOccurred;
+				for (int cnt = 0; cnt < 60; cnt++)
+				{
+					client.BeginRequestTime();
+					_GotResultSignal.WaitOne(1000);
+					Assert.IsNotNull(_Result);
+					Assert.AreNotEqual(ntpEpoch, _Result);
+				}
 			}
 			finally
 			{
@@ -34,6 +60,7 @@ public void NtpClient_DefaultServer_GetsNonNullResponse()
 
 		private void Client_ErrorOccurred(object sender, NtpNetworkErrorEventArgs e)
 		{
+			Assert.Fail(e.Exception.Message);
 			_GotResultSignal.Set();
 		}
 

src/Yort.Ntp.Shared.StandardSockets/NtpClientStandardSockets.cs

@@ -173,7 +173,12 @@ private void Socket_Completed_ProcessResult(object sender, SocketAsyncEventArgs
 				socket = ((System.Net.Sockets.Socket)sender);
 
 				if (e.SocketError == SocketError.Success)
-					ConvertBufferToCurrentTime(e.Buffer);
+				{
+					if (e.BytesTransferred == 0)
+						OnErrorOccurred(new NtpNetworkException("No data received."));
+					else
+						ConvertBufferToCurrentTime(e.Buffer);
+				}
 				else
 					OnErrorOccurred(NtpNetworkExceptionFromSocketArgs(e));
 			}

src/Yort.Ntp.SharedImplementation/AssemblyInfoCommon.cs

@@ -13,7 +13,7 @@
 #endif
 [assembly: AssemblyCompany("Yort")]
 [assembly: AssemblyProduct("Yort.Ntp")]
-[assembly: AssemblyCopyright("Copyright ©  2017.")]
+[assembly: AssemblyCopyright("Copyright © 2018.")]
 [assembly: AssemblyCulture("")]
 
 // Setting ComVisible to false makes the types in this assembly not visible 
@@ -32,5 +32,5 @@
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("1.0.12.0")]
-[assembly: AssemblyFileVersion("1.0.12.0")]
+[assembly: AssemblyVersion("1.0.13.0")]
+[assembly: AssemblyFileVersion("1.0.13.0")]

src/Yort.Ntp.SharedImplementation/NtpClient.cs

@@ -15,6 +15,8 @@ public partial class NtpClient
 
 		private readonly string _ServerAddress;
 
+		private static readonly DateTime NtpEpoch = new DateTime(1900, 1, 1, 0, 0, 0, DateTimeKind.Utc);
+
 		#endregion
 
 		#region Events
@@ -199,9 +201,14 @@ private void ConvertBufferToCurrentTime(byte[] buffer)
 			}
 
 			ulong milliseconds = (hTime * 1000 + (lTime * 1000) / 0x100000000L);
+			if (milliseconds == 0)
+			{
+				OnErrorOccurred(new NtpNetworkException("Incomplete or invalid data received."));
+				return;
+			}
 
-			var timeSpan = TimeSpan.FromTicks((long)milliseconds * TimeSpan.TicksPerMillisecond);
-			var currentTime = new DateTime(1900, 1, 1, 0, 0, 0, DateTimeKind.Utc) + timeSpan;
+			var timeSpan = TimeSpan.FromMilliseconds(milliseconds);
+			var currentTime = NtpEpoch + timeSpan;
 
 			OnTimeReceived(currentTime);
 		}