Skip to content

Commit 505f108

Browse files
authored
Update README.md
1 parent 6b61263 commit 505f108

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This is a modular monolith Fast API project that uses the latest and greatest to
44

55
For quick setup instructions, jump to the [Setup and development](#setup-and-development) section.
66
This project serves as a proof of concept and starting point for building modular monolith applications with FastAPI.
7-
For technical details, see [Choosing technology](#project-implementation)
7+
For technical details, see [Project Implementation](#project-implementation)
88

99
## Architecture and Design
1010

@@ -131,7 +131,7 @@ the [Purpose of sub applications](https://www.reddit.com/r/FastAPI/comments/11yz
131131
**Alternatives:** we don't have to use mounts, we could just run multiple application instances under the same python process. uvicorn exposes [`serve`](https://gist.github.com/tenuki/ff67f87cba5c4c04fd08d9c800437477?permalink_comment_id=4236491#gistcomment-4236491) which can be used to orchestrate multiple applications under the same python process, this however forces us to use different ports for each application! this may be desirable and puts us even closer to the microservice architecture.
132132
**Bonus point to the alternative:** by manutally creating the AsyncIO event loop we can mirror javascript promises and make asyncio act like promises when used with `asyncio.create_task` [How can I start a Python async coroutine eagerly?](https://stackoverflow.com/a/77268945/12603110)
133133

134-
we could go even further and implement [Domain-driven design with Python and FastAPI](https://www.actidoo.com/en/blog/python-fastapi-domain-driven-design) which goes as far as to force "restriction of import between domains" is a little bit of a stretch, stopping here is a good compromise.
134+
we could go even further and implement [Domain-driven design with Python and FastAPI](https://www.actidoo.com/en/blog/python-fastapi-domain-driven-design) which goes as far as to force "restriction of import between domains" is a little bit of a stretch, so it was only partially implemented
135135

136136
### Context aware logger
137137

@@ -187,7 +187,7 @@ Both services use [SQLModel](https://sqlmodel.tiangolo.com/) for database operat
187187
```bash
188188
# User 1 adopts Pet 1
189189
curl -X 'POST' \
190-
'http://127.0.0.1:8000/user/users/1/pets/1' \
190+
'http://127.0.0.1:8000/user/1/pets/1' \
191191
-H 'accept: application/json' \
192192
-d ''
193193
```
@@ -217,7 +217,7 @@ Response shows the user with their newly adopted pet:
217217
```bash
218218
# Give a treat to Pet 1
219219
curl -X 'POST' \
220-
'http://127.0.0.1:8000/pet/pets/1/treat' \
220+
'http://127.0.0.1:8000/pet/1/treat' \
221221
-H 'accept: application/json' \
222222
-d ''
223223
```

0 commit comments

Comments
 (0)