[Question]: Poetry or Still pip?

[hadialqattan]

Description

I wonder if this is still useful or it should be replaced with a poetry command

auto-registrar/scripts/install.sh

Lines 346 to 354 in 514ea7c

	function python_venv {
	pip install virtualenv -q || pip3 install virtualenv -q
	python -m venv .venv > /dev/null 2>&1 || python3 -m venv .venv > /dev/null 2>&1
	source .venv/bin/activate
	pip install -r requirements.txt -q || pip3 install -r requirements.txt -q
	deactivate
	green "Python virtual environment created and packages installed."
	yellow "Type \`source .venv/bin/activate\` to activate the environment and \`deactivate\` to deactivate it."
	}

Steps to reproduce

null

Screenshots and recordings

No response

Source

Source Code

Auto Registrar Version

null

Python Version

null

OS Platform or Distribution

null

Additional context

No response

Code of Conduct

• I agree to follow the Auto Registrar Code of Conduct

[hadialqattan]

Also, it seems like pyproject.toml is configured for Python3.10+, does it really needs Python3.10?

[hadialqattan]

+ I feel like this issue is invalid coz it's open upon the source code of the main branch 😅

[Yokozuna59]

I wonder if this is still useful or it should be replaced with a poetry command

I guess it should. Thanks!

[Yokozuna59]

Also, it seems like pyproject.toml is configured for Python3.10+, does it really needs Python3.10?

At first, I added union returned type functions. Which is available only on 3.10+. But, I removed them since it's not needed and didn't edit the version in pyproject.toml file.

[hadialqattan]

Anyway, I've changed the required Python version locally, python = "^3.8.10" is the minimum working version (otherwise dependency conflicts would appear. they're fixable but I believe 3.8.10 as a minimum is reasonable these days). Also, don't forget to re-lock the poetry.lock file as it has some issues with some poetry older (still in use) versions.

[hadialqattan]

Anyway, I've changed the required version locally, python = "^3.8.10" is the minimum working version (otherwise dependency conflicts would appear. they're fixable but I believe 3.8.10 as a minimum is reasonable these days). Also, don't forget to re-lock the poetry.lock file as it has some issues with some poetry older (still in use) versions.