multipages download problem

[moomenoueslati-bpk]

HI,

when i try to download multipages, i see that we can download only the half of the pages alaways
if i try to download 20 pages, only the first 10 pages will be donwloaded, if i try 10 pages only the first 5 pages will be downloaded.

have you an idea why this happen?
Thanks

[Xwilarg]

Hey, are you on the latest version?
If you are and you don't mind, do you think you could try with this one: https://github.com/Xwilarg/NHentaiDownloader/releases/tag/v2.1.10
And tell me if you have the same issue?

[moomenoueslati-bpk]

hey, sorry for the delay,
I try with 2.2.0 and with 2.1.10 and the same problem.

and there is also another problem

Manifest version 2 is deprecated, and support will be removed in 2025. See https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline for details.

[Xwilarg]

Hi, for the manifest V2 it is a known issue #86

I don't really work much on this project anymore so I'll have a look if I find time but I can't promise anything

[moomenoueslati-bpk]

hi
i try to investigate the code and i found this
hope this will help you

NHentaiDownloader/ src/background/background.ts
async function downloadAllPagesAsync (L139)
for (let i = 0; i < pagesArr.length; i++) {
let curr = pagesArr[i];
curr = pagesArr[0];
pagesArr.splice(0, 1);
let m = /page=([0-9]+)/.exec(url)
if (m !== null) {
url = url.replace(m[0], "page=" + curr);
} else if (url.includes("?")) {
url += "&page=" + curr
} else {
url += "?page=" + curr
}

why you overwriting the curr like this
let curr = pagesArr[i];
curr = pagesArr[0];
pagesArr.splice(0, 1);

i think the problem came from here when you splice the pages the pagesArr.length will be wrong so for this it always download the half of pages

Solution:
pageTotal = pagesArr.length
for (let i = 0; i < pageTotal; i++) {
let curr = pagesArr[i];
curr = pagesArr[0];
pagesArr.splice(0, 1);

OR
while (pagesArr.length > 0) {
let curr = pagesArr.shift();
// ... the rest
}

[moomenoueslati-bpk]

hi
i try to investigate the code and i found this
hope this will help you

NHentaiDownloader/ src/background/background.ts
async function downloadAllPagesAsync (L139)
for (let i = 0; i < pagesArr.length; i++) {
let curr = pagesArr[i];
curr = pagesArr[0];
pagesArr.splice(0, 1);
let m = /page=([0-9]+)/.exec(url)
if (m !== null) {
url = url.replace(m[0], "page=" + curr);
} else if (url.includes("?")) {
url += "&page=" + curr
} else {
url += "?page=" + curr
}

why you overwriting the curr like this
let curr = pagesArr[i];
curr = pagesArr[0];
pagesArr.splice(0, 1);

i think the problem came from here when you splice the pages the pagesArr.length will be wrong so for this it always download the half of pages

Solution:
pageTotal = pagesArr.length
for (let i = 0; i < pageTotal; i++) {
let curr = pagesArr[i];
curr = pagesArr[0];
pagesArr.splice(0, 1);

OR
while (pagesArr.length > 0) {
let curr = pagesArr.shift();
// ... the rest
}

thanks