Merge pull request #349 from MJMortimer/f-init-params

MJMortimer · web-flow · commit e01e013f7102 · 2018-09-12T09:57:51.000+12:00
Initialise Parameters property in XeroHttpClient constructor
diff --git a/CoreTests/ApiWrapperTest.cs b/CoreTests/ApiWrapperTest.cs
@@ -6,6 +6,11 @@ namespace CoreTests
 {
     public class ApiWrapperTest
     {
+        public ApiWrapperTest()
+        {
+            System.Net.ServicePointManager.SecurityProtocol = System.Net.SecurityProtocolType.Tls12;
+        }
+
         private IXeroCoreApi _api;
 
         protected Account BankAccount { get; set; }
diff --git a/CoreTests/App.config b/CoreTests/App.config
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <startup>
-    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.0"/>
+    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.1"/>
   </startup>
 
   <appSettings>
diff --git a/CoreTests/CoreTests.csproj b/CoreTests/CoreTests.csproj
@@ -9,7 +9,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>CoreTests</RootNamespace>
     <AssemblyName>CoreTests</AssemblyName>
-    <TargetFrameworkVersion>v4.0</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.5.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
     <TargetFrameworkProfile />
@@ -24,6 +24,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <LangVersion>5</LangVersion>
+    <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <PlatformTarget>AnyCPU</PlatformTarget>
@@ -33,6 +34,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup>
     <StartupObject />
diff --git a/Xero.Api/Infrastructure/Http/XeroHttpClient.cs b/Xero.Api/Infrastructure/Http/XeroHttpClient.cs
@@ -24,6 +24,7 @@ private XeroHttpClient(IJsonObjectMapper jsonMapper, IXmlObjectMapper xmlMapper)
         {
             JsonMapper = jsonMapper;
             XmlMapper = xmlMapper;
+            Parameters = new NameValueCollection();
         }
 
         public XeroHttpClient(string baseUri, IAuthenticator auth, IConsumer consumer, IUser user,

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,11 @@ namespace CoreTests`
`6`	`6`	`{`
`7`	`7`	`public class ApiWrapperTest`
`8`	`8`	`{`
	`9`	`+ public ApiWrapperTest()`
	`10`	`+ {`
	`11`	`+ System.Net.ServicePointManager.SecurityProtocol = System.Net.SecurityProtocolType.Tls12;`
	`12`	`+ }`
	`13`	`+`
`9`	`14`	`private IXeroCoreApi _api;`
`10`	`15`
`11`	`16`	`protected Account BankAccount { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ private XeroHttpClient(IJsonObjectMapper jsonMapper, IXmlObjectMapper xmlMapper)`
`24`	`24`	`{`
`25`	`25`	`JsonMapper = jsonMapper;`
`26`	`26`	`XmlMapper = xmlMapper;`
	`27`	`+ Parameters = new NameValueCollection();`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`public XeroHttpClient(string baseUri, IAuthenticator auth, IConsumer consumer, IUser user,`