Skip to content

Commit 3c96659

Browse files
amarantha-ktequdev
andauthored
Apply suggestions from code review
Incorporating suggestions from tequdev and akulkarni Co-authored-by: tequ <git@tequ.dev>
1 parent 65d5f2d commit 3c96659

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

docs/references/protocol/transactions/types/mptokenauthorize.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ This transaction enables an account to hold an amount of a particular MPT issuan
1515

1616
If the issuer has set `lsfMPTRequireAuth` (allow-listing) on the `MPTokenIssuance`, the issuer must submit an `MPTokenAuthorize` transaction as well in order to give permission to the holder. If `lsfMPTRequireAuth` is not set and the issuer attempts to submit this transaction, it will fail.
1717

18-
## MPTokenAuthorize Fields
18+
<!-- ## MPTokenAuthorize Fields -->
1919

2020
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}
2121

docs/references/protocol/transactions/types/mptokenissuancecreate.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ labels:
1111

1212
_(Requires the [MPToken amendment][] {% not-enabled /%})_
1313

14-
The `MPTokenIssuanceCreate` transaction creates an MPTokenIssuance <!--[MPTokenIssuance](mptokenissuance.html)--> object and adds it to the relevant directory node of the creator account. This transaction is the only opportunity an issuer has to specify any token fields that are defined as immutable (for example, MPT Flags).
14+
The `MPTokenIssuanceCreate` transaction creates an [MPTokenIssuance](../../data-types/mptokenissuance.md) object and adds it to the relevant directory node of the creator account. This transaction is the only opportunity an issuer has to specify any token fields that are defined as immutable (for example, MPT Flags).
1515

1616
If the transaction is successful, the newly created token is owned by the account (the creator account) that executed the transaction.
1717

@@ -22,22 +22,21 @@ Whenever your query returns an `MPTokenIssuance` transaction response, there wil
2222
This example assumes that the issuer of the token is the signer of the transaction.
2323

2424
```json
25-
Example MPTokenIssuanceCreate transaction
2625
{
2726
"TransactionType": "MPTokenIssuanceCreate",
2827
"Account": "rajgkBmMxmz161r8bWYH7CQAFZP5bA9oSG",
29-
"AssetScale": "2",
28+
"AssetScale": 2,
3029
"TransferFee": 314,
3130
"MaximumAmount": "50000000",
3231
"Flags": 83659,
3332
"MPTokenMetadata": "FOO",
34-
"Fee": 10
33+
"Fee": "10"
3534
}
3635
```
3736

38-
## MPTokenIssuanceCreate Fields
37+
<!-- ## MPTokenIssuanceCreate Fields -->
3938

40-
<!-- {% include '_snippets/tx-fields-intro.md' %} -->
39+
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}
4140

4241
| Field | JSON Type | [Internal Type][] | Description |
4342
|:----------------|:--------------------|:------------------|:-------------------|
@@ -50,7 +49,7 @@ Example MPTokenIssuanceCreate transaction
5049

5150
## MPTokenIssuanceCreate Flags
5251

53-
Transactions of the MPTokenIssuanceCreate type support additional values in the `Flags` field <!-- [`Flags` field](transaction-common-fields.html#flags-field)-->, as follows:
52+
Transactions of the MPTokenIssuanceCreate type support additional values in the [`Flags` field](../common-fields.md#flags-field), as follows:
5453

5554
| Flag Name | Hex Value | Decimal Value | Description |
5655
|:-------------------|:-------------|:--------------|:------------------------------|

docs/references/protocol/transactions/types/mptokenissuancedestroy.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ labels:
66
- Multi-purpose Tokens, MPTs
77
---
88
# MPTokenIssuanceDestroy
9+
[[Source]](https://github.com/XRPLF/rippled/blob/master/src/xrpld/app/tx/detail/MPTokenIssuanceDestroy.cpp "Source")
910

1011
_(Requires the [MPToken amendment][] {% not-enabled /%})_
1112

@@ -18,14 +19,14 @@ If this operation succeeds, the corresponding `MPTokenIssuance` is removed and t
1819
```json
1920
{
2021
"TransactionType": "MPTokenIssuanceDestroy",
21-
"Fee": 10,
22+
"Fee": "10",
2223
"MPTokenIssuanceID": "00070C4495F14B0E44F78A264E41713C64B5F89242540EE255534400000000000000"
2324
}
2425
```
2526

26-
## MPTokenIssuanceDestroy Fields
27+
<!-- ## MPTokenIssuanceDestroy Fields -->
2728

28-
<!-- {% include '_snippets/tx-fields-intro.md' %} -->
29+
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}
2930

3031
| Field | JSON Type | [Internal Type][] | Description |
3132
|:--------------------|:--------------------|:------------------|:-------------------|

docs/references/protocol/transactions/types/mptokenissuanceset.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ labels:
66
- Multi-purpose Tokens, MPTs
77
---
88
# MPTokenIssuanceSet
9+
[[Source]](https://github.com/XRPLF/rippled/blob/master/src/xrpld/app/tx/detail/MPTokenIssuanceSet.cpp "Source")
910

1011
_(Requires the [MPToken amendment][] {% not-enabled /%})_
1112

@@ -16,13 +17,13 @@ Use this transaction to update a mutable property for a Multi-purpose Token.
1617
```json
1718
{
1819
"TransactionType": "MPTokenIssuanceSet",
19-
"Fee": 10,
20+
"Fee": "10",
2021
"MPTokenIssuanceID": "00070C4495F14B0E44F78A264E41713C64B5F89242540EE255534400000000000000",
2122
"Flags": 1
2223
}
2324
```
2425

25-
## MPTokenIssuanceSet Fields
26+
<!-- ## MPTokenIssuanceSet Fields -->
2627

2728
{% raw-partial file="/docs/_snippets/tx-fields-intro.md" /%}
2829

0 commit comments

Comments
 (0)