Merge pull request #84 from lucasnetau/master

Remove event listeners on pool/worker termination to remove circular references to callbacks

Author: WyriHaximus

benchmark/memory.php

@@ -37,6 +37,7 @@ function show_memory($message = '')
     $timer = $loop->addPeriodicTimer(0.0001, function () use (&$i, $messenger, &$timer, $loop) {
         if ($i >= I) {
             $loop->cancelTimer($timer);
+            $timer = null;
             $messenger->terminate();
 
             show_memory('Completed messaging');
@@ -61,6 +62,6 @@ function show_memory($message = '')
 
 show_memory('Removed loop');
 
-gc_collect_cycles();
+$cycles = gc_collect_cycles();
 
-show_memory('gc_collect_cycles');
+show_memory('gc_collect_cycles: ' . $cycles);

src/Pool/Fixed.php

@@ -119,6 +119,7 @@ public function terminate(Message $message = null, $timeout = 5, $signal = null)
         }
 
         return \WyriHaximus\React\timedPromise($this->loop, $timeout)->then(function () {
+            $this->manager->removeAllListeners();
             return $this->manager->terminate();
         });
     }

src/Pool/Flexible.php

@@ -149,6 +149,7 @@ public function terminate(Message $message = null, $timeout = 5, $signal = null)
         }
 
         return \WyriHaximus\React\timedPromise($this->loop, $timeout)->then(function () {
+            $this->manager->removeAllListeners();
             return $this->manager->terminate();
         });
     }

src/Worker.php

@@ -72,6 +72,7 @@ public function terminate()
     {
         $this->busy = true;
         $this->emit('terminating', [$this]);
+        $this->messenger->removeAllListeners();
         return $this->messenger->softTerminate();
     }
 }