Issues Discovered While Setting Up Development Environment to Apply Noto Sans/Serif Korean on ko.wordpress.org #690
Replies: 7 comments 5 replies
-
I've converted this to a discussion so we can have a threaded conversation. If there are specific issues that are identified, those can be made in the relevant repos. I'll be replying to the rest of this shortly 🙂 |
Beta Was this translation helpful? Give feedback.
-
I think WordPress shows this error when the blocks aren't built, too. Can you confirm that you ran the build steps for each project? For example, I think you have all three projects adjacent to one another, so you would need to run:
Generally you'll want to re-run those for the project you're testing whenever you switch branches. |
Beta Was this translation helpful? Give feedback.
-
This is related to the |
Beta Was this translation helpful? Give feedback.
-
It's generally useful to run Note that the wp-env should be stopped when running |
Beta Was this translation helpful? Give feedback.
-
You should also be testing with this PR on wporg-main-2022: WordPress/wporg-main-2022#560. Looking through your log file, I see that you edited composer.json — that shouldn't be necessary. Creating the I recommend thinking about {
"config": {
"WP_DEVELOPMENT_MODE": "all"
},
"themes": [
"./source/wp-content/themes/wporg",
"./source/wp-content/themes/wporg-main",
"./source/wp-content/themes/wporg-main-2022",
"../wporg-parent-2021/source/wp-content/themes/wporg-parent-2021"
],
"mappings": {
"wp-content/mu-plugins/wporg-mu-plugins": "../wporg-mu-plugins",
"wp-content/languages": "./source/wp-content/languages"
}
} If you want to test other sites, you can use the same process, for example in the Pattern Directory. |
Beta Was this translation helpful? Give feedback.
-
I haven't seen this, can you share which language & project you're testing on? |
Beta Was this translation helpful? Give feedback.
-
Hey @ryelle, I applied the changes exactly as you suggested, and I can confirm everything is now displaying perfectly without any errors. I’m guessing the issue with Since I already have Noto Sans and Noto Serif installed as system fonts, I didn’t notice any major visual differences — though it seems like there’s a slight difference in letter spacing. I also had a personal question: it seems like the 2022 theme applies FSE styles cleanly, and I was wondering if, rather than dealing with everything through the GitHub code, it might be quicker and easier in some cases to just add custom fonts directly via theme style customizations. I tried adding a font through the theme’s I noticed in the mu-plugins GitHub description it says: “Development of the Global Header and other mu-plugins used on WordPress.org”. Does this mean that font handling for the Global Header is implemented differently from theme-based font management, and requires a separate approach? Anyway — thank you so much for your help getting Noto Serif working! Now I’m going to move on to applying Noto Sans for the main body text, and once I figure out how to set Noto for the global header as well, it should be perfect. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Background
To improve typographic consistency and readability on the Korean WordPress.org (ko.wordpress.org) site, there was an initiative to apply Noto Sans/Serif Korean fonts (Noto Sans KR, Noto Serif KR). These fonts are designed for optimal CJK (Chinese, Japanese, Korean) support, unlike the default global fonts (EB Garamond, Inter) that primarily target Latin scripts and lack comprehensive CJK glyph coverage[2].
Technical Challenges in Development Environment
wp-env
) led to dependency conflicts, mapping issues, and confusion about which code was active in each environment.Issues to Report and Suggested Channels
Based on the analysis of your logs, here are the main issues and where you might report them:
1. Issue: Persistent PHP Notices Regarding Gutenberg Block Registration (Namespace Missing)
WP_Block_Type_Registry::register
was called incorrectly are consistently appearing in environments using themes likewporg-main-2022
,wporg-parent-2021
, andwporg-mu-plugins
.my-plugin/my-custom-block-type
"wp_json_file_decode()
(file does not exist) notices andfilemtime()
(CSS file stat failed) warnings.wp-env
.WordPress/wporg-main-2022
,WordPress/wporg-parent-2021
(especially when testingadd/korean-font
branches).WordPress/wporg-mu-plugins
(especiallyadd/korean-font
orbuild
branches).register_block_type()
without a namespace.WordPress/wporg-main-2022
(if observed when this theme is active)WordPress/wporg-parent-2021
(if observed when this theme is active)WordPress/wporg-mu-plugins
(if the problematic blocks originate here)#core-dev
or#meta
to determine the most appropriate repository or if it's a known issue.2. Issue: PHP Warnings in
wporg-mu-plugins
related toglobal-fonts
$font_folder
,$font_file_name
) inwporg-mu-plugins/mu-plugins/global-fonts/index.php
.cjk.woff2
does not exist" also appears.WordPress/wporg-mu-plugins
(e.g.,build
branch as per logs, or potentiallyadd/korean-font
due to font file path issues).WordPress/wporg-mu-plugins
#meta
channel (as it relates to font handling on WordPress.org sites).3. Issue: Docker Compose
version
Attribute Warning with@wordpress/env
yarn wp-env start
oryarn setup:wp
(which useswp-env
internally), Docker issues a warning that theversion
attribute in thedocker-compose.yml
file generated bywp-env
is obsolete.the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion
wp-env
.docker-compose.yml
template generated by the@wordpress/env
package still includes the outdatedversion
attribute.WordPress/gutenberg
(as the@wordpress/env
package is managed there).#core-editor
or#core-dev
channel.4. (Optional) Observation: Jetpack Translation Loading Timing Notice (Resolved but for reference)
_load_textdomain_just_in_time was called incorrectly. Translation loading for the jetpack domain was triggered too early.
#polyglots
or#core-dev
channel to highlight the usefulness of this new WordPress 6.7.0 notice for developers and remind plugin authors to be mindful of translation loading hooks.5. (Information Sharing) Experience Testing Korean Font Implementation for
wporg-main-2022
andwporg-parent-2021
add/korean-font
branches ofwporg-main-2022
,wporg-parent-2021
, andwporg-mu-plugins
..wp-env.override.json
for mapping multiple themes and MU plugins, and configuring a Korean language environment through i18n settings.#meta
channel (for WordPress.org site design and functionality) or#polyglots
(for Korean user experience).add/korean-font
branches are associated with specific Pull Requests (PRs) (e.g.,https://github.com/WordPress/wporg-parent-2021/pull/174
,https://github.com/WordPress/wporg-mu-plugins/pull/685
from your first log file), commenting on those PRs with your test feedback and identified issues would be most direct and valuable.explain.txt
로그 분석.txt
WordPress/wporg-parent-2021#175
@ryelle
Beta Was this translation helpful? Give feedback.
All reactions