Update some tests to have more whitespaces, comments and annotations

Author: rodrigoprimo

WordPress/Tests/WP/OptionAutoloadUnitTest.inc

@@ -19,8 +19,13 @@ $ok = ADD_OPTION( 'my_option', new stdClass(), '', null );
 $ok = add_option( 'my_option', autoload: FALSE, value: 'my_value' );
 $ok = add_option( 'my_option', autoload: false );
 $ok = add_option( autoload: false, deprecated: '', value: 'my_value', option: 'my_option' );
-$ok = \update_option( 'my_option', 'new_value', \true );
-$ok = update_option( 'my_option', 'new_value', \false );
+$ok = \update_option(    'my_option'    ,    'new_value'    ,    \true    );
+$ok = update_option(
+    'my_option',
+    'new_value',
+    // phpcs:ignore Standard.Category.Sniff -- For test reasons.
+    /* comment */ \false /* comment */
+);
 $ok = Update_Option( 'my_option', 'new_value', \NULL );
 $ok = update_option( 'my_option', autoload: TrUe, value: 'new_value' );
 $ok = update_option( autoload: false, value: 'my_value', option: 'my_option' );
@@ -53,7 +58,12 @@ $ignored = ADD_OPTION( 'my_option', 'my_value', '', $obj->yes );
 $ignored = add_option( 'my_option', 'my_value', '', $some_variable ? 'yes' : 'no' );
 $ignored = Add_Option( 'my_option', 'my_value', '', 'ye' . 's' );
 $ignored = add_option( 'my_option', 'my_value', '', (function () { return 'yes'; })() );
-$ignored = add_option( 'my_option', 'new_value', '', yes);
+$ignored = add_option(
+    'my_option',
+    'new_value',
+    '',
+    /* comment */ yes /* comment */
+);
 $ignored = wp_set_options_autoload( array( 'option1', 'option2' ), $some_variable );
 $ignored = wp_set_OPTION_autoload( 'option1', $some_variable );
 $ignored = wp_set_option_autoload_values(
@@ -85,7 +95,7 @@ $ignored = wp_set_option_autoload_values(options: []);
  * Invalid function calls that are ignored by the sniff as a mandatory parameter is missing.
  */
 $ignored = wp_set_option_autoload_values();
-$ignored = wp_set_options_autoload();
+$ignored = wp_set_options_autoload( /* some comment */ );
 $ignored = wp_set_options_autoload( array( 'option1', 'option2' ) );
 $ignored = wp_set_option_autoload();
 $ignored = wp_set_option_autoload( 'option1' );
@@ -108,7 +118,7 @@ $warning = add_option( 'my_option', 'my_value', '', 'invalid_value' );
 $warning = add_option( 'my_option', 'my_value', '', 'true' );
 $warning = add_option( 'my_option', 'my_value', '', "false" );
 $warning = add_option( 'my_option', 'my_value', '', array('some', 'array') );
-$warning = add_option( 'my_option', 'my_value', '', ['some', 'array'] );
+$warning = /* comment */ add_option /* comment */ ( 'my_option', 'my_value', '', ['some', 'array'] );
 $warning = add_option( option: 'my_option' );
 $warning = add_option( value: 'my_value', option: 'my_option' );
 $warning = add_option( value: 'my_value', deprecated: '', option: 'my_option' );
@@ -117,7 +127,11 @@ $warning = add_option( 'my_option', 'my_value', '', 'YES' ); // the uppercase ve
 $warning = update_option( 'my_option', 'new_value' );
 $warning = update_option( 'my_option', 'new_value', 'auto' );
 $warning = update_option( 'my_option', 'new_value', 'auto-on' );
-$warning = update_option( 'my_option', 'new_value', 'auto-off' );
+$warning = update_option(
+    /* option name */ 'my_option',
+    'new_value' /* option value */,
+    /* autoload value */ 'auto-off' // phpcs:ignore Standard.Category.Sniff -- For test reasons.
+);
 $warning = update_option( 'my_option', 'new_value', 'invalid_value' );
 $warning = update_option( value: 'new_value', option: 'my_option' );
 $warning = update_option( value: 'new_value', autoload: 'auto', option: 'my_option' );
@@ -128,6 +142,7 @@ $warning = wp_set_option_autoload( 'option1', 'invalid_value' );
 $warning = wp_set_option_autoload( 'option1', \NuLL );
 $warning = wp_set_option_autoload_values( ['option1' => null] );
 $warning = wp_set_option_autoload_values(
+    // phpcs:ignore Standard.Category.Sniff -- For test reasons.
     [
         'option1' => '',
         'option2' => 'true',
@@ -137,7 +152,7 @@ $warning = wp_set_option_autoload_values(
         'option6' => 'YES',
         'option7' => 'invalid_value',
         'option8' => 'auto',
-        'option9' => 'auto-on',
+        'option9' /* some comment */ => /* some comment */ 'auto-on',
         'option10' => 'auto-off',
         'option11',
         /* some comment */ 'option12' /* some comment */,

WordPress/Tests/WP/OptionAutoloadUnitTest.inc.fixed

@@ -19,8 +19,13 @@ $ok = ADD_OPTION( 'my_option', new stdClass(), '', null );
 $ok = add_option( 'my_option', autoload: FALSE, value: 'my_value' );
 $ok = add_option( 'my_option', autoload: false );
 $ok = add_option( autoload: false, deprecated: '', value: 'my_value', option: 'my_option' );
-$ok = \update_option( 'my_option', 'new_value', \true );
-$ok = update_option( 'my_option', 'new_value', \false );
+$ok = \update_option(    'my_option'    ,    'new_value'    ,    \true    );
+$ok = update_option(
+    'my_option',
+    'new_value',
+    // phpcs:ignore Standard.Category.Sniff -- For test reasons.
+    /* comment */ \false /* comment */
+);
 $ok = Update_Option( 'my_option', 'new_value', \NULL );
 $ok = update_option( 'my_option', autoload: TrUe, value: 'new_value' );
 $ok = update_option( autoload: false, value: 'my_value', option: 'my_option' );
@@ -53,7 +58,12 @@ $ignored = ADD_OPTION( 'my_option', 'my_value', '', $obj->yes );
 $ignored = add_option( 'my_option', 'my_value', '', $some_variable ? 'yes' : 'no' );
 $ignored = Add_Option( 'my_option', 'my_value', '', 'ye' . 's' );
 $ignored = add_option( 'my_option', 'my_value', '', (function () { return 'yes'; })() );
-$ignored = add_option( 'my_option', 'new_value', '', yes);
+$ignored = add_option(
+    'my_option',
+    'new_value',
+    '',
+    /* comment */ yes /* comment */
+);
 $ignored = wp_set_options_autoload( array( 'option1', 'option2' ), $some_variable );
 $ignored = wp_set_OPTION_autoload( 'option1', $some_variable );
 $ignored = wp_set_option_autoload_values(
@@ -85,7 +95,7 @@ $ignored = wp_set_option_autoload_values(options: []);
  * Invalid function calls that are ignored by the sniff as a mandatory parameter is missing.
  */
 $ignored = wp_set_option_autoload_values();
-$ignored = wp_set_options_autoload();
+$ignored = wp_set_options_autoload( /* some comment */ );
 $ignored = wp_set_options_autoload( array( 'option1', 'option2' ) );
 $ignored = wp_set_option_autoload();
 $ignored = wp_set_option_autoload( 'option1' );
@@ -108,7 +118,7 @@ $warning = add_option( 'my_option', 'my_value', '', 'invalid_value' );
 $warning = add_option( 'my_option', 'my_value', '', 'true' );
 $warning = add_option( 'my_option', 'my_value', '', "false" );
 $warning = add_option( 'my_option', 'my_value', '', array('some', 'array') );
-$warning = add_option( 'my_option', 'my_value', '', ['some', 'array'] );
+$warning = /* comment */ add_option /* comment */ ( 'my_option', 'my_value', '', ['some', 'array'] );
 $warning = add_option( option: 'my_option' );
 $warning = add_option( value: 'my_value', option: 'my_option' );
 $warning = add_option( value: 'my_value', deprecated: '', option: 'my_option' );
@@ -117,7 +127,11 @@ $warning = add_option( 'my_option', 'my_value', '', 'YES' ); // the uppercase ve
 $warning = update_option( 'my_option', 'new_value' );
 $warning = update_option( 'my_option', 'new_value', 'auto' );
 $warning = update_option( 'my_option', 'new_value', 'auto-on' );
-$warning = update_option( 'my_option', 'new_value', 'auto-off' );
+$warning = update_option(
+    /* option name */ 'my_option',
+    'new_value' /* option value */,
+    /* autoload value */ 'auto-off' // phpcs:ignore Standard.Category.Sniff -- For test reasons.
+);
 $warning = update_option( 'my_option', 'new_value', 'invalid_value' );
 $warning = update_option( value: 'new_value', option: 'my_option' );
 $warning = update_option( value: 'new_value', autoload: 'auto', option: 'my_option' );
@@ -128,6 +142,7 @@ $warning = wp_set_option_autoload( 'option1', 'invalid_value' );
 $warning = wp_set_option_autoload( 'option1', \NuLL );
 $warning = wp_set_option_autoload_values( ['option1' => null] );
 $warning = wp_set_option_autoload_values(
+    // phpcs:ignore Standard.Category.Sniff -- For test reasons.
     [
         'option1' => '',
         'option2' => 'true',
@@ -137,7 +152,7 @@ $warning = wp_set_option_autoload_values(
         'option6' => 'YES',
         'option7' => 'invalid_value',
         'option8' => 'auto',
-        'option9' => 'auto-on',
+        'option9' /* some comment */ => /* some comment */ 'auto-on',
         'option10' => 'auto-off',
         'option11',
         /* some comment */ 'option12' /* some comment */,

WordPress/Tests/WP/OptionAutoloadUnitTest.php

@@ -36,22 +36,12 @@ public function getErrorList() {
 	 */
 	public function getWarningList() {
 		return array(
-			96  => 1,
-			97  => 1,
-			98  => 1,
-			99  => 1,
-			100 => 1,
-			105 => 1,
+			106 => 1,
 			107 => 1,
 			108 => 1,
 			109 => 1,
 			110 => 1,
-			111 => 1,
-			112 => 1,
-			113 => 1,
-			114 => 1,
 			115 => 1,
-			116 => 1,
 			117 => 1,
 			118 => 1,
 			119 => 1,
@@ -65,9 +55,7 @@ public function getWarningList() {
 			127 => 1,
 			128 => 1,
 			129 => 1,
-			132 => 1,
 			133 => 1,
-			134 => 1,
 			135 => 1,
 			136 => 1,
 			137 => 1,
@@ -77,40 +65,52 @@ public function getWarningList() {
 			141 => 1,
 			142 => 1,
 			143 => 1,
+			147 => 1,
 			148 => 1,
 			149 => 1,
 			150 => 1,
 			151 => 1,
 			152 => 1,
 			153 => 1,
+			154 => 1,
+			155 => 1,
+			156 => 1,
+			157 => 1,
 			158 => 1,
-			159 => 1,
-			160 => 1,
-			161 => 1,
-			162 => 1,
 			163 => 1,
 			164 => 1,
-			170 => 1,
+			165 => 1,
+			166 => 1,
+			167 => 1,
+			168 => 1,
+			173 => 1,
+			174 => 1,
+			175 => 1,
+			176 => 1,
 			177 => 1,
+			178 => 1,
 			179 => 1,
-			180 => 1,
-			181 => 1,
-			182 => 1,
-			183 => 1,
-			184 => 1,
 			185 => 1,
-			187 => 1,
-			188 => 1,
-			189 => 1,
-			190 => 1,
-			193 => 1,
+			192 => 1,
 			194 => 1,
 			195 => 1,
 			196 => 1,
-			201 => 1,
-			207 => 1,
+			197 => 1,
+			198 => 1,
+			199 => 1,
+			200 => 1,
+			202 => 1,
+			203 => 1,
+			204 => 1,
+			205 => 1,
+			208 => 1,
 			209 => 1,
-			212 => 1,
+			210 => 1,
+			211 => 1,
+			216 => 1,
+			222 => 1,
+			224 => 1,
+			227 => 1,
 		);
 	}
 }