Suggestion: Provide updated version of msls31

[eskay993]

Hi

I've come across a bug caused by the version of msls31 that winetricks installs with the following perfect storm:

• Windows app targeting .NET 4.7.2 (other versions may be affected as well)
• Embedded Rich Text within the app that needs winetricks msftedit to use all features, like rendering images etc.
• Certain Unicode characters in the rich text, e.g. Malaysian characters.

In order to render the unicode characters, msls31 is needed, but the one winetricks grabs is the older Windows XP one from what I gather. This cause the app to crash with:

wine: Unimplemented function msls31.dll.LssbFDonePresSubline called at address 00006FFFFF3DD127 (thread 0024), starting debugger...

Same occurs with both mono and with dotnet472.

As a test, replacing msls31 with a newer version from a Windows 11 install fixes the issue. No crash and everything renders correctly.

The version of the dll that ships with IE8 works as well, and I believe this is latest version of the dll before it was deprecated. Running winetricks ie8 does fix the problem, but seems overkill to do this when all that is needed is msls31.dll

Would you consider updating the msls21 call to use a new version of the dll from the IE8 package? I've tested this with a custom verb that basically just strips down the ie8 call to just install the dll and it works great.

Or potentially offer this an a new verb alongside the old msls31 in case it breaks anything.

I can submit a pull request with what I've done? I am but a mere casual coder, but the hard work was done already with the ie8 verb, so stripping it down should be easy enough (famous last words!)

[eskay993]

Update:

I did some further digging and discovered the actual issue.

winetricks msls31 only installs the 32-bit version of the dll in syswow64 on a 64-bit prefix. So it's missing the 64-bit version, which is not checked for in the call function, and is not included in the exe it downloads (InstMsiW.exe) since this is an XP installer.

The ie8 call function installs both the 32-bit and 64-bit dlls from the IE8 installer which is why is fixes the issue. But installing IE8 in full is not the best solution as it can cause others issues since it modifies lots of things, doesn't fix it when using protontricks, and the ieX verbs are not available in GE-Proton's winetricks AFAIK.

Just installing both 32 and 64-bit versions of the dll though does work across the board.

I'd be happy to submit a PR for updating the msls31 call, or creating a new verb, something like msls31_x64, if you'd be up for it.