Merge pull request #586 from WildernessLabs/bugfix/rgbpwmled-fix

adrianstevens · web-flow · commit bea69348f16d · 2023-03-31T08:41:36.000-07:00
RgbPwmLed PulseDuration fix
diff --git a/Source/Meadow.Foundation.Core/Leds/RgbPwmLed.cs b/Source/Meadow.Foundation.Core/Leds/RgbPwmLed.cs
@@ -412,8 +412,6 @@ public void StartPulse(Color color, float highBrightness = 1, float lowBrightnes
         /// <param name="lowBrightness"></param>
         public void StartPulse(Color color, TimeSpan pulseDuration, float highBrightness = 1, float lowBrightness = 0.15F)
         {
-            pulseDuration = TimeSpan.FromMilliseconds(600);
-
             if (highBrightness > 1 || highBrightness <= 0)
             {
                 throw new ArgumentOutOfRangeException(nameof(highBrightness), "onBrightness must be > 0 and <= 1");

Original file line number	Diff line number	Diff line change
`@@ -412,8 +412,6 @@ public void StartPulse(Color color, float highBrightness = 1, float lowBrightnes`
`412`	`412`	`/// <param name="lowBrightness"></param>`
`413`	`413`	`public void StartPulse(Color color, TimeSpan pulseDuration, float highBrightness = 1, float lowBrightness = 0.15F)`
`414`	`414`	`{`
`415`		`- pulseDuration = TimeSpan.FromMilliseconds(600);`
`416`		`-`
`417`	`415`	`if (highBrightness > 1 \|\| highBrightness <= 0)`
`418`	`416`	`{`
`419`	`417`	`throw new ArgumentOutOfRangeException(nameof(highBrightness), "onBrightness must be > 0 and <= 1");`