GMC-320S get_version() does not work

[ffries]

Dear all,

First I would like to thank you all for working on pygmc.
I can report that GMC-320S partially works.

get_cpm() and get_usv_h work but not get_version().

import pygmc

gc = pygmc.connect()
ver = gc.get_version()
print(ver)

cpm = gc.get_cpm()
print(cpm)

usvh = gc.get_usv_h()
print(usvh)

Returns:

16
0.10403120936280884

Kind regards,
FFries

[ffries]

I could read <getver>> using another library, it is GMC-320SRe 1.15

[ffries]

Documentation says that GMC-320S is an enhanced GMC-320+.
https://gq-llc.myshopify.com/products/gmc-320s-digital-nuclear-radiation-detector

[ffries]

I don't know how to make a PR so I post it here:

    {
        "match_regex": r"GMC-320S",
        "device_class": GMC320S,
        "protocol_class": DeviceRFC1201,
        "version_example": "GMC-320SRe 1.15",
    },

class GMC320S(DeviceRFC1201):
    """GMC-320S"""

    def __init__(
        self,
        port,
        baudrate=115200,
        timeout=5,
        connection=None,
    ):
        """
        Represent a GMC-320S device.

        Parameters
        ----------
        port: None | str
            Exact port (device dev path / com port) e.g. '/dev/ttyUSB0'
            If None, a Connection object is required.
        baudrate: int
            Device baudrate. Default value is the best-known value for the device.
        timeout: int
            Time limit for pyserial to raise timeout.
        connection : pygmc.Connection
            An initialized pygmc connection interface to the USB device.
            Overrides port & baudrate.
        """
        if isinstance(connection, Connection):
            super().__init__(connection)
        elif port and isinstance(baudrate, int):
            conn = Connection(port=port, baudrate=baudrate, timeout=timeout)
            super().__init__(conn)
        else:
            raise ConnectionError(f"Unable to connect port={port} baudrate={baudrate}")

[ffries]

I can see the value of get_version() in the Python debugger, but not when I run the script with python3 command directly, so I don't understand the problem with get_version(). Maybe it is a problem on my side. I am only using pygmc from git and don't use any pip version.

[ffries]

Surprisingly

import pygmc

gc = pygmc.connect()

ver = gc.get_version()
print(ver)

ver = gc.get_version()
print(ver)

cpm = gc.get_cpm()
print(cpm)

usvh = gc.get_usv_h()
print(usvh)

returns (first line blank):

GMC-320SRe 1.15
16
0.10403120936280884

I don't have brctl installed.

[Wikilicious]

Hi @ffries,
Thanks for your report!
I own a GMC-600+, GMC-500+, GMC-320+, GMC-300S, and GMC-800... and can relate to your issue of empty get_version() as you mentioned here #129 (comment)

I only get the issue while using a Ubuntu VM running on Windows via VMware.
Can you share more specifics?

The line above gc = pygmc.connect() internally does a gc.get_version() to map to correct Python class.

Every time I've tried to root-cause... My VMware/USB seemed to be the issue.

Can you try a silly/simple thing? A different USB cable.

[Wikilicious]

I realized I had incorrect information in the README. I listed GMC320S as supported, which I didn't have until you made a PR.