Skip to content

Commit b9e80aa

Browse files
larsclausengregkh
authored andcommitted
hwmon: (adm1266) Set can_sleep flag for GPIO chip
[ Upstream commit a5bb73b ] The adm1266 driver uses I2C bus access in its GPIO chip `set` and `get` implementation. This means these functions can sleep and the GPIO chip should set the `can_sleep` property to true. This will ensure that a warning is printed when trying to set or get the GPIO value from a context that potentially can't sleep. Fixes: d98dfad ("hwmon: (pmbus/adm1266) Add support for GPIOs") Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Link: https://lore.kernel.org/r/20230314093146.2443845-1-lars@metafoo.de Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 8a3876f commit b9e80aa

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/hwmon/pmbus/adm1266.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ static int adm1266_config_gpio(struct adm1266_data *data)
301301
data->gc.label = name;
302302
data->gc.parent = &data->client->dev;
303303
data->gc.owner = THIS_MODULE;
304+
data->gc.can_sleep = true;
304305
data->gc.base = -1;
305306
data->gc.names = data->gpio_names;
306307
data->gc.ngpio = ARRAY_SIZE(data->gpio_names);

0 commit comments

Comments
 (0)