Skip to content

Commit 366082d

Browse files
ruby : refine HTTP cache feature (ggml-org#3109)
* Use cache file when model host doesn't support if-modified-since * Update gem date * Revert "ruby : ignore "Downloading" output in test_log_suppress (ggml-org#3106)" This reverts commit edbd4cb.
1 parent 0778b6f commit 366082d

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

bindings/ruby/lib/whisper/model/uri.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ def request(uri, headers)
5555
when Net::HTTPNotModified
5656
# noop
5757
when Net::HTTPOK
58+
return if !response.key?("last-modified") && cache_path.exist?
59+
5860
download response
5961
when Net::HTTPRedirection
6062
request URI(response["location"]), headers

bindings/ruby/tests/test_whisper.rb

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -118,18 +118,7 @@ def test_log_suppress
118118
dev = StringIO.new("")
119119
$stderr = dev
120120
Whisper::Context.new("base.en")
121-
122-
# Filter out any lines starting with "Downloading" or containing only dots.
123-
# The reason for this is that I think the recent migration to Huggingface
124-
# Xet might have changed the downloading behavior. There is now a redirect
125-
# to a different URL, which causes the download to be retried even if the
126-
# file is already downloaded.
127-
# TODO(danbev) Remove this when a proper fix is in place.
128-
filtered_output = dev.string.lines.reject do |line|
129-
line.start_with?("Downloading") || line.strip =~ /^\.+$/
130-
end.join
131-
132-
assert_empty filtered_output, "Expected no output, but got: #{filtered_output.inspect}"
121+
assert_empty dev.string
133122
ensure
134123
$stderr = stderr
135124
end

bindings/ruby/whispercpp.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Gem::Specification.new do |s|
44
s.name = "whispercpp"
55
s.authors = ["Georgi Gerganov", "Todd A. Fisher"]
66
s.version = '1.3.2'
7-
s.date = '2025-04-25'
7+
s.date = '2025-05-01'
88
s.description = %q{High-performance inference of OpenAI's Whisper automatic speech recognition (ASR) model via Ruby}
99
s.email = 'todd.fisher@gmail.com'
1010
s.extra_rdoc_files = ['LICENSE', 'README.md']

0 commit comments

Comments
 (0)