Settings pushing: merge, don't blanket override

[tw2113]

I want to make it so any time someone clicks any of the "Push settings" buttons for any of the indexes, the settings are merged and pushed instead of outright overriding everything.

I am not convinced that it is known that the buttons override values manually set via the Algolia Dashboard with whatever defaults are set via the plugin. I am also certain that there are potential cases of teams mixing the two together, and that's a recipe for disaster.

So if at all possible we should fetch a given index's settings and do the necessary logic to determine which setting fields are not the default values within a fresh index, and merge those in to the local, to-be-pushed, settings values that are default.

Questions needing answered before we can start anything here, is how to handle situations where both remote AND local settings are not defaults, which value "wins" ? Perhaps retain current situation and let the local version override? Log the situation and inform the site owner? Prevent the submission of the settings push until they have made a decision and removed the conflict?

[tw2113]

This needs to be done in the extended get_settings() methods for each class that extends Algolia_Index which are listed in the indices folder.

The question is how to best fetch the settings. Need to get instance of SearchIndex with the appropriate index name and make use of getSettings() method.

[tomreed-ae]

Hi @tw2113, is there a filter to prevent the "Push Settings" button from doing anything?

Once we have pushed the settings from the codebase, we are now managing the config options from the Algolia dashboard due to the issues you raised above. Can we easily prevent the button from overriding what is in the dashboard?

[tw2113]

@tomreed-ae No on a filter, but you could use some quick CSS to visually hide at least in the meantime:

add_action('admin_head',function(){
?>
<style>
	.algolia-push-settings-button.button {
		display: none;
	}
</style>
<?php
});