Skip to content

Feature/con 480 custom fields #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: release2150
Choose a base branch
from
Open

Feature/con 480 custom fields #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7809af1
update our custom fields api methods to take a customizable limit
tw2113 Nov 10, 2025
be7ceea
list out available custom fields from given users account
tw2113 Nov 10, 2025
45ded75
make sure we have data to work with before outputting anything
tw2113 Nov 10, 2025
5062e18
only attempt any fetching if connected
tw2113 Nov 10, 2025
77c3da5
cap custom field labels at 50 characters. Matches CTCTs limit when cr…
tw2113 Nov 10, 2025
a6bc54a
admin builds
tw2113 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/ctct-plugin-admin.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/js/ctct-plugin-admin.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/js/ctct-plugin-admin.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 6 additions & 1 deletion assets/js/ctct-plugin-admin/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,12 @@ window.CTCTBuilder = {};
if ('custom' === map.value) {
fieldLabel.classList.add('form-field-is-custom-field');
} else {
fieldLabel.classList.remove('form-field-is-custom-field')
fieldLabel.classList.remove('form-field-is-custom-field');
}
if ('custom' === map.value || 'custom_text_area' === map.value) {
fieldLabel.setAttribute('maxlength', '50');
} else {
fieldLabel.removeAttribute('maxlength');
}
}
}
Expand Down
19 changes: 19 additions & 0 deletions includes/class-builder-fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,25 @@ public function unique_label_messaging( array $field_args, CMB2_Field $field ) {
'</a>'
)
);

if ( constant_contact()->get_api()->is_connected() ) {
$custom_fields_data = constant_contact()->get_api()->cc()->get_custom_fields();
if (
is_array( $custom_fields_data['custom_fields'] ) &&
! empty( $custom_fields_data['custom_fields'] )
) {
if ( array_key_exists( 'label', $custom_fields_data['custom_fields'][0] ) ) {
$labels = wp_list_pluck( $custom_fields_data['custom_fields'], 'label' );
sort( $labels );

printf(
'<p>%1$s<br/><strong>%2$s</strong></p>',
esc_html__( 'Available fields from your account:', 'constant-contact-forms' ),
implode( ', ', $labels )
);
}
}
}
}

/**
Expand Down
22 changes: 18 additions & 4 deletions includes/class-client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,24 @@ public function create_update_contact( array $args = [] ) {
* Get configured custom fields for contacts.
*
* @since 2.0.0
* @since NEXT Added limit parameter.
*
* @param string $limit How many custom fields to retrieve. Default 50. Max 100.
* @return array
*/
public function get_custom_fields() {
return $this->get( 'contact_custom_fields', $this->base_args );
public function get_custom_fields( $limit = '50' ) {
$endpoint = 'contact_custom_fields';

if ( ! empty( $limit ) ) {
if ( ! is_numeric( $limit ) ) {
$limit = '50'; //fallback in case non-numbers got passed in.
}
$endpoint = add_query_arg(
[ 'limit' => $limit ],
'contact_custom_fields'
);
}
return $this->get( $endpoint, $this->base_args );
}

/**
Expand All @@ -134,7 +148,7 @@ public function get_custom_field( string $field_id ) {
* @return bool
*/
public function custom_field_exists( string $field_name ) {
$fields = $this->get_custom_fields();
$fields = $this->get_custom_fields( '100' );
if ( ! empty( $fields ) && array_key_exists( 'custom_fields', $fields ) ) {
$field_keys = wp_list_pluck( $fields['custom_fields'], 'label' );
return in_array( $field_name, $field_keys, true );
Expand All @@ -151,7 +165,7 @@ public function custom_field_exists( string $field_name ) {
* @return mixed|string
*/
public function get_custom_field_by_name( string $field_name ) {
$fields = $this->get_custom_fields();
$fields = $this->get_custom_fields( '100' );
if ( ! empty( $fields ) && array_key_exists( 'custom_fields', $fields ) ) {
foreach ( $fields['custom_fields'] as $field ) {
if ( $field['label'] === $field_name ) {
Expand Down