Skip to content

Conversation

@tw2113
Copy link
Member

@tw2113 tw2113 commented Nov 5, 2025

Closes

https://app.clickup.com/t/9011385391/CON-479

What type of PR is this? (put an x to all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Link to test

Local install.

Description

If not connected to a Constant Contact account, the "Opt-in" settings tab showed nothing and appeared potentially broken in some way.

This PR adds some default messaging when not connected, and also adds in hiding of a "Save changes" button for that tab, to prevent thinking there's something to save.

Default messaging should not show at all once connected, and the button will show again.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Confluence
  • πŸ™… no documentation needed

Reviewer's Testing Checklist

As a reviewer, please ensure the following testing criteria are met and validated before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Accessibility Testing: Validate that the changes comply with accessibility standards.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint).
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Plugin Compatibility: Check if the changes are compatible with existing plugins and do not cause conflicts.
  • Core Functionality: Verify that the WordPress core functionalities are not disrupted.
  • Custom Post Types and Taxonomies: Confirm that any custom post types or taxonomies function as intended.
  • Security Best Practices: Ensure that the code follows WordPress security best practices.
  • Performance: Check for any performance issues, especially with database queries and page load times.
  • SEO Considerations: Where applicable, confirm that the changes do not negatively impact SEO elements.
  • WordPress Coding Standards: Ensure that the code adheres to WordPress coding standards.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • User Acceptance Testing (UAT): If applicable, confirm that stakeholders have reviewed and accepted the changes.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@tw2113 tw2113 requested a review from lindseywb November 5, 2025 00:11
Copy link

@lindseywb lindseywb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants