Skip to content

Commit da278f8

Browse files
tlivelyrossberg
authored andcommitted
[interpreter] Update Makefile to ignore output of cd (#1683)
The interpreter Makefile captures the output of cding into the unittest directory and listing the unittest files it contains. Under some circumstances, the `cd` command will print the new current directory, and that output was incorrectly being interpreted as the path to a unittest, causing the build to fail. Fix this problem by redirecting the output of cd, if any, to /dev/null. Fixes #1681.
1 parent be6b12a commit da278f8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

interpreter/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ $(JSLIB):
4747
# Unit tests
4848

4949
UNITTESTDIR = unittest
50-
UNITTESTFILES = $(shell cd $(UNITTESTDIR); ls *.ml)
50+
UNITTESTFILES = $(shell cd $(UNITTESTDIR) > /dev/null; ls *.ml)
5151
UNITTESTS = $(UNITTESTFILES:%.ml=%)
5252

5353
.PHONY: unittest
@@ -62,7 +62,7 @@ unittest/%:
6262
# Test suite
6363

6464
TESTDIR = ../test/core
65-
TESTFILES = $(shell cd $(TESTDIR); ls *.wast; ls [a-z]*/*.wast)
65+
TESTFILES = $(shell cd $(TESTDIR) > /dev/null; ls *.wast; ls [a-z]*/*.wast)
6666
TESTS = $(TESTFILES:%.wast=%)
6767

6868
.PHONY: test partest quiettest

0 commit comments

Comments
 (0)