Skip to content

Commit b72a1aa

Browse files
backesbackes
authored
[test] Disable tests that become valid with memory64 (#1648)
1 parent dec2738 commit b72a1aa

File tree

1 file changed

+122
-115
lines changed

1 file changed

+122
-115
lines changed

‎test/core/binary.wast

Lines changed: 122 additions & 115 deletions
Original file line numberDiff line numberDiff line change
@@ -492,25 +492,27 @@
492492
)
493493
"integer representation too long"
494494
)
495-
(assert_malformed
496-
(module binary
497-
"\00asm" "\01\00\00\00"
498-
"\01\04\01\60\00\00" ;; Type section
499-
"\03\02\01\00" ;; Function section
500-
"\05\03\01\00\01" ;; Memory section
501-
"\0a\11\01" ;; Code section
502-
;; function 0
503-
"\0f\01\01" ;; local type count
504-
"\7f" ;; i32
505-
"\41\00" ;; i32.const 0
506-
"\28" ;; i32.load
507-
"\02" ;; alignment 2
508-
"\82\80\80\80\80\00" ;; offset 2 with one byte too many
509-
"\1a" ;; drop
510-
"\0b" ;; end
511-
)
512-
"integer representation too long"
513-
)
495+
;; The memory offset will be decoded as u64 in the memory64 proposal.
496+
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
497+
;; (assert_malformed
498+
;; (module binary
499+
;; "\00asm" "\01\00\00\00"
500+
;; "\01\04\01\60\00\00" ;; Type section
501+
;; "\03\02\01\00" ;; Function section
502+
;; "\05\03\01\00\01" ;; Memory section
503+
;; "\0a\11\01" ;; Code section
504+
;; ;; function 0
505+
;; "\0f\01\01" ;; local type count
506+
;; "\7f" ;; i32
507+
;; "\41\00" ;; i32.const 0
508+
;; "\28" ;; i32.load
509+
;; "\02" ;; alignment 2
510+
;; "\82\80\80\80\80\00" ;; offset 2 with one byte too many
511+
;; "\1a" ;; drop
512+
;; "\0b" ;; end
513+
;; )
514+
;; "integer representation too long"
515+
;; )
514516
(assert_malformed
515517
(module binary
516518
"\00asm" "\01\00\00\00"
@@ -549,25 +551,27 @@
549551
)
550552
"integer representation too long"
551553
)
552-
(assert_malformed
553-
(module binary
554-
"\00asm" "\01\00\00\00"
555-
"\01\04\01\60\00\00" ;; Type section
556-
"\03\02\01\00" ;; Function section
557-
"\05\03\01\00\01" ;; Memory section
558-
"\0a\12\01" ;; Code section
559-
;; function 0
560-
"\10\01\01" ;; local type count
561-
"\7f" ;; i32
562-
"\41\00" ;; i32.const 0
563-
"\41\03" ;; i32.const 3
564-
"\36" ;; i32.store
565-
"\02" ;; alignment 2
566-
"\82\80\80\80\80\00" ;; offset 2 with one byte too many
567-
"\0b" ;; end
568-
)
569-
"integer representation too long"
570-
)
554+
;; The memory offset will be decoded as u64 in the memory64 proposal.
555+
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
556+
;; (assert_malformed
557+
;; (module binary
558+
;; "\00asm" "\01\00\00\00"
559+
;; "\01\04\01\60\00\00" ;; Type section
560+
;; "\03\02\01\00" ;; Function section
561+
;; "\05\03\01\00\01" ;; Memory section
562+
;; "\0a\12\01" ;; Code section
563+
;; ;; function 0
564+
;; "\10\01\01" ;; local type count
565+
;; "\7f" ;; i32
566+
;; "\41\00" ;; i32.const 0
567+
;; "\41\03" ;; i32.const 3
568+
;; "\36" ;; i32.store
569+
;; "\02" ;; alignment 2
570+
;; "\82\80\80\80\80\00" ;; offset 2 with one byte too many
571+
;; "\0b" ;; end
572+
;; )
573+
;; "integer representation too long"
574+
;; )
571575

572576
;; Signed LEB128 must not be overlong
573577
(assert_malformed
@@ -629,44 +633,46 @@
629633
)
630634
"integer too large"
631635
)
632-
(assert_malformed
633-
(module binary
634-
"\00asm" "\01\00\00\00"
635-
"\01\04\01\60\00\00" ;; Type section
636-
"\03\02\01\00" ;; Function section
637-
"\05\03\01\00\01" ;; Memory section
638-
"\0a\10\01" ;; Code section
639-
;; function 0
640-
"\0e\01\01" ;; local type count
641-
"\7f" ;; i32
642-
"\41\00" ;; i32.const 0
643-
"\28" ;; i32.load
644-
"\02" ;; alignment 2
645-
"\82\80\80\80\10" ;; offset 2 with unused bits set
646-
"\1a" ;; drop
647-
"\0b" ;; end
648-
)
649-
"integer too large"
650-
)
651-
(assert_malformed
652-
(module binary
653-
"\00asm" "\01\00\00\00"
654-
"\01\04\01\60\00\00" ;; Type section
655-
"\03\02\01\00" ;; Function section
656-
"\05\03\01\00\01" ;; Memory section
657-
"\0a\10\01" ;; Code section
658-
;; function 0
659-
"\0e\01\01" ;; local type count
660-
"\7f" ;; i32
661-
"\41\00" ;; i32.const 0
662-
"\28" ;; i32.load
663-
"\02" ;; alignment 2
664-
"\82\80\80\80\40" ;; offset 2 with some unused bits set
665-
"\1a" ;; drop
666-
"\0b" ;; end
667-
)
668-
"integer too large"
669-
)
636+
;; The memory offset will be decoded as u64 in the memory64 proposal.
637+
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
638+
;; (assert_malformed
639+
;; (module binary
640+
;; "\00asm" "\01\00\00\00"
641+
;; "\01\04\01\60\00\00" ;; Type section
642+
;; "\03\02\01\00" ;; Function section
643+
;; "\05\03\01\00\01" ;; Memory section
644+
;; "\0a\10\01" ;; Code section
645+
;; ;; function 0
646+
;; "\0e\01\01" ;; local type count
647+
;; "\7f" ;; i32
648+
;; "\41\00" ;; i32.const 0
649+
;; "\28" ;; i32.load
650+
;; "\02" ;; alignment 2
651+
;; "\82\80\80\80\10" ;; offset 2 with unused bits set
652+
;; "\1a" ;; drop
653+
;; "\0b" ;; end
654+
;; )
655+
;; "integer too large"
656+
;; )
657+
;; (assert_malformed
658+
;; (module binary
659+
;; "\00asm" "\01\00\00\00"
660+
;; "\01\04\01\60\00\00" ;; Type section
661+
;; "\03\02\01\00" ;; Function section
662+
;; "\05\03\01\00\01" ;; Memory section
663+
;; "\0a\10\01" ;; Code section
664+
;; ;; function 0
665+
;; "\0e\01\01" ;; local type count
666+
;; "\7f" ;; i32
667+
;; "\41\00" ;; i32.const 0
668+
;; "\28" ;; i32.load
669+
;; "\02" ;; alignment 2
670+
;; "\82\80\80\80\40" ;; offset 2 with some unused bits set
671+
;; "\1a" ;; drop
672+
;; "\0b" ;; end
673+
;; )
674+
;; "integer too large"
675+
;; )
670676
(assert_malformed
671677
(module binary
672678
"\00asm" "\01\00\00\00"
@@ -742,45 +748,46 @@
742748
)
743749
"integer too large"
744750
)
745-
(assert_malformed
746-
(module binary
747-
"\00asm" "\01\00\00\00"
748-
"\01\04\01\60\00\00" ;; Type section
749-
"\03\02\01\00" ;; Function section
750-
"\05\03\01\00\01" ;; Memory section
751-
"\0a\11\01" ;; Code section
752-
;; function 0
753-
"\0f\01\01" ;; local type count
754-
"\7f" ;; i32
755-
"\41\00" ;; i32.const 0
756-
"\41\03" ;; i32.const 3
757-
"\36" ;; i32.store
758-
"\02" ;; alignment 2
759-
"\82\80\80\80\10" ;; offset 2 with unused bits set
760-
"\0b" ;; end
761-
)
762-
"integer too large"
763-
)
764-
(assert_malformed
765-
(module binary
766-
"\00asm" "\01\00\00\00"
767-
"\01\04\01\60\00\00" ;; Type section
768-
"\03\02\01\00" ;; Function section
769-
"\05\03\01\00\01" ;; Memory section
770-
"\0a\11\01" ;; Code section
771-
772-
;; function 0
773-
"\0f\01\01" ;; local type count
774-
"\7f" ;; i32
775-
"\41\00" ;; i32.const 0
776-
"\41\03" ;; i32.const 3
777-
"\36" ;; i32.store
778-
"\02" ;; alignment 2
779-
"\82\80\80\80\40" ;; offset 2 with some unused bits set
780-
"\0b" ;; end
781-
)
782-
"integer too large"
783-
)
751+
;; The memory offset will be decoded as u64 in the memory64 proposal.
752+
;; TODO: Re-enable this test as assert_trap test in the memory64 repo.
753+
;; (assert_malformed
754+
;; (module binary
755+
;; "\00asm" "\01\00\00\00"
756+
;; "\01\04\01\60\00\00" ;; Type section
757+
;; "\03\02\01\00" ;; Function section
758+
;; "\05\03\01\00\01" ;; Memory section
759+
;; "\0a\11\01" ;; Code section
760+
;; ;; function 0
761+
;; "\0f\01\01" ;; local type count
762+
;; "\7f" ;; i32
763+
;; "\41\00" ;; i32.const 0
764+
;; "\41\03" ;; i32.const 3
765+
;; "\36" ;; i32.store
766+
;; "\02" ;; alignment 2
767+
;; "\82\80\80\80\10" ;; offset 2 with unused bits set
768+
;; "\0b" ;; end
769+
;; )
770+
;; "integer too large"
771+
;; )
772+
;; (assert_malformed
773+
;; (module binary
774+
;; "\00asm" "\01\00\00\00"
775+
;; "\01\04\01\60\00\00" ;; Type section
776+
;; "\03\02\01\00" ;; Function section
777+
;; "\05\03\01\00\01" ;; Memory section
778+
;; "\0a\11\01" ;; Code section
779+
;; ;; function 0
780+
;; "\0f\01\01" ;; local type count
781+
;; "\7f" ;; i32
782+
;; "\41\00" ;; i32.const 0
783+
;; "\41\03" ;; i32.const 3
784+
;; "\36" ;; i32.store
785+
;; "\02" ;; alignment 2
786+
;; "\82\80\80\80\40" ;; offset 2 with some unused bits set
787+
;; "\0b" ;; end
788+
;; )
789+
;; "integer too large"
790+
;; )
784791

785792
;; Signed LEB128s sign-extend
786793
(assert_malformed

0 commit comments

Comments
 (0)