Skip to content

Commit c39abe4

Browse files
committed
Update CanonicalABI.md to match definitions.py
1 parent b3a9f79 commit c39abe4

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

design/mvp/CanonicalABI.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2040,9 +2040,7 @@ async def canon_lower(opts, callee, ft, task, flat_args):
20402040
nonlocal flat_results
20412041
flat_results = lower_sync_values(subtask, MAX_FLAT_RESULTS, results, ft.result_types(), flat_args)
20422042

2043-
inst.thread.release()
20442043
await callee(task, start_thunk, return_thunk)
2045-
await inst.thread.acquire()
20462044

20472045
subtask.finish()
20482046
else:
@@ -2073,11 +2071,6 @@ async def canon_lower(opts, callee, ft, task, flat_args):
20732071

20742072
return flat_results
20752073
```
2076-
In the sync case, the `thread` lock is released/reacquired before/after making
2077-
the cross-component call to allow other existing tasks to make progress or (if
2078-
there is no backpressure) new tasks to start. This makes a sync-lowered call
2079-
equivalent to waiting on an async-lowered call.
2080-
20812074
In the async case, `asyncio.create_task` followed by `await asyncio.sleep(0)`
20822075
are used together to achieve the effect of eagerly executing the `do_call`
20832076
Python coroutine without `await`ing it. Following the `sleep(0)`, the coroutine

0 commit comments

Comments
 (0)