Skip to content

Commit 983f01c

Browse files
committed
Review comments
1 parent f281506 commit 983f01c

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

design/mvp/Binary.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -310,22 +310,6 @@ Notes:
310310
independently unique among imports and exports, respectively.
311311
* URLs are compared for equality by plain byte identity.
312312

313-
314-
[`core:u32`]: https://webassembly.github.io/spec/core/binary/values.html#integers
315-
[`core:section`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-section
316-
[`core:custom`]: https://webassembly.github.io/spec/core/binary/modules.html#custom-section
317-
[`core:module`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-module
318-
[`core:version`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-version
319-
[`core:name`]: https://webassembly.github.io/spec/core/binary/values.html#binary-name
320-
[`core:import`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-import
321-
[`core:importdesc`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-importdesc
322-
[`core:functype`]: https://webassembly.github.io/spec/core/binary/types.html#binary-functype
323-
324-
[type-imports]: https://github.com/WebAssembly/proposal-type-imports/blob/master/proposals/type-imports/Overview.md
325-
[module-linking]: https://github.com/WebAssembly/module-linking/blob/main/proposals/module-linking/Explainer.md
326-
327-
[Basic URL Parser]: https://url.spec.whatwg.org/#concept-basic-url-parser
328-
329313
## Name Section
330314

331315
Like the core wasm [name
@@ -339,12 +323,12 @@ engines should not reject components which have an invalid `name` section.
339323
namesec ::= section_0(namedata)
340324
namedata ::= n:<name> (if n = 'component-name')
341325
name:<componentnamesubsec>?
342-
decls*:<declnamesubsec>*
326+
sortnames*:<sortnamesubsec>*
343327
namesubsection_N(B) ::= N:<byte> size:<u32> B (if size == |B|)
344328
345329
componentnamesubsec ::= namesubsection_0(<name>)
346-
declnamesubsec ::= namesubsection_1(<declnames>)
347-
declnames ::= sort:<sort> names:<namemap>
330+
sortnamesubsec ::= namesubsection_1(<sortnames>)
331+
sortnames ::= sort:<sort> names:<namemap>
348332
349333
namemap ::= names:vec(<nameassoc>)
350334
nameassoc ::= idx:<u32> name:<name>
@@ -353,3 +337,19 @@ nameassoc ::= idx:<u32> name:<name>
353337
where `namemap` is the same as for core wasm. A particular `sort` should only
354338
appear once within a `name` section, for example component instances can only be
355339
named once.
340+
341+
342+
[`core:u32`]: https://webassembly.github.io/spec/core/binary/values.html#integers
343+
[`core:section`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-section
344+
[`core:custom`]: https://webassembly.github.io/spec/core/binary/modules.html#custom-section
345+
[`core:module`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-module
346+
[`core:version`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-version
347+
[`core:name`]: https://webassembly.github.io/spec/core/binary/values.html#binary-name
348+
[`core:import`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-import
349+
[`core:importdesc`]: https://webassembly.github.io/spec/core/binary/modules.html#binary-importdesc
350+
[`core:functype`]: https://webassembly.github.io/spec/core/binary/types.html#binary-functype
351+
352+
[type-imports]: https://github.com/WebAssembly/proposal-type-imports/blob/master/proposals/type-imports/Overview.md
353+
[module-linking]: https://github.com/WebAssembly/module-linking/blob/main/proposals/module-linking/Explainer.md
354+
355+
[Basic URL Parser]: https://url.spec.whatwg.org/#concept-basic-url-parser

0 commit comments

Comments
 (0)