Skip to content

Commit f3609a5

Browse files
authored
Merge pull request #404 from JackChen0810/dev-1.0.0
Fix bug #403
2 parents aea69c8 + 092c98c commit f3609a5

File tree

4 files changed

+9
-29
lines changed
  • dss-framework/framework-plugins/dss-framework-orchestrator-publish/src/main/java/com/webank/wedatasphere/dss/orchestrator/publish/impl
  • dss-orchestrator/orchestrators/dss-workflow/dss-workflow-server/src/main/java/com/webank/wedatasphere/dss/workflow/service/impl
  • dss-standard
    • development-standard/development-process-standard/src/main/java/com/webank/wedatasphere/dss/standard/app/development/ref/impl
    • dss-standard-common/src/main/java/com/webank/wedatasphere/dss/standard/common/entity/ref

4 files changed

+9
-29
lines changed

dss-framework/framework-plugins/dss-framework-orchestrator-publish/src/main/java/com/webank/wedatasphere/dss/orchestrator/publish/impl/ExportDSSOrchestratorPluginImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ public Map<String, Object> exportOrchestrator(String userName, String workspaceN
120120
orchestratorExportRequestRef.setProjectName(projectName);
121121
orchestratorExportRequestRef.setUserName(userName);
122122
orchestratorExportRequestRef.setWorkspace(workspace);
123+
orchestratorExportRequestRef.setDSSLabels(dssLabels);
123124
AbstractResponseRef responseRef = (AbstractResponseRef) refExportService.getRefExportOperation().
124125
exportRef(orchestratorExportRequestRef);
125126
String resourceId = responseRef.getValue("resourceId").toString();

dss-orchestrator/orchestrators/dss-workflow/dss-workflow-server/src/main/java/com/webank/wedatasphere/dss/workflow/service/impl/WorkflowNodeServiceImpl.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,12 @@ public void deleteNode(String userName, AbstractAppConnNode node) throws Externa
146146
{
147147
String label = node.getJobContent().get(DSSCommonUtils.DSS_LABELS_KEY).toString();
148148
AppInstance appInstance = getAppInstance(appConn, label);
149-
RefDeletionOperation refDeletionOperation = developmentIntegrationStandard.getRefCRUDService(appInstance).getRefDeletionOperation();
149+
RefDeletionOperation refDeletionOperation = developmentIntegrationStandard.getRefCRUDService(appInstance).getRefDeletionOperation();
150150
Workspace workspace = (Workspace) node.getJobContent().get("workspace");
151151
NodeRequestRef ref = null;
152152
try {
153-
ref = AppConnRefFactoryUtils.newAppConnRef(NodeRequestRef.class, appConn.getClass().getClassLoader(), appConn.getClass().getPackage().getName());
153+
ref = AppConnRefFactoryUtils.newAppConnRefByPackageName(NodeRequestRef.class,
154+
appConn.getClass().getClassLoader(), appConn.getClass().getPackage().getName());
154155
} catch (Exception e) {
155156
logger.error("Failed to create DeleteNodeRequestRef", e);
156157
}
@@ -181,7 +182,8 @@ public Map<String, Object> updateNode(String userName, AbstractAppConnNode node)
181182
Workspace workspace = (Workspace) node.getJobContent().get("workspace");
182183
NodeRequestRef ref = null;
183184
try {
184-
ref = AppConnRefFactoryUtils.newAppConnRef(NodeRequestRef.class, appConn.getClass().getClassLoader(), appConn.getClass().getPackage().getName());
185+
ref = AppConnRefFactoryUtils.newAppConnRefByPackageName(NodeRequestRef.class,
186+
appConn.getClass().getClassLoader(), appConn.getClass().getPackage().getName());
185187
} catch (Exception e) {
186188
logger.error("Failed to create UpdateNodeRequestRef", e);
187189
}

dss-standard/development-standard/development-process-standard/src/main/java/com/webank/wedatasphere/dss/standard/app/development/ref/impl/CommonRequestRefImpl.java

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,11 @@
2929
public class CommonRequestRefImpl extends AbstractRequestRef implements CommonRequestRef {
3030

3131
protected String userName;
32-
protected String name;
3332
protected Long projectId;
3433
protected String projectName;
3534
protected String orcName;
3635
protected Long orcId;
3736
protected Workspace workspace;
38-
protected String type;
3937
protected String workspaceName;
4038
protected List<DSSLabel> dssLabelList;
4139
protected String contextID;
@@ -50,16 +48,6 @@ public void setUserName(String username) {
5048
this.userName = username;
5149
}
5250

53-
@Override
54-
public String getName() {
55-
return name;
56-
}
57-
58-
@Override
59-
public void setName(String name) {
60-
this.name = name;
61-
}
62-
6351
@Override
6452
public void setProjectId(Long projectId) {
6553
this.projectId = projectId;
@@ -110,27 +98,16 @@ public void setWorkspace(Workspace workspace) {
11098
this.workspace = workspace;
11199
}
112100

113-
@Override
114-
public String getType() {
115-
return type;
116-
}
117-
118-
@Override
119-
public void setType(String type) {
120-
this.type = type;
121-
}
122-
123101
@Override
124102
public void setWorkspaceName(String workspaceName) {
125-
this.workspaceName = workspaceName;
103+
this.workspaceName = workspaceName;
126104
}
127105

128106
@Override
129107
public String getWorkspaceName() {
130108
return this.workspaceName;
131109
}
132110

133-
134111
@Override
135112
public void setDSSLabels(List<DSSLabel> dssLabels) {
136113
this.dssLabelList = dssLabels;

dss-standard/dss-standard-common/src/main/java/com/webank/wedatasphere/dss/standard/common/entity/ref/AbstractRequestRef.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
public abstract class AbstractRequestRef implements RequestRef {
2424

2525
private Map<String, Object> parameters = new HashMap<>();
26-
private String name;
27-
private String type;
26+
protected String name;
27+
protected String type;
2828

2929
@Override
3030
public String getName() {

0 commit comments

Comments
 (0)