Skip to content

Commit b653e35

Browse files
committed
Revert "datachecker 支持 qualitis v6"
This reverts commit cc38829.
1 parent 228d1b7 commit b653e35

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

dss-appconn/appconns/dss-datachecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/datachecker/DataChecker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void run() {
8686

8787
}
8888

89-
public void begineCheck(DataCheckerExecutionAction action){
89+
public void begineCheck(RefExecutionAction action){
9090
boolean success=false;
9191
try {
9292
success= wbDao.validateTableStatusFunction(p, logger,action);

dss-appconn/appconns/dss-datachecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/datachecker/connector/DataCheckerDao.java

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@
1919
import com.alibaba.druid.pool.DruidDataSource;
2020

2121
import com.webank.wedatasphere.dss.appconn.datachecker.DataChecker;
22-
import com.webank.wedatasphere.dss.appconn.datachecker.DataCheckerExecutionAction;
2322
import com.webank.wedatasphere.dss.appconn.datachecker.common.CheckDataObject;
2423
import com.webank.wedatasphere.dss.appconn.datachecker.common.MaskCheckNotExistException;
2524
import com.webank.wedatasphere.dss.appconn.datachecker.utils.HttpUtils;
2625
import com.webank.wedatasphere.dss.appconn.datachecker.utils.QualitisUtil;
2726
import com.webank.wedatasphere.dss.standard.app.development.listener.common.RefExecutionAction;
28-
import com.webank.wedatasphere.dss.standard.app.development.listener.common.RefExecutionState;
2927
import okhttp3.FormBody;
3028
import okhttp3.RequestBody;
3129
import okhttp3.Response;
@@ -87,7 +85,7 @@ public static DataCheckerDao getInstance() {
8785
return instance;
8886
}
8987

90-
public boolean validateTableStatusFunction(Properties props, Logger log, DataCheckerExecutionAction action) {
88+
public boolean validateTableStatusFunction(Properties props, Logger log, RefExecutionAction action) {
9189
if (jobDS == null) {
9290
jobDS = DataDruidFactory.getJobInstance(props, log);
9391
if (jobDS == null) {
@@ -178,7 +176,7 @@ private boolean getDataCheckResult(Map<String, String> proObjectMap,
178176
Connection dopsConn,
179177
Properties props,
180178
Logger log,
181-
DataCheckerExecutionAction action,
179+
RefExecutionAction action,
182180
QualitisUtil qualitisUtil ) {
183181
String dataObjectStr = proObjectMap.get(DataChecker.DATA_OBJECT) == null ? "" : proObjectMap.get(DataChecker.DATA_OBJECT);
184182
if (StringUtils.isNotBlank(dataObjectStr)) {
@@ -236,16 +234,9 @@ private boolean getDataCheckResult(Map<String, String> proObjectMap,
236234
normalCheck = false;
237235
}
238236
}
239-
if(!normalCheck){
240-
return false;
241-
}
237+
return normalCheck
238+
&& checkQualitisData( objectNum,dataObject, log, action, props, dopsConn,qualitisUtil);
242239

243-
boolean qualitisCheck = checkQualitisData(objectNum, dataObject, log, action, props, dopsConn, qualitisUtil);
244-
if(!qualitisCheck){
245-
//如果是qualitis校验失败,则直接终止任务
246-
action.setState(RefExecutionState.Failed);
247-
}
248-
return qualitisCheck;
249240
}
250241

251242

0 commit comments

Comments
 (0)