Fix Json decoding (#317)

HannaTarasevich · web-flow · commit 22e96636d414 · 2024-02-06T17:51:47.000+05:30
* Fix Json deserialization

* Update

* Update test data
diff --git a/lib/generate-report.js b/lib/generate-report.js
@@ -406,22 +406,20 @@ function generateReport(options) {
     scenario.steps.forEach((step) => {
       if (step.embeddings !== undefined) {
         step.attachments = [];
-	
         step.embeddings.forEach((embedding, embeddingIndex) => {
 	  /* Decode Base64 for Text-ish attachements */
-	  if(
-	    embedding.mime_type === 'application/json' ||
-	    embedding.mime_type === 'text/html' ||
-	    embedding.mime_type === 'text/plain'
+	   if(
+           embedding.mime_type === 'text/html' ||
+           embedding.mime_type === 'text/plain'
 	  ) {
-	    embedding.data = Buffer.from(embedding.data.toString(), 'base64')
-	  }
-	
+        embedding.data = Buffer.from(embedding.data.toString(), 'base64')
+      }
           /* istanbul ignore else */
           if (
             embedding.mime_type === 'application/json' ||
             (embedding.media && embedding.media.type === 'application/json')
           ) {
+            embedding.data = Buffer.from(embedding.data, 'base64').toString()
             step.json = (step.json ? step.json : []).concat([
               typeof embedding.data === 'string'
                 ? JSON.parse(embedding.data)
diff --git a/test/unit/data/custom-metadata-json/multiple_different_attachements.json b/test/unit/data/custom-metadata-json/multiple_different_attachements.json
@@ -53,13 +53,13 @@
             },
             "embeddings": [
               {
-                "data": "{\"some\":\"json\"}",
+                "data": "eyJzb21lIjoianNvbiJ9",
                 "media": {
                   "type": "application/json"
                 }
               },
               {
-                "data": "{\"other\":\"json\"}",
+                "data": "eyJvdGhlciI6Impzb24ifQ==",
                 "media": {
                   "type": "application/json"
                 }
@@ -71,13 +71,13 @@
                 }
               },
               {
-                "data": "{\"yet another json\":5}",
+                "data": "eyJ5ZXQgYW5vdGhlciBqc29uIjo1fQ==",
                 "media": {
                   "type": "application/json"
                 }
               },
               {
-                "data": 0,
+                "data": "MA==",
                 "media": {
                   "type": "application/json"
                 }
diff --git a/test/unit/data/custom-metadata-json/undefined_scenarios_specified_v3.json b/test/unit/data/custom-metadata-json/undefined_scenarios_specified_v3.json
@@ -131,13 +131,13 @@
             },
             "embeddings": [
               {
-                "data": "{\"some\":\"json\"}",
+                "data": "eyJzb21lIjoianNvbiJ9",
                 "media": {
                   "type": "application/json"
                 }
               },
               {
-                "data": "{\"other\":\"json\"}",
+                "data": "eyJvdGhlciI6Impzb24ifQ==",
                 "media": {
                   "type": "application/json"
                 }
@@ -149,7 +149,7 @@
                 }
 	      },
 	      {
-		"data": "{\"yet another json\":5}",
+		"data": "eyJ5ZXQgYW5vdGhlciBqc29uIjo1fQ==",
 		"media": {
 	          "type": "application/json"
 		}
diff --git a/test/unit/data/json/before-and-after-hook.json b/test/unit/data/json/before-and-after-hook.json
@@ -83,9 +83,7 @@
                 "mime_type": "text/plain"
               },
               {
-                "data": {
-                  "json-string": true
-                },
+                "data": "eyJqc29uLXN0cmluZyI6IHRydWV9",
                 "mime_type": "application/json"
               }
             ]
diff --git a/test/unit/data/json/embeddings.json b/test/unit/data/json/embeddings.json
@@ -28,7 +28,7 @@
             },
             "embeddings": [
               {
-                "data": "[{\"data\":{\"x\":\"1\",\"y\":\"1\",\"url\":\"http://url.com\"},\"event\":\"start\",\"show\":1,\"id\":50},{\"data\":{\"x\":\"2\",\"y\":\"3\",\"url\":\"http://example.com\"},\"event\":\"stop\",\"show\":2,\"id\":51}]",
+                "data": "W3siZGF0YSI6eyJ4IjoiMSIsInkiOiIxIiwidXJsIjoiaHR0cDovL3VybC5jb20ifSwiZXZlbnQiOiJzdGFydCIsInNob3ciOjEsImlkIjo1MH0seyJkYXRhIjp7IngiOiIyIiwieSI6IjMiLCJ1cmwiOiJodHRwOi8vZXhhbXBsZS5jb20ifSwiZXZlbnQiOiJzdG9wIiwic2hvdyI6MiwiaWQiOjUxfV0=",
                 "mime_type": "application/json"
               },
               {
diff --git a/test/unit/data/output/merged-output.json b/test/unit/data/output/merged-output.json
@@ -1090,9 +1090,7 @@
                 "mime_type": "text/plain"
               },
               {
-                "data": {
-                  "json-string": true
-                },
+                "data": "eyJqc29uLXN0cmluZyI6IHRydWV9",
                 "mime_type": "application/json"
               }
             ]
@@ -1265,7 +1263,7 @@
             },
             "embeddings": [
               {
-                "data": "[{\"data\":{\"x\":\"1\",\"y\":\"1\",\"url\":\"http://url.com\"},\"event\":\"start\",\"show\":1,\"id\":50},{\"data\":{\"x\":\"2\",\"y\":\"3\",\"url\":\"http://example.com\"},\"event\":\"stop\",\"show\":2,\"id\":51}]",
+                "data": "W3siZGF0YSI6eyJ4IjoiMSIsInkiOiIxIiwidXJsIjoiaHR0cDovL3VybC5jb20ifSwiZXZlbnQiOiJzdGFydCIsInNob3ciOjEsImlkIjo1MH0seyJkYXRhIjp7IngiOiIyIiwieSI6IjMiLCJ1cmwiOiJodHRwOi8vZXhhbXBsZS5jb20ifSwiZXZlbnQiOiJzdG9wIiwic2hvdyI6MiwiaWQiOjUxfV0=",
                 "mime_type": "application/json"
               },
               {

Original file line number	Diff line number	Diff line change
`@@ -53,13 +53,13 @@`
`53`	`53`	`},`
`54`	`54`	`"embeddings": [`
`55`	`55`	`{`
`56`		`- "data": "{\"some\":\"json\"}",`
	`56`	`+ "data": "eyJzb21lIjoianNvbiJ9",`
`57`	`57`	`"media": {`
`58`	`58`	`"type": "application/json"`
`59`	`59`	`}`
`60`	`60`	`},`
`61`	`61`	`{`
`62`		`- "data": "{\"other\":\"json\"}",`
	`62`	`+ "data": "eyJvdGhlciI6Impzb24ifQ==",`
`63`	`63`	`"media": {`
`64`	`64`	`"type": "application/json"`
`65`	`65`	`}`
`@@ -71,13 +71,13 @@`
`71`	`71`	`}`
`72`	`72`	`},`
`73`	`73`	`{`
`74`		`- "data": "{\"yet another json\":5}",`
	`74`	`+ "data": "eyJ5ZXQgYW5vdGhlciBqc29uIjo1fQ==",`
`75`	`75`	`"media": {`
`76`	`76`	`"type": "application/json"`
`77`	`77`	`}`
`78`	`78`	`},`
`79`	`79`	`{`
`80`		`- "data": 0,`
	`80`	`+ "data": "MA==",`
`81`	`81`	`"media": {`
`82`	`82`	`"type": "application/json"`
`83`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -131,13 +131,13 @@`
`131`	`131`	`},`
`132`	`132`	`"embeddings": [`
`133`	`133`	`{`
`134`		`- "data": "{\"some\":\"json\"}",`
	`134`	`+ "data": "eyJzb21lIjoianNvbiJ9",`
`135`	`135`	`"media": {`
`136`	`136`	`"type": "application/json"`
`137`	`137`	`}`
`138`	`138`	`},`
`139`	`139`	`{`
`140`		`- "data": "{\"other\":\"json\"}",`
	`140`	`+ "data": "eyJvdGhlciI6Impzb24ifQ==",`
`141`	`141`	`"media": {`
`142`	`142`	`"type": "application/json"`
`143`	`143`	`}`
`@@ -149,7 +149,7 @@`
`149`	`149`	`}`
`150`	`150`	`},`
`151`	`151`	`{`
`152`		`- "data": "{\"yet another json\":5}",`
	`152`	`+ "data": "eyJ5ZXQgYW5vdGhlciBqc29uIjo1fQ==",`
`153`	`153`	`"media": {`
`154`	`154`	`"type": "application/json"`
`155`	`155`	`}`
Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,7 @@`
`83`	`83`	`"mime_type": "text/plain"`
`84`	`84`	`},`
`85`	`85`	`{`
`86`		`- "data": {`
`87`		`- "json-string": true`
`88`		`- },`
	`86`	`+ "data": "eyJqc29uLXN0cmluZyI6IHRydWV9",`
`89`	`87`	`"mime_type": "application/json"`
`90`	`88`	`}`
`91`	`89`	`]`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@`
`28`	`28`	`},`
`29`	`29`	`"embeddings": [`
`30`	`30`	`{`
`31`		`- "data": "[{\"data\":{\"x\":\"1\",\"y\":\"1\",\"url\":\"http://url.com\"},\"event\":\"start\",\"show\":1,\"id\":50},{\"data\":{\"x\":\"2\",\"y\":\"3\",\"url\":\"http://example.com\"},\"event\":\"stop\",\"show\":2,\"id\":51}]",`
	`31`	`+ "data": "W3siZGF0YSI6eyJ4IjoiMSIsInkiOiIxIiwidXJsIjoiaHR0cDovL3VybC5jb20ifSwiZXZlbnQiOiJzdGFydCIsInNob3ciOjEsImlkIjo1MH0seyJkYXRhIjp7IngiOiIyIiwieSI6IjMiLCJ1cmwiOiJodHRwOi8vZXhhbXBsZS5jb20ifSwiZXZlbnQiOiJzdG9wIiwic2hvdyI6MiwiaWQiOjUxfV0=",`
`32`	`32`	`"mime_type": "application/json"`
`33`	`33`	`},`
`34`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1090,9 +1090,7 @@`
`1090`	`1090`	`"mime_type": "text/plain"`
`1091`	`1091`	`},`
`1092`	`1092`	`{`
`1093`		`- "data": {`
`1094`		`- "json-string": true`
`1095`		`- },`
	`1093`	`+ "data": "eyJqc29uLXN0cmluZyI6IHRydWV9",`
`1096`	`1094`	`"mime_type": "application/json"`
`1097`	`1095`	`}`
`1098`	`1096`	`]`
`@@ -1265,7 +1263,7 @@`
`1265`	`1263`	`},`
`1266`	`1264`	`"embeddings": [`
`1267`	`1265`	`{`
`1268`		`- "data": "[{\"data\":{\"x\":\"1\",\"y\":\"1\",\"url\":\"http://url.com\"},\"event\":\"start\",\"show\":1,\"id\":50},{\"data\":{\"x\":\"2\",\"y\":\"3\",\"url\":\"http://example.com\"},\"event\":\"stop\",\"show\":2,\"id\":51}]",`
	`1266`	`+ "data": "W3siZGF0YSI6eyJ4IjoiMSIsInkiOiIxIiwidXJsIjoiaHR0cDovL3VybC5jb20ifSwiZXZlbnQiOiJzdGFydCIsInNob3ciOjEsImlkIjo1MH0seyJkYXRhIjp7IngiOiIyIiwieSI6IjMiLCJ1cmwiOiJodHRwOi8vZXhhbXBsZS5jb20ifSwiZXZlbnQiOiJzdG9wIiwic2hvdyI6MiwiaWQiOjUxfV0=",`
`1269`	`1267`	`"mime_type": "application/json"`
`1270`	`1268`	`},`
`1271`	`1269`	`{`