Skip to content

Commit f4f1dfe

Browse files
committed
refactor!: Use boolean param for Messages sandbox
1 parent da8f54e commit f4f1dfe

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1111
- Number Verification API
1212

1313
### Changed
14-
- `InputAction.Builder.dtmf` extension method uses `DtmfSettings` builder instead of setters
14+
- `InputAction.Builder#dtmf` extension method uses `DtmfSettings` builder instead of setters
15+
- `Messages#send` now uses optional Boolean parameter for sandbox instead of separate method
1516

1617
## [0.5.0] - 2024-07-25
1718

src/main/kotlin/com/vonage/client/kt/Messages.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ import com.vonage.client.messages.messenger.*
2323
import com.vonage.client.messages.viber.*
2424
import java.util.UUID
2525

26-
class Messages(private val client: MessagesClient) {
27-
fun send(message: MessageRequest): UUID =
28-
client.useRegularEndpoint().sendMessage(message).messageUuid
29-
30-
fun sendSandbox(message: MessageRequest): UUID =
31-
client.useSandboxEndpoint().sendMessage(message).messageUuid
26+
class Messages(private val messagesClient: MessagesClient) {
27+
fun send(message: MessageRequest, sandbox: Boolean = false): UUID =
28+
(if (sandbox) messagesClient.useSandboxEndpoint()
29+
else messagesClient.useRegularEndpoint()).sendMessage(message).messageUuid
3230
}
3331

3432
fun smsText(init: SmsTextRequest.Builder.() -> Unit): SmsTextRequest =

src/test/kotlin/com/vonage/client/kt/MessagesTest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ class MessagesTest : AbstractTest() {
5353
status = status, expectedResponseParams = expectedResponseParams
5454
)
5555
assertEquals(messageUuid, messagesClient.send(req))
56-
57-
// TODO fix mocking full url
58-
//val sandboxUrl = "https://messages-sandbox.nexmo.com$sendUrl"
59-
//mockJsonJwtPost(sandboxUrl, expectedBodyParams, status, expectedResponseParams)
60-
//assertEquals(messageUuid, messagesClient.sendSandbox(req))
6156
}
6257

6358
private fun baseBody(messageType: String, channel: String): Map<String, Any> =

0 commit comments

Comments
 (0)