refactor!: Sms.wasSuccessfully extension function

Author: SMadani

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.0.0] - 2024-10-?? (expected)
+First stable GA release
+
+### Changed
+- `Sms.wasSuccessfullySent()` now an extension function rather than being part of the client
+
 ## [1.0.0-RC2] - 2024-09-26
 Messages API updates based on Java SDK v8.11.0
 

pom.xml

@@ -5,7 +5,7 @@
 
   <groupId>com.vonage</groupId>
   <artifactId>server-sdk-kotlin</artifactId>
-  <version>1.0.0-RC2</version>
+  <version>1.0.0</version>
 
   <name>Vonage Kotlin Server SDK</name>
   <description>Kotlin client for Vonage APIs</description>
@@ -249,7 +249,7 @@
         <plugins>
           <plugin>
             <artifactId>maven-gpg-plugin</artifactId>
-            <version>3.2.6</version>
+            <version>3.2.7</version>
             <executions>
               <execution>
                 <id>sign-artifacts</id>

src/main/kotlin/com/vonage/client/kt/Sms.kt

@@ -122,14 +122,12 @@ class Sms internal constructor(private val client: SmsClient) {
         if (protocolId != null) msgObj.protocolId = protocolId
         return send(msgObj, statusReport, ttl, messageClass, clientRef, contentId, entityId, callbackUrl)
     }
-
-    /**
-     * Convenience method to check if all messages were sent successfully.
-     *
-     * @param response The list of [SmsSubmissionResponseMessage] objects returned when sending a message.
-     *
-     * @return `true` if all messages responses have a status of [MessageStatus.OK], `false` otherwise.
-     */
-    fun wasSuccessfullySent(response: List<SmsSubmissionResponseMessage>): Boolean =
-        response.all { ssrm -> ssrm.status == MessageStatus.OK }
 }
+
+/**
+ * Convenience method to check if all messages were sent successfully.
+ *
+ * @return `true` if all messages responses have a status of [MessageStatus.OK], `false` otherwise.
+ */
+fun List<SmsSubmissionResponseMessage>.wasSuccessfullySent(): Boolean =
+    isNotEmpty() && all { it.status == MessageStatus.OK }

src/main/kotlin/com/vonage/client/kt/Vonage.kt

@@ -18,7 +18,7 @@ package com.vonage.client.kt
 import com.vonage.client.HttpConfig
 import com.vonage.client.VonageClient
 
-const val VONAGE_KOTLIN_SDK_VERSION = "1.0.0-RC2"
+const val VONAGE_KOTLIN_SDK_VERSION = "1.0.0"
 private const val SDK_USER_AGENT = "vonage-kotlin-sdk/$VONAGE_KOTLIN_SDK_VERSION"
 
 /**

src/test/kotlin/com/vonage/client/kt/SmsTest.kt

@@ -70,7 +70,7 @@ class SmsTest : AbstractTest() {
         assertEquals(network, first.network)
         assertEquals(clientRef, first.clientRef)
         assertEquals(accountRef, first.accountRef)
-        assertTrue(client.wasSuccessfullySent(response))
+        assertTrue(response.wasSuccessfullySent())
     }
 
     private fun errorStatus(code: Int, text: String) = mapOf("status" to code, "error-text" to text)
@@ -185,7 +185,7 @@ class SmsTest : AbstractTest() {
         )
         val response = client.sendText(from, toNumber, text)
         assertNotNull(response)
-        assertFalse(client.wasSuccessfullySent(response))
+        assertFalse(response.wasSuccessfullySent())
 
         assertEquals(24, response.size)
         var offset = 0