Keybinds not working

[TheFox666]

Hi, first of all thanks for this awesome plugin. But i have a big problem with it. It just doesn't set the mappings for me. I tried just using default recommended settings, no change. Now i tried it like in the code below. Also no change. Why isnt my neovim accepting my settings? i Createt a lspzero.lua in my after/plugin folder structure. Can you hint me what i am missing here potentially?

local lsp = require('lsp-zero')

lsp.preset('recommended')

lsp.set_preferences({
  set_lsp_keymaps = false
})

lsp.on_attach(function(client, bufnr)
    if vim.b.lsp_attached then return end
    vim.b.lsp_attached = true

    require('nvim-navic').attach(client, bufnr)

    local noremap = { buffer = bufnr, remap = false }
    local bind = vim.keymap.set

    bind('n', '<leader>rn', '<cmd>lua vim.lsp.buf.rename()<cr>', noremap)
end)

lsp.setup()

EDIT:
cmp keybinds seem to work, but LSP keybinds just dont exist :(

[VonHeikemen]

does it happen with the default keybindings too? Try using set_lsp_keymaps = true in .set_preferences.

[VonHeikemen]

do you have your config with lsp-zero on github?

[TheFox666]

I am remaking it from scratch there is a plugin lsp-signature which disturbed this one it seems. When i added it nothing worked anymore have to look into it why

[VonHeikemen]

Is it this lsp_signature.nvim?

Use the .on_attach function they provide.

local lsp = require('lsp-zero')
lsp.preset('recommended')

local lsp_signature_config = {
  --- configure lsp_signature here
}

lsp.on_attach(function(client, bufnr)
  require('lsp_signature').on_attach(lsp_signature_config, bufnr)
end)

lsp.setup()

They are overriding a builtin neovim function in their setup function. I don't know if that causes the problem, just looks weird to me.

[TheFox666]

Yeah thats the plugin, i have to fiddle around with it. thanks for the hint with the code. I try it out.
Can i also override the keybinds of luasnip with this method?

[VonHeikemen]

Do you mean the keybindings to navigate the snippet placeholder? You can override that with .setup_nvim_cmp. I have an example in advance usage page.