Suggest global interactive mode the first time --interactive is passed

Author: Gedochao

modules/cli/src/main/scala/scala/cli/commands/util/SharedOptionsUtil.scala

@@ -13,6 +13,8 @@ import scala.build._
 import scala.build.blooprifle.BloopRifleConfig
 import scala.build.compiler.{BloopCompilerMaker, ScalaCompilerMaker, SimpleScalaCompilerMaker}
 import scala.build.errors.BuildException
+import scala.build.interactive.Interactive
+import scala.build.interactive.Interactive.{InteractiveAsk, InteractiveNop}
 import scala.build.internal.CsLoggerUtil._
 import scala.build.internal.{Constants, FetchExternalBinary, OsLibc, Util}
 import scala.build.options.{Platform, ScalacOpt, ShadowingSeq}
@@ -25,7 +27,7 @@ import scala.concurrent.duration._
 import scala.util.Properties
 import scala.util.control.NonFatal
 
-object SharedOptionsUtil {
+object SharedOptionsUtil extends CommandHelpers {
 
   private def downloadInputs(cache: FileCache[Task]): String => Either[String, Array[Byte]] = {
     url =>
@@ -213,22 +215,56 @@ object SharedOptionsUtil {
           localRepository = LocalRepo.localRepo(directories.directories.localRepoDir),
           verbosity = Some(logging.verbosity),
           strictBloopJsonCheck = strictBloopJsonCheck,
-          interactive = Some(interactiveMode)
+          interactive = Some(() => interactive)
         ),
         notForBloopOptions = bo.PostBuildOptions(
           scalaJsLinkerOptions = linkerOptions(js)
         )
       )
     }
 
-    def interactiveMode: Boolean = logging.verbosityOptions.interactive
-      .orElse(configDb.get(Keys.interactive).getOrElse(None))
-      .getOrElse(false)
+    def globalInteractiveWasSuggested: Option[Boolean] =
+      configDb.getOrNone(Keys.globalInteractiveWasSuggested, logger)
 
-    def configDb: ConfigDb =
-      ConfigDb.open(v) match
-        case Left(ex)        => logger.exit(ex)
-        case Right(configDb) => configDb
+    def interactive: Interactive =
+      (
+        logging.verbosityOptions.interactive,
+        configDb.getOrNone(Keys.interactive, logger),
+        globalInteractiveWasSuggested
+      ) match {
+        case (Some(true), _, Some(true)) => InteractiveAsk
+        case (_, Some(true), _)          => InteractiveAsk
+        case (Some(true), _, _) =>
+          val answers @ List(yesAnswer, _) = List("Yes", "No")
+          InteractiveAsk.chooseOne(
+            """You have run the current scala-cli command with the --interactive mode turned on.
+              |Would you like to leave it on permanently?""".stripMargin,
+            answers
+          ) match {
+            case Some(answer) if answer == yesAnswer =>
+              configDb
+                .set(Keys.interactive, true)
+                .set(Keys.globalInteractiveWasSuggested, true)
+                .save(v.directories.directories)
+              logger.message(
+                "--interactive is now set permanently. All future scala-cli commands will run with the flag set to true."
+              )
+              logger.message(
+                "If you want to turn this setting off at any point, just run `scala-cli config interactive false`."
+              )
+            case _ =>
+              configDb
+                .set(Keys.globalInteractiveWasSuggested, true)
+                .save(v.directories.directories)
+              logger.message(
+                "If you want to turn this setting permanently on at any point, just run `scala-cli config interactive true`."
+              )
+          }
+          InteractiveAsk
+        case _ => InteractiveNop
+      }
+
+    def configDb: ConfigDb = ConfigDb.open(v).orExit(logger)
 
     def downloadJvm(jvmId: String, options: bo.BuildOptions): String = {
       implicit val ec = options.finalCache.ec

modules/cli/src/main/scala/scala/cli/config/ConfigDb.scala

@@ -5,8 +5,7 @@ import com.github.plokhotnyuk.jsoniter_scala.macros._
 import coursier.parse.RawJson
 
 import java.nio.file.attribute.PosixFilePermission
-
-import scala.build.Directories
+import scala.build.{Directories, Logger}
 import scala.build.errors.BuildException
 import scala.cli.commands.SharedOptions
 import scala.cli.commands.util.CommonOps.SharedDirectoriesOptionsOps
@@ -44,6 +43,19 @@ final class ConfigDb private (
           .map(Some(_))
     }
 
+  /** Gets an entry.
+    *
+    * If the value cannot be decoded or the key isn't in the DB, None is returned.
+    *
+    * Otherwise, the value is returned wrapped in Some.
+    */
+  def getOrNone[T](key: Key[T], logger: Logger): Option[T] = get[T](key) match {
+    case Right(maybeValue) => maybeValue
+    case Left(ex) =>
+      logger.debug(ex)
+      None
+  }
+
   /** Sets an entry in memory */
   def set[T](key: Key[T], value: T): this.type = {
     val b = key.write(value)

modules/cli/src/main/scala/scala/cli/config/Keys.scala

@@ -19,8 +19,12 @@ object Keys {
 
   val interactive = new Key.BooleanEntry(Seq.empty, "interactive")
 
-  def all = Seq[Key[_]](
+  // setting indicating if the global interactive mode was suggested
+  val globalInteractiveWasSuggested = new Key.BooleanEntry(Seq.empty, "interactive-was-suggested")
+
+  def all: Seq[Key[_]] = Seq[Key[_]](
     interactive,
+    globalInteractiveWasSuggested,
     actions,
     userName,
     userEmail,

modules/options/src/main/scala/scala/build/options/InternalOptions.scala

@@ -4,6 +4,8 @@ import coursier.cache.FileCache
 import coursier.util.Task
 
 import scala.build.Positioned
+import scala.build.interactive.Interactive
+import scala.build.interactive.Interactive.InteractiveNop
 
 final case class InternalOptions(
   keepDiagnostics: Boolean = false,
@@ -12,7 +14,7 @@ final case class InternalOptions(
   verbosity: Option[Int] = None,
   // FIXME Should be removed, not a real option (not meant to be set from using directives)
   strictBloopJsonCheck: Option[Boolean] = None,
-  interactive: Option[Boolean] = None,
+  interactive: Option[() => Interactive] = None,
   javaClassNameVersionOpt: Option[String] = None,
   /** Whether to keep the coursier.Resolution instance in [[scala.build.Artifacts]]
     *