feat: add setting to hide error notifications

close #870

Author: Vinzent03

src/constants.ts

@@ -19,6 +19,7 @@ export const DEFAULT_SETTINGS: ObsidianGitSettings = {
     disablePush: false,
     pullBeforePush: true,
     disablePopups: false,
+    showErrorNotices: true,
     disablePopupsForNoChanges: false,
     listChangedFilesInMessageBody: false,
     showStatusBar: true,

src/main.ts

@@ -1428,7 +1428,9 @@ I strongly recommend to use "Source mode" for viewing the conflicted files. For
         }
 
         this.setPluginState({ gitAction: CurrentGitAction.idle });
-        new Notice(error.message, timeout);
+        if (this.settings.showErrorNotices) {
+            new Notice(error.message, timeout);
+        }
         console.error(`${this.manifest.id}:`, error.stack);
         this.statusBar?.displayMessage(error.message.toLowerCase(), timeout);
     }

src/setting/settings.ts

@@ -532,9 +532,9 @@ export class ObsidianGitSettingsTab extends PluginSettingTab {
         }
 
         new Setting(containerEl)
-            .setName("Disable notifications")
+            .setName("Disable informative notifications")
             .setDesc(
-                "Disable notifications for git operations to minimize distraction (refer to status bar for updates). Errors are still shown as notifications even if you enable this setting."
+                "Disable informative notifications for git operations to minimize distraction (refer to status bar for updates)."
             )
             .addToggle((toggle) =>
                 toggle
@@ -546,6 +546,20 @@ export class ObsidianGitSettingsTab extends PluginSettingTab {
                     })
             );
 
+        new Setting(containerEl)
+            .setName("Disable error notifications")
+            .setDesc(
+                "Disable errror notifications of any kind to minimize distraction (refer to status bar for updates)."
+            )
+            .addToggle((toggle) =>
+                toggle
+                    .setValue(!plugin.settings.showErrorNotices)
+                    .onChange(async (value) => {
+                        plugin.settings.showErrorNotices = !value;
+                        await plugin.saveSettings();
+                    })
+            );
+
         if (!plugin.settings.disablePopups)
             new Setting(containerEl)
                 .setName("Hide notifications for no changes")

src/types.ts

@@ -20,7 +20,14 @@ export interface ObsidianGitSettings {
      * Whether to pull on commit-and-sync
      */
     pullBeforePush: boolean;
+    /**
+     * Whether messages from {@link ObsidianGit.displayMessage} should be shown
+     */
     disablePopups: boolean;
+    /**
+     * Whether messages from {@link ObsidianGit.displayError} should be shown
+     */
+    showErrorNotices: boolean;
     disablePopupsForNoChanges: boolean;
     listChangedFilesInMessageBody: boolean;
     showStatusBar: boolean;