✨ Add fixer for MultiLineArrayCommaSniff

Author: Vincent Langlet

Symfony3Custom/Sniffs/Arrays/MultiLineArrayCommaSniff.php

@@ -72,11 +72,18 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
                     if ($tokens[$lastComma]['code'] !== T_WHITESPACE
                         && $tokens[$lastComma]['code'] !== T_COMMENT
                     ) {
-                        $phpcsFile->addError(
+                        $fix = $phpcsFile->addFixableError(
                             'Add a comma after each item in a multi-line array',
                             $stackPtr,
                             'Invalid'
                         );
+
+                        if ($fix === true) {
+                            $ptr = $phpcsFile->findPrevious(array(T_WHITESPACE, T_COMMENT), $closePtr-1, $stackPtr, true);
+                            $phpcsFile->fixer->addContent($ptr, ',');
+                            $phpcsFile->fixer->endChangeset();
+                        }
+
                         break;
                     }
                 }

Symfony3Custom/Tests/Arrays/MultiLineArrayCommaUnitTest.inc

@@ -4,13 +4,13 @@
 $arr = array('foo', 'bar');
 
 $arr = array(
-        'foo'
-        'bar',
+        'foo',
+        'bar'
 );
 
 $arr = array(
-        'foo'
-        'bar'
+        'foo',
+        'bar',
 );
 
 $arr = array(
@@ -20,13 +20,13 @@ $arr = array(
 $arr = ['foo', 'bar'];
 
 $arr = [
-        'foo'
-        'bar',
+        'foo',
+        'bar'
 ];
 
 $arr = [
-        'foo'
-        'bar'
+        'foo',
+        'bar',
 ];
 
 $arr = [
@@ -36,23 +36,23 @@ $arr = [
 $arr = array('foo', 'bar' /* baz */);
 
 $arr = array(
-        'foo'
-        'bar', //baz
+        'foo',
+        'bar' //baz
 );
 
 $arr = array(
-        'foo'
-        'bar' //baz
+        'foo',
+        'bar', //baz
 );
 
 $arr = array(
-        'foo'
-        'bar', /* baz */
+        'foo',
+        'bar' /* baz */
 );
 
 $arr = array(
-        'foo'
-        'bar' /* baz */
+        'foo',
+        'bar', /* baz */
 );
 
 $arr = array(
@@ -63,23 +63,23 @@ $arr = array(
 $arr = ['foo', 'bar' /* baz */];
 
 $arr = [
-        'foo'
-        'bar', //baz
+        'foo',
+        'bar' //baz
 ];
 
 $arr = [
-        'foo'
-        'bar' //baz
+        'foo',
+        'bar', //baz
 ];
 
 $arr = [
-        'foo'
-        'bar', /* baz */
+        'foo',
+        'bar' /* baz */
 ];
 
 $arr = [
-        'foo'
-        'bar' /* baz */
+        'foo',
+        'bar', /* baz */
 ];
 
 $arr = [

Symfony3Custom/Tests/Arrays/MultiLineArrayCommaUnitTest.inc.fixed

@@ -0,0 +1,87 @@
+<?php
+
+// classic array syntax
+$arr = array('foo', 'bar');
+
+$arr = array(
+        'foo',
+        'bar',
+);
+
+$arr = array(
+        'foo',
+        'bar',
+);
+
+$arr = array(
+);
+
+// short array syntax
+$arr = ['foo', 'bar'];
+
+$arr = [
+        'foo',
+        'bar',
+];
+
+$arr = [
+        'foo',
+        'bar',
+];
+
+$arr = [
+];
+
+// classic array syntax with comments
+$arr = array('foo', 'bar' /* baz */);
+
+$arr = array(
+        'foo',
+        'bar', //baz
+);
+
+$arr = array(
+        'foo',
+        'bar', //baz
+);
+
+$arr = array(
+        'foo',
+        'bar', /* baz */
+);
+
+$arr = array(
+        'foo',
+        'bar', /* baz */
+);
+
+$arr = array(
+    // foo => bar
+);
+
+// short array syntax with comments
+$arr = ['foo', 'bar' /* baz */];
+
+$arr = [
+        'foo',
+        'bar', //baz
+];
+
+$arr = [
+        'foo',
+        'bar', //baz
+];
+
+$arr = [
+        'foo',
+        'bar', /* baz */
+];
+
+$arr = [
+        'foo',
+        'bar', /* baz */
+];
+
+$arr = [
+    // foo => bar
+];

Symfony3Custom/Tests/Arrays/MultiLineArrayCommaUnitTest.php

@@ -20,12 +20,12 @@ class Symfony3Custom_Tests_Arrays_MultiLineArrayCommaUnitTest
     public function getErrorList()
     {
         return array(
-            11  => 1,
-            27 => 1,
-            43 => 1,
-            53 => 1,
-            70 => 1,
-            80 => 1,
+            6  => 1,
+            22 => 1,
+            38 => 1,
+            48 => 1,
+            65 => 1,
+            75 => 1,
         );
     }