✨ Abstract function should start by Abstract

Author: Vincent Langlet

README.md

@@ -61,9 +61,6 @@ In Sniff/Commenting/FunctionCommentSniff:
 - don't check docblocks for test, setUp and tearDown methods (PHPunit, would be blank)
 - do check protected and private methods for docblocks
 
-In Sniff/NamingConventions/ValidClassNameSniff
-- remove the abstract class name rule
-
 In ruleset.xml
 - Disabled the class comment rule
 - Changed the concatenation spacing rule, for readability, to require 1 space around concatenation dot, instead of no spaces as the [Symfony](https://symfony.com/doc/current/contributing/code/standards.html#structure) standard requires.

Symfony3Custom/Sniffs/NamingConventions/ValidClassNameSniff.php

@@ -125,6 +125,27 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
                 break;
             }
 
+            /*
+             * Prefix abstract classes with Abstract.
+             */
+            if ('T_ABSTRACT' == $tokens[$stackPtr]['type']) {
+                $name = $phpcsFile->findNext(T_STRING, $stackPtr);
+                $function = $phpcsFile->findNext(T_FUNCTION, $stackPtr);
+
+                // making sure we're not dealing with an abstract function
+                if ($name && (is_null($function)
+                    || $name < $function)
+                    && substr($tokens[$name]['content'], 0, 8) != 'Abstract'
+                ) {
+                    $phpcsFile->addError(
+                        'Abstract class name is not prefixed with "Abstract"',
+                        $stackPtr,
+                        'InvalidAbstractName'
+                    );
+                }
+                break;
+            }
+
             $stackPtr++;
         }