Skip to content

Updating query builder from upstream #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SammyVimes opened this issue May 22, 2025 · 2 comments · May be fixed by #318
Open

Updating query builder from upstream #317

SammyVimes opened this issue May 22, 2025 · 2 comments · May be fixed by #318

Comments

@SammyVimes
Copy link

SammyVimes commented May 22, 2025 •
edited
Loading

Hi!

As I understand, VM's query builder's code is based on that of grafana's prometheus plugin. It was not updated for quite some time and doesn't contain some notable fixes (like stopping the parser on ambiguous queries). I also have this PR for Prometheus which is actually intended for VM, since that is what I use.

I can take this issue, if it is ok.
@Loori-R
Copy link
Contributor

Loori-R commented May 22, 2025

Hi @SammyVimes!
Sure, that sounds great — really appreciate you offering to take this on. Your PR and help are very welcome!

@SammyVimes SammyVimes linked a pull request May 25, 2025 that will close this issue
Open
@SammyVimes
Copy link
Author

@Loori-R Hi!

Opened a PR here: #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update visual query build from grafana upstream SammyVimesFiledIssues/victoriametrics-datasource
2 participants
@SammyVimes @Loori-R