feat: molecule testing for victoria_cluster role (#2)

* add molecule tests for victoria_cluster role

* restore use_environment usage

* review fixes: remove cache update, switch to platform native modules

Author: zekker6

.gitignore

@@ -1,2 +1,3 @@
 .idea
 .vagrant
+.vscode

roles/docker/tasks/main.yaml

@@ -1,14 +1,16 @@
 - name: Install Docker into Debian like system
   block:
   - name: install packages
-    package:
+    apt:
       name:
         - apt-transport-https
         - ca-certificates
         - curl
         - gnupg2
         - software-properties-common
       state: present
+      update_cache: yes
+      cache_valid_time: 3600
 
   - name: install repo key
     apt_key:
@@ -26,6 +28,7 @@
         - docker-ce-cli
         - containerd.io
       update_cache: yes
+      cache_valid_time: 3600
   when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'
 
 - name: Install Docker into RedHat like system
@@ -43,9 +46,10 @@
         value: 0
 
     - name: Install Docker
-      package:
+      yum:
         name: docker-ce
         state: latest
+        update_cache: yes
   when: ansible_distribution == 'CentOS' or ansible_distribution == 'Red Hat Enterprise Linux'
 
 - name: put docker config

roles/victoria_cluster/molecule/default/converge.yml

@@ -0,0 +1,32 @@
+---
+- name: ensure docker
+  become: true
+  hosts: all
+  roles: [ docker ]
+
+- name: ensure victoria_storage
+  become: true
+  hosts: all
+  roles: [ victoria_cluster ]
+  vars: 
+    vm_role: victoria-storage
+    if_name: enp0s8
+  tags: [ 'vm_storage', 'victoria_cluster' ]
+
+- name: ensure victoria_select
+  become: true
+  hosts: all
+  roles: [ victoria_cluster ]
+  vars: 
+    vm_role: victoria-select
+    if_name: enp0s8
+  tags: [ 'vm_select', 'victoria_cluster' ]
+
+- name: ensure victoria_insert
+  become: true
+  hosts: all
+  roles: [ victoria_cluster ]
+  vars: 
+    vm_role: victoria-insert
+    if_name: enp0s8
+  tags: [ 'vm_insert', 'victoria_cluster' ]

roles/victoria_cluster/molecule/default/molecule.yml

@@ -0,0 +1,52 @@
+---
+dependency:
+  name: galaxy
+
+driver:
+  name: vagrant
+
+lint: |
+  set -ex
+  yamllint .
+  ansible-lint .
+
+platforms:
+  - name: victoria-cluster-bionic-1
+    box: ubuntu/bionic64
+    memory: 2048
+    cpus: 1
+    groups:
+    - victoria_cluster
+    interfaces:
+      - auto_config: true
+        network_name: private_network
+        type: dhcp
+
+  - name: victoria-cluster-bionic-2
+    box: ubuntu/bionic64
+    memory: 2048
+    cpus: 1
+    groups:
+    - victoria_cluster
+    interfaces:
+      - auto_config: true
+        network_name: private_network
+        type: dhcp
+
+  - name: victoria-cluster-bionic-3
+    box: ubuntu/bionic64
+    memory: 2048
+    cpus: 1
+    groups:
+    - victoria_cluster
+    interfaces:
+      - auto_config: true
+        network_name: private_network
+        type: dhcp
+
+provisioner:
+  name: ansible
+
+verifier:
+  name: ansible
+  enabled: True

roles/victoria_cluster/molecule/default/tests/test_defaut.yml

@@ -0,0 +1,20 @@
+port:
+  tcp:8480:
+    title: Ensure vminsert is listening
+    listening: true
+
+  tcp:8481:
+    title: Ensure vmselect is listening
+    listening: true  
+
+  tcp:8482:
+    title: Ensure vmstorage is listening
+    listening: true
+  
+  tcp:8400:
+    title: Ensure vmstorage is listening
+    listening: true  
+
+  tcp:8401:
+    title: Ensure vmstorage is listening
+    listening: true

roles/victoria_cluster/molecule/default/verify.yml

@@ -0,0 +1,90 @@
+---
+# Molecule Goss Tests
+
+- name: Verify
+  hosts: all
+  become: true
+  vars:
+    goss_version: v0.3.10
+    goss_arch: amd64
+    goss_bin: /usr/local/bin/goss
+    goss_sha256sum: 150f25495ca0d1d4fd2ef8d0e750dbd767a15e9a522505f99b61dd1dd40a76d4
+    goss_url: "https://github.com/aelsabbahy/goss/releases/download/{{ goss_version }}/goss-linux-{{ goss_arch }}"
+    goss_test_directory: /tmp/molecule/goss
+    goss_format: documentation
+  tasks:
+    - name: Download and install Goss
+      get_url:
+        url: "{{ goss_url }}"
+        dest: "{{ goss_bin }}"
+        sha256sum: "{{ goss_sha256sum }}"
+        mode: "u=rwx,go=rx"
+      register: download_goss
+      until: download_goss is succeeded
+      retries: 3
+
+    - name: Create Molecule directory for test files
+      file:
+        path: "{{ goss_test_directory }}"
+        state: directory
+
+    - name: Find Goss tests on localhost
+      find:
+        paths: "{{ lookup('env', 'MOLECULE_VERIFIER_TEST_DIRECTORY') }}"
+        patterns:
+          - "test[-.\\w]*.yml"
+          - "test_host_{{ ansible_hostname }}[-.\\w]*.yml"
+        excludes:
+          - "test_host_(?!{{ ansible_hostname }})[-.\\w]*.yml"
+        use_regex: true
+      delegate_to: localhost
+      register: test_files
+      changed_when: false
+      become: false
+
+    - name: debug
+      debug:
+        msg: "{{ test_files.files }}"
+        verbosity: 3
+
+    - name: Copy Goss tests to remote
+      copy:
+        src: "{{ item.path }}"
+        dest: "{{ goss_test_directory }}/{{ item.path | basename }}"
+      with_items:
+        - "{{ test_files.files }}"
+      loop_control:
+        label: "{{ item.path | basename }}"
+
+    - name: Register test files
+      find:
+        paths:
+          - "{{ goss_test_directory }}"
+        patterns:
+          - "test_*.yml"
+      register: test_files
+
+    - block:
+        - name: Execute Goss tests
+          command: "{{ goss_bin }} -g {{ item }} validate --format {{ goss_format }}"
+          register: test_results
+          with_items: "{{ test_files.files | map(attribute='path') | list }}"
+          loop_control:
+            label: "{{ item | basename }}"
+          failed_when: false
+
+        - name: Display details about the Goss results
+          debug:
+            msg: "{{ item.stdout_lines }}"
+          with_items: "{{ test_results.results }}"
+          loop_control:
+            label: "{{ item[item.ansible_loop_var] | basename }}"
+
+        - name: Fail when tests fail
+          fail:
+            msg: "Goss failed to validate"
+          when: item.rc != 0
+          with_items: "{{ test_results.results }}"
+          loop_control:
+            label: "{{ item[item.ansible_loop_var] | basename }}"
+      when: test_files is succeeded