AddExtraSettings doesn't respect NullValueHandling?

[sean-feldman-sh]

It looks like Verify ignores JSON serialization setting for NullValueHandling.
Using Rider 2025.1.2 with .NET 8 and Verify.Xunit 30.3.0, I'm having the following test which should respect serializer settings, keeping properties with null values in the output, but this is not happening.

public class TypeWithNullableProperty
{
    public int? DebugPort { get; set; }
}

public async Task VerificationTest()
{
	var obj = new TypeWithNullableProperty();
	
	await Verifier.Verify(obj)
		.UseStrictJson()
		.AddExtraSettings(x =>
		{
			x.NullValueHandling = NullValueHandling.Include;
			x.Formatting = Formatting.Indented;
		});
}

Expected

{
	"DebugPort": null
}

Actual

{
}

[SimonCropp]

i suspect it is because DebugPort is not public

[SeanFeldman]

That's not the case, though. Even if public, the setting is not respected.
(I made a mistake in the snippet. The class and its property both should have been public.)

[SimonCropp]

i am going to need a stand alone repro.

i added a test for this scenario and it works

https://github.com/VerifyTests/Verify/blob/main/src/Verify.Tests/Serialization/SerializationTests.cs#L970

[SimonCropp]

hmmm r u missing DefaultValueHandling = DefaultValueHandling.Include ?

[SeanFeldman]

This might be it. I'll check.

[SeanFeldman]

Confirmed. That was the issue.
Thank you, @SimonCropp.

[SimonCropp]

also, is there some reason you are not using the static APIs for those tweaks? i would assume u want them to be global?

[SeanFeldman]

One test is an exception, so configuraiton is specific to the test.