Fix PR Review Issues

Author: Alonski

.travis.yml

@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "4"
+  - "8.10"
 
 sudo: false
 dist: trusty
@@ -36,7 +36,7 @@ matrix:
 
 before_install:
   - npm config set spin false
-  - npm install -g npm@4
+  - npm install -g npm@8.10
   - npm --version
 
 script:

config/ember-try.js

@@ -69,6 +69,6 @@ module.exports = {
       npm: {
         devDependencies: {}
       }
-    } */
+    }
   ]
 };

tests/dummy/app/templates/application.hbs

@@ -1,3 +1,3 @@
 <h2 id="title">Welcome to Ember</h2>
 
-{{outlet}}
+{{outlet}}

tests/helpers/module-for-acceptance.js

@@ -14,7 +14,7 @@ export default function(name, options = {}) {
     },
 
     afterEach() {
-      let afterEach = options.afterEach && options.afterEach.apply(this, arguments);
+      const afterEach = options.afterEach && options.afterEach.apply(this, arguments);
       return resolve(afterEach).then(() => destroyApp(this.application));
     }
   });

tests/helpers/start-app.js

@@ -9,7 +9,7 @@ export default function startApp(attrs) {
   attributes = merge(attributes, attrs); // use defaults, but you can override;
 
   return run(() => {
-    let application = Application.create(attributes);
+    const application = Application.create(attributes);
     application.setupForTesting();
     application.injectTestHelpers();
     return application;